You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by Greg Brown <gk...@verizon.net> on 2011/03/18 22:43:37 UTC
Re: svn commit: r1083076 - in
/pivot/trunk/wtk/src/org/apache/pivot/wtk: GridPane.java TableView.java
GridPane.Filler should still be final.
On Mar 18, 2011, at 5:32 PM, smartini@apache.org wrote:
> Author: smartini
> Date: Fri Mar 18 21:32:23 2011
> New Revision: 1083076
>
> URL: http://svn.apache.org/viewvc?rev=1083076&view=rev
> Log:
> PIVOT-713
>
> Modified:
> pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java
> pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java
>
> Modified: pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java
> URL: http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java?rev=1083076&r1=1083075&r2=1083076&view=diff
> ==============================================================================
> --- pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java (original)
> +++ pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java Fri Mar 18 21:32:23 2011
> @@ -32,7 +32,7 @@ public class GridPane extends Container
> /**
> * Represents a grid pane row.
> */
> - public static final class Row implements Sequence<Component>, Iterable<Component> {
> + public static class Row implements Sequence<Component>, Iterable<Component> {
> private ArrayList<Component> cells = new ArrayList<Component>();
>
> private GridPane gridPane = null;
> @@ -257,7 +257,7 @@ public class GridPane extends Container
> /**
> * Component that can be used as filler for empty cells.
> */
> - public static class Filler extends Component {
> + public static final class Filler extends Component {
> public Filler() {
> installSkin(Filler.class);
> }
>
> Modified: pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java
> URL: http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java?rev=1083076&r1=1083075&r2=1083076&view=diff
> ==============================================================================
> --- pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java (original)
> +++ pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java Fri Mar 18 21:32:23 2011
> @@ -49,7 +49,7 @@ public class TableView extends Component
> /**
> * Contains information about a table column.
> */
> - public static final class Column {
> + public static class Column {
> private TableView tableView = null;
>
> private String name = null;
>
>
Re: svn commit: r1083076 - in /pivot/trunk/wtk/src/org/apache/pivot/wtk:
GridPane.java TableView.java
Posted by Sandro Martini <sa...@gmail.com>.
Don't worry, the important is to fix things :-) ... and you know that
in many parts of Pivot I still need your help to find the right
"direction" ... thank you again for your patience.
Bye
Re: svn commit: r1083076 - in
/pivot/trunk/wtk/src/org/apache/pivot/wtk: GridPane.java TableView.java
Posted by Greg Brown <gk...@verizon.net>.
You are correct. I did not look closely enough. :-)
On Mar 18, 2011, at 6:22 PM, Sandro Martini wrote:
> Hi Greg,
>
>> GridPane.Filler should still be final.
> that's how it is now (before only Filler in TablePane was final), so
> they are aligned now.
>
> I hope this little change will be Ok ... if not, tell me.
>
> Bye
Re: svn commit: r1083076 - in
/pivot/trunk/wtk/src/org/apache/pivot/wtk: GridPane.java TableView.java
Posted by Greg Brown <gk...@verizon.net>.
You are correct. I did not look closely enough. :-)
On Mar 18, 2011, at 6:22 PM, Sandro Martini wrote:
> Hi Greg,
>
>> GridPane.Filler should still be final.
> that's how it is now (before only Filler in TablePane was final), so
> they are aligned now.
>
> I hope this little change will be Ok ... if not, tell me.
>
> Bye
Re: svn commit: r1083076 - in /pivot/trunk/wtk/src/org/apache/pivot/wtk:
GridPane.java TableView.java
Posted by Sandro Martini <sa...@gmail.com>.
Hi Greg,
> GridPane.Filler should still be final.
that's how it is now (before only Filler in TablePane was final), so
they are aligned now.
I hope this little change will be Ok ... if not, tell me.
Bye
>
> On Mar 18, 2011, at 5:32 PM, smartini@apache.org wrote:
>
>> Author: smartini
>> Date: Fri Mar 18 21:32:23 2011
>> New Revision: 1083076
>>
>> URL: http://svn.apache.org/viewvc?rev=1083076&view=rev
>> Log:
>> PIVOT-713
>>
>> Modified:
>> pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java
>> pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java
>>
>> Modified: pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java
>> URL: http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java?rev=1083076&r1=1083075&r2=1083076&view=diff
>> ==============================================================================
>> --- pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java (original)
>> +++ pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java Fri Mar 18 21:32:23 2011
>> @@ -32,7 +32,7 @@ public class GridPane extends Container
>> /**
>> * Represents a grid pane row.
>> */
>> - public static final class Row implements Sequence<Component>, Iterable<Component> {
>> + public static class Row implements Sequence<Component>, Iterable<Component> {
>> private ArrayList<Component> cells = new ArrayList<Component>();
>>
>> private GridPane gridPane = null;
>> @@ -257,7 +257,7 @@ public class GridPane extends Container
>> /**
>> * Component that can be used as filler for empty cells.
>> */
>> - public static class Filler extends Component {
>> + public static final class Filler extends Component {
>> public Filler() {
>> installSkin(Filler.class);
>> }
>>
>> Modified: pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java
>> URL: http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java?rev=1083076&r1=1083075&r2=1083076&view=diff
>> ==============================================================================
>> --- pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java (original)
>> +++ pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java Fri Mar 18 21:32:23 2011
>> @@ -49,7 +49,7 @@ public class TableView extends Component
>> /**
>> * Contains information about a table column.
>> */
>> - public static final class Column {
>> + public static class Column {
>> private TableView tableView = null;
>>
>> private String name = null;
>>
>>
>
>
Re: svn commit: r1083076 - in /pivot/trunk/wtk/src/org/apache/pivot/wtk:
GridPane.java TableView.java
Posted by Sandro Martini <sa...@gmail.com>.
Hi Greg,
> GridPane.Filler should still be final.
that's how it is now (before only Filler in TablePane was final), so
they are aligned now.
I hope this little change will be Ok ... if not, tell me.
Bye
>
> On Mar 18, 2011, at 5:32 PM, smartini@apache.org wrote:
>
>> Author: smartini
>> Date: Fri Mar 18 21:32:23 2011
>> New Revision: 1083076
>>
>> URL: http://svn.apache.org/viewvc?rev=1083076&view=rev
>> Log:
>> PIVOT-713
>>
>> Modified:
>> pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java
>> pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java
>>
>> Modified: pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java
>> URL: http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java?rev=1083076&r1=1083075&r2=1083076&view=diff
>> ==============================================================================
>> --- pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java (original)
>> +++ pivot/trunk/wtk/src/org/apache/pivot/wtk/GridPane.java Fri Mar 18 21:32:23 2011
>> @@ -32,7 +32,7 @@ public class GridPane extends Container
>> /**
>> * Represents a grid pane row.
>> */
>> - public static final class Row implements Sequence<Component>, Iterable<Component> {
>> + public static class Row implements Sequence<Component>, Iterable<Component> {
>> private ArrayList<Component> cells = new ArrayList<Component>();
>>
>> private GridPane gridPane = null;
>> @@ -257,7 +257,7 @@ public class GridPane extends Container
>> /**
>> * Component that can be used as filler for empty cells.
>> */
>> - public static class Filler extends Component {
>> + public static final class Filler extends Component {
>> public Filler() {
>> installSkin(Filler.class);
>> }
>>
>> Modified: pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java
>> URL: http://svn.apache.org/viewvc/pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java?rev=1083076&r1=1083075&r2=1083076&view=diff
>> ==============================================================================
>> --- pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java (original)
>> +++ pivot/trunk/wtk/src/org/apache/pivot/wtk/TableView.java Fri Mar 18 21:32:23 2011
>> @@ -49,7 +49,7 @@ public class TableView extends Component
>> /**
>> * Contains information about a table column.
>> */
>> - public static final class Column {
>> + public static class Column {
>> private TableView tableView = null;
>>
>> private String name = null;
>>
>>
>
>