[GitHub] [camel-kafka-connector] orpiske commented on pull request #752: Set JMS clients scope runtime to include required dependencies in the package

[GitBox <gi...@apache.org>]

orpiske commented on pull request #752:
URL: https://github.com/apache/camel-kafka-connector/pull/752#issuecomment-735640850


   @oscerd @valdar I believe you both have better understanding of the ramifications of this than I do. At first sight I have no objections with the approach, but I would kindly ask for one more thing. 
   
   Do we have to update the [missing dependencies part](https://github.com/apache/camel-kafka-connector/blob/master/docs/modules/ROOT/pages/troubleshooting.adoc) of the troubleshooting guide as part of this? 
   
   My understanding is that we do need to update the note there. Therefore, I would probably just put a note saying "From version 0.x.x and forward the JMS dependencies are packaged and this should not be a problem. Should you need to use other JMS clients, you need to repackage or use the legacy/regular/etc JMS component". 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org