You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/09/02 17:06:31 UTC
[GitHub] [kafka] cmccabe opened a new pull request, #12586: KAFKA-14200: kafka-features.sh must exit with non-zero error code on error
cmccabe opened a new pull request, #12586:
URL: https://github.com/apache/kafka/pull/12586
kafka-features.sh must exit with a non-zero error code on error. We must do this in order to catch
regressions like KAFKA-13990.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #12586: KAFKA-14200: kafka-features.sh must exit with non-zero error code on error
Posted by GitBox <gi...@apache.org>.
cmccabe merged PR #12586:
URL: https://github.com/apache/kafka/pull/12586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on a diff in pull request #12586: KAFKA-14200: kafka-features.sh must exit with non-zero error code on error
Posted by GitBox <gi...@apache.org>.
cmccabe commented on code in PR #12586:
URL: https://github.com/apache/kafka/pull/12586#discussion_r964178116
##########
clients/src/main/java/org/apache/kafka/common/utils/Exit.java:
##########
@@ -33,14 +33,22 @@ public interface ShutdownHookAdder {
private static final Procedure DEFAULT_HALT_PROCEDURE = new Procedure() {
@Override
public void execute(int statusCode, String message) {
- Runtime.getRuntime().halt(statusCode);
+ if (1 + 1 == 2) {
Review Comment:
yes, I added this because there is something calling `Exit()` (not KRaft-related), and killing entire test runs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #12586: KAFKA-14200: kafka-features.sh must exit with non-zero error code on error
Posted by GitBox <gi...@apache.org>.
cmccabe commented on PR #12586:
URL: https://github.com/apache/kafka/pull/12586#issuecomment-1238657851
> If we're performing multiple feature operations in one invocation, and one fails, we will just see exit code 1 with "1 out of N operation(s) failed". Can you confirm that we'll see individual errors as well as error code?
The existing test cases do cover that -- they check what is printed which includes the errors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #12586: KAFKA-14200: kafka-features.sh must exit with non-zero error code on error
Posted by GitBox <gi...@apache.org>.
cmccabe commented on PR #12586:
URL: https://github.com/apache/kafka/pull/12586#issuecomment-1235899799
It looks like something in the Streams tests is calling `exit 1`. I will see if this still happens with `Exit.exit` and `Exit.halt` stubbed out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe commented on pull request #12586: KAFKA-14200: kafka-features.sh must exit with non-zero error code on error
Posted by GitBox <gi...@apache.org>.
cmccabe commented on PR #12586:
URL: https://github.com/apache/kafka/pull/12586#issuecomment-1238332467
Test failures look like unrelated flakes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] mumrah commented on a diff in pull request #12586: KAFKA-14200: kafka-features.sh must exit with non-zero error code on error
Posted by GitBox <gi...@apache.org>.
mumrah commented on code in PR #12586:
URL: https://github.com/apache/kafka/pull/12586#discussion_r964045673
##########
clients/src/main/java/org/apache/kafka/common/utils/Exit.java:
##########
@@ -33,14 +33,22 @@ public interface ShutdownHookAdder {
private static final Procedure DEFAULT_HALT_PROCEDURE = new Procedure() {
@Override
public void execute(int statusCode, String message) {
- Runtime.getRuntime().halt(statusCode);
+ if (1 + 1 == 2) {
Review Comment:
Sounds like we can remove this?
##########
clients/src/main/java/org/apache/kafka/common/utils/Exit.java:
##########
@@ -33,14 +33,22 @@ public interface ShutdownHookAdder {
private static final Procedure DEFAULT_HALT_PROCEDURE = new Procedure() {
@Override
public void execute(int statusCode, String message) {
- Runtime.getRuntime().halt(statusCode);
+ if (1 + 1 == 2) {
+ throw new RuntimeException("HALT " + statusCode);
+ } else {
+ Runtime.getRuntime().halt(statusCode);
+ }
}
};
private static final Procedure DEFAULT_EXIT_PROCEDURE = new Procedure() {
@Override
public void execute(int statusCode, String message) {
- System.exit(statusCode);
+ if (1 + 1 == 2) {
Review Comment:
And this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org