You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2020/08/21 09:45:58 UTC
[GitHub] [curator] TisonKun opened a new pull request #373: CURATOR-581. fix OSGi export pattern
TisonKun opened a new pull request #373:
URL: https://github.com/apache/curator/pull/373
According to https://access.redhat.com/documentation/en-us/red_hat_fuse/7.2/html/deploying_into_apache_karaf/buildbundle this is the correct pattern for wildcard in export package config. Also it fixes the problem that IDEA complains with `The package 'org.apache.curator.framework.api' is not exported by the bundle dependencies`
cc @Randgalt @eolivelli @cammckenzie
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] TisonKun commented on pull request #373: CURATOR-581. fix OSGi export pattern
Posted by GitBox <gi...@apache.org>.
TisonKun commented on pull request #373:
URL: https://github.com/apache/curator/pull/373#issuecomment-678860923
Thanks for your reviews!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] TisonKun merged pull request #373: CURATOR-581. fix OSGi export pattern
Posted by GitBox <gi...@apache.org>.
TisonKun merged pull request #373:
URL: https://github.com/apache/curator/pull/373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] TisonKun commented on pull request #373: CURATOR-581. fix OSGi export pattern
Posted by GitBox <gi...@apache.org>.
TisonKun commented on pull request #373:
URL: https://github.com/apache/curator/pull/373#issuecomment-678597207
> I am not an oggi user but the change semestre reasonable.
>
> Is there any way to add an integration test that consumer our Osgi artifacts? This way we are sure that in the future we won't break it
Thanks for your review @eolivelli ! I hope so but failed to find some methods for testing the exports. BTW, it seems travis failed on unstable case. Retrigger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [curator] TisonKun closed pull request #373: CURATOR-581. fix OSGi export pattern
Posted by GitBox <gi...@apache.org>.
TisonKun closed pull request #373:
URL: https://github.com/apache/curator/pull/373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org