You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dead-1ine (via GitHub)" <gi...@apache.org> on 2024/09/09 13:15:06 UTC

[PR] Re-Add 'executor=None' argument in run() method [airflow]

dead-1ine opened a new pull request, #42102:
URL: https://github.com/apache/airflow/pull/42102

   Upon checking the blame history, I found that there were no specific changes that removed the executor=None keyword argument from this method. This argument was present in version 2.9, but for reasons that are unclear (or that I may have missed in my search), it seems to have been removed in the current version.
   
   Interestingly, the docstring for the method still references the executor argument, which suggests a discrepancy between the code and its documentation. Given this inconsistency, I am submitting this PR to restore the executor=None argument, ensuring that the method signature aligns with its intended functionality and the existing documentation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Re-Add 'executor=None' argument in run() method [airflow]

Posted by "dead-1ine (via GitHub)" <gi...@apache.org>.
dead-1ine commented on PR #42102:
URL: https://github.com/apache/airflow/pull/42102#issuecomment-2339008950

   After further investigation, I found that the removal of `executor=None` was intentional in the `v2-10-test` branch. Therefore, I'm closing this PR and will open a new one to update the docstring to match the current method signature.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Re-Add 'executor=None' argument in run() method [airflow]

Posted by "dead-1ine (via GitHub)" <gi...@apache.org>.
dead-1ine closed pull request #42102: Re-Add 'executor=None' argument in run() method
URL: https://github.com/apache/airflow/pull/42102


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org