You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2022/08/11 07:59:00 UTC

[jira] [Work logged] (AVRO-3601) C++ API header contains breaking include

     [ https://issues.apache.org/jira/browse/AVRO-3601?focusedWorklogId=799912&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799912 ]

ASF GitHub Bot logged work on AVRO-3601:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Aug/22 07:58
            Start Date: 11/Aug/22 07:58
    Worklog Time Spent: 10m 
      Work Description: martin-g opened a new pull request, #1820:
URL: https://github.com/apache/avro/pull/1820

   Move impl/json/JsonDom.hh to api/json/
   
   https://github.com/apache/avro/blob/ce2439d7a7669a5c7f2fa555c661770fbe67493a/lang/c%2B%2B/CMakeLists.txt#L97
   includes the 'api/' folder, CMAKE_CURRENT_BINARY_DIR and Boost's
   include dirs
   
   ### Jira
   
   - [X] https://issues.apache.org/jira/browse/AVRO-3601
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 799912)
    Remaining Estimate: 0h
            Time Spent: 10m

> C++ API header contains breaking include
> ----------------------------------------
>
>                 Key: AVRO-3601
>                 URL: https://issues.apache.org/jira/browse/AVRO-3601
>             Project: Apache Avro
>          Issue Type: Bug
>            Reporter: Mike Ruffing
>            Assignee: Martin Tzvetanov Grigorov
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Problem file/line: https://github.com/apache/avro/blob/master/lang/c%2B%2B/api/CustomFields.hh#L24
> Steps to reproduce:
>  * Download AVRO version 1.11.1
>  * Execute {{./build.sh install}} (from the {{lang/c++ directory}})
>  * Navigate to the installed {{include}} directory
>  * Verify this file (and path) {{"../impl/json/JsonDom.hh"}} does NOT exists in the installed {{include}} directory
> Relates to: https://issues.apache.org/jira/browse/AVRO-3547



--
This message was sent by Atlassian Jira
(v8.20.10#820010)