You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by be...@apache.org on 2025/07/18 18:54:04 UTC

(superset) 05/08: Sync metrics working

This is an automated email from the ASF dual-hosted git repository.

beto pushed a commit to branch dbt-metricflow
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 6a3ee1f44b9672e11557ca75fdc40da61e8dc06a
Author: Beto Dealmeida <ro...@dealmeida.net>
AuthorDate: Fri Jul 18 11:07:20 2025 -0400

    Sync metrics working
---
 .../src/components/Datasource/DatasourceEditor.jsx | 10 ++++++++--
 .../src/components/Datasource/utils.js             | 22 ++++++++++++++--------
 superset/datasets/api.py                           |  1 +
 3 files changed, 23 insertions(+), 10 deletions(-)

diff --git a/superset-frontend/src/components/Datasource/DatasourceEditor.jsx b/superset-frontend/src/components/Datasource/DatasourceEditor.jsx
index 728d14d7c5..4a353b8629 100644
--- a/superset-frontend/src/components/Datasource/DatasourceEditor.jsx
+++ b/superset-frontend/src/components/Datasource/DatasourceEditor.jsx
@@ -73,7 +73,12 @@ import { DatabaseSelector } from '../DatabaseSelector';
 import CollectionTable from './CollectionTable';
 import Fieldset from './Fieldset';
 import Field from './Field';
-import { fetchSyncedColumns, fetchSyncedMetrics, updateColumns, updateMetrics } from './utils';
+import {
+  fetchSyncedColumns,
+  fetchSyncedMetrics,
+  updateColumns,
+  updateMetrics,
+} from './utils';
 
 const extensionsRegistry = getExtensionsRegistry();
 
@@ -1732,7 +1737,8 @@ class DatasourceEditor extends PureComponent {
               ),
               children: (
                 <div>
-                  {this.state.datasource.database?.backend === 'metricflow' && (
+                  {this.state.datasource.database?.engine_information
+                    ?.supports_dynamic_columns && (
                     <ColumnButtonWrapper>
                       <StyledButtonWrapper>
                         <Button
diff --git a/superset-frontend/src/components/Datasource/utils.js b/superset-frontend/src/components/Datasource/utils.js
index 1a81d90460..b07571db68 100644
--- a/superset-frontend/src/components/Datasource/utils.js
+++ b/superset-frontend/src/components/Datasource/utils.js
@@ -155,17 +155,23 @@ export function updateMetrics(prevMetrics, newMetrics, addSuccessToast) {
   });
 
   const deletedMetrics = prevMetrics.filter(
-    metric => !sourceMetricNames.includes(metric.metric_name)
+    metric => !sourceMetricNames.includes(metric.metric_name),
   );
 
   const finalMetrics = [
-    ...prevMetrics.filter(metric => sourceMetricNames.includes(metric.metric_name)),
-    ...newOrUpdatedMetrics.filter(metric => !currentMetrics[metric.metric_name]),
+    ...prevMetrics.filter(metric =>
+      sourceMetricNames.includes(metric.metric_name),
+    ),
+    ...newOrUpdatedMetrics.filter(
+      metric => !currentMetrics[metric.metric_name],
+    ),
   ];
 
   // Update existing metrics with new data
   finalMetrics.forEach(metric => {
-    const sourceMetric = newMetrics.find(m => m.metric_name === metric.metric_name);
+    const sourceMetric = newMetrics.find(
+      m => m.metric_name === metric.metric_name,
+    );
     if (sourceMetric) {
       Object.assign(metric, sourceMetric);
     }
@@ -177,8 +183,8 @@ export function updateMetrics(prevMetrics, newMetrics, addSuccessToast) {
         'Metric %s was added',
         'Metrics %s were added',
         newOrUpdatedMetrics.length,
-        newOrUpdatedMetrics.map(metric => metric.metric_name).join(', ')
-      )
+        newOrUpdatedMetrics.map(metric => metric.metric_name).join(', '),
+      ),
     );
   }
 
@@ -188,8 +194,8 @@ export function updateMetrics(prevMetrics, newMetrics, addSuccessToast) {
         'Metric %s was deleted',
         'Metrics %s were deleted',
         deletedMetrics.length,
-        deletedMetrics.map(metric => metric.metric_name).join(', ')
-      )
+        deletedMetrics.map(metric => metric.metric_name).join(', '),
+      ),
     );
   }
 
diff --git a/superset/datasets/api.py b/superset/datasets/api.py
index 6800775e55..46d426f345 100644
--- a/superset/datasets/api.py
+++ b/superset/datasets/api.py
@@ -219,6 +219,7 @@ class DatasetRestApi(BaseSupersetModelRestApi):
         "columns.type_generic",
         "database.backend",
         "database.allow_multi_catalog",
+        "database.engine_information",
         "columns.advanced_data_type",
         "is_managed_externally",
         "uid",