[validator] regexp tests, patches for tests

[adam kramer <ad...@monkey.org>]

Hello all, never posted to the list, but I've been lurking for a bit.

Bug 17799
http://issues.apache.org/bugzilla/show_bug.cgi?id=17799
brought up that '/'s were not being escaped in regular expression patterns
(masks) so I decided to look into it. I found out that when I included
'/'s in the regexp value and did not escape them, a matching value for the
regexp passed regardless. I decided to formalize this with some unit tests
that cover one pattern with '/'s and another phone number pattern just to
verify that regexp pattern (masks) matching is working ok.

I've attached a RegexpTest.java file and another file of patches to get it
to run with 'ant test'. All tests are a go. If I should include patches
and new code in the body of the email just let me know. I figured it might
get passed up if I posted new code to bug database.

Thanks,
Adam Kramer

Re: [validator] regexp tests, patches for tests

[Rob Leland <rl...@apache.org>]

adam kramer wrote:

>Hello all, never posted to the list, but I've been lurking for a bit.
>
>Bug 17799
>http://issues.apache.org/bugzilla/show_bug.cgi?id=17799
>brought up that '/'s were not being escaped in regular expression patterns
>(masks) so I decided to look into it. I found out that when I included
>'/'s in the regexp value and did not escape them, a matching value for the
>regexp passed regardless. I decided to formalize this with some unit tests
>that cover one pattern with '/'s and another phone number pattern just to
>verify that regexp pattern (masks) matching is working ok.
>
>I've attached a RegexpTest.java file and another file of patches to get it
>to run with 'ant test'. All tests are a go. If I should include patches
>and new code in the body of the email just let me know. I figured it might
>get passed up if I posted new code to bug database.
>  
>

Some projects like it posted to the list like you have done, and other 
like a bugzilla report filed.
IN THIS CASE a Bugilla report is appropiate for Validator, I know it can 
be confusing, but please do
file a Bugilla report, an account , 
http://issues.apache.org/bugzilla/createaccount.cgi,
only takes 20 seconds and only required a valid email address from you.

-Rob


>Thanks,
>Adam Kramer
>



---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org