You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "ASolarers-Rodriguez (via GitHub)" <gi...@apache.org> on 2026/10/16 16:59:50 UTC
[PR] chore(deps): bump fonttools to 4.62.0 [superset]
ASolarers-Rodriguez opened a new pull request, #45383:
URL: https://github.com/apache/superset/pull/45383
### SUMMARY
Security bump of a dev-only transitive dependency to the first patched release:
| Package | From | To | Advisory |
|---|---|---|---|
| `fonttools` | 4.60.2 | 4.62.0 | Arbitrary code execution via `eval()` in `cffLib.parseBlendList()` from a crafted TTX file ([fonttools/fonttools#4039](https://github.com/fonttools/fonttools/issues/4039), fixed by [#4040](https://github.com/fonttools/fonttools/pull/4040); listed as **SECURITY** in the [4.62.0 changelog](https://github.com/fonttools/fonttools/blob/main/NEWS.rst)) |
`fonttools` only appears in `requirements/development.txt` (`matplotlib` โ `prophet` pull it in). It is not in `base.txt`, so production installs are unaffected.
Changes:
- `requirements/development.in`: add a commented security floor, `fonttools>=4.62.0,<5.0.0`, following the CVE-floor pattern in `requirements/base.in`. A future re-compile then can't resolve back to a vulnerable release.
- `requirements/development.txt`: regenerated. The pin moves from 4.60.2 to 4.62.0, and the `# via` block picks up `-r requirements/development.in` from the new floor. No other package moves.
Why 4.62.0: it is the lowest release with the fix. 4.61.0 and 4.61.1 still call `eval()` in `parseBlendList()`; 4.62.0 switches to `safeEval()`. OSV and GitHub's advisory database list no other open advisories for 4.62.0. The two published fonttools advisories, GHSA-6673-4983-2vx5 and GHSA-768j-98cg-p3fv, are fixed in 4.43.0 and 4.60.2. `matplotlib==3.9.0` only requires `fonttools>=4.28.2`.
**Verification** (only what actually ran):
- Ran `scripts/uv-pip-compile.sh` through its non-Docker branch (`RUNNING_IN_DOCKER=1`, CPython 3.11.15, uv 0.12.3). On unmodified `master` it produced no diff, so there was no pre-existing drift. With the floor added, two consecutive runs gave byte-identical lockfiles, and only `fonttools` changed.
- In a clean Python 3.11 venv with `fonttools==4.62.0`, `matplotlib==3.9.0`, and the repo's pinned `numpy`/`pandas`/`pillow`/`cmdstanpy`/`prophet`:
- `uv pip check` reported no conflicts.
- A plot rendered to PNG, PDF (which subsets fonts through fontTools) and SVG with the Agg backend.
- `prophet.plot` imported.
- Tested a `parseBlendList()` payload that tries to run a shell command. On 4.60.2 the command ran; on 4.62.0 `safeEval` raised `ValueError` and the command did not run.
- `pre-commit run` passed on the changed files.
- Superset's own code and tests don't import matplotlib or fontTools, so no repo test exercises this path directly. The full backend suite was not run locally; CI covers it.
### TESTING INSTRUCTIONS
- CI (`check-python-deps`, backend unit/integration tests) should pass unchanged.
- Locally: `pip install -r requirements/development.txt`, then `python -c "import fontTools, matplotlib; print(fontTools.version)"`. It should print `4.62.0`.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
๐ค Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): bump fonttools to 4.62.0 [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on PR #45383:
URL: https://github.com/apache/superset/pull/45383#issuecomment-6220659391
## CodeAnt PR Risk: Medium Risk
- The PR needs attention before merging because its fonttools security floor applies only to development installs.
- Production installs using the Prophet extra may still resolve a vulnerable fonttools version through matplotlib.
**Assessed commit:** `eac2e555a549`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): bump fonttools to 4.62.0 [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #45383:
URL: https://github.com/apache/superset/pull/45383#issuecomment-6220815650
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/45383?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 56.19%. Comparing base ([`86e186b`](https://app.codecov.io/gh/apache/superset/commit/86e186b5f60e821f13f1653393b566191272c3f5?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`eac2e55`](https://app.codecov.io/gh/apache/superset/commit/eac2e555a549bd9bba90832f797419f63e527e86?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between BASE (86e186b) and HEAD (eac2e55). Click for more details.
>
> <details><summary>HEAD has 4 uploads less than BASE</summary>
>
>| Flag | BASE (86e186b) | HEAD (eac2e55) |
>|------|------|------|
>|python|7|3|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #45383 +/- ##
===========================================
- Coverage 83.49% 56.19% -27.30%
===========================================
Files 3047 3047
Lines 199522 199522
Branches 46554 46554
===========================================
- Hits 166593 112131 -54462
- Misses 29702 86314 +56612
+ Partials 3227 1077 -2150
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/45383/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage ฮ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/45383/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.97% <รธ> (รธ)` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/45383/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/45383/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/45383/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `36.72% <รธ> (รธ)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/45383/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `36.76% <รธ> (-50.25%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/45383/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/45383/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/45383?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): bump fonttools to 4.62.0 [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #45383:
URL: https://github.com/apache/superset/pull/45383#discussion_r4385254324
##########
requirements/development.in:
##########
@@ -61,3 +61,8 @@ testcontainers[cockroachdb,cratedb,mongodb,mssql,mysql,oracle,postgres,trino]>=4
# raises `zope.interface.exceptions.InvalidInterface` outright on 3.13.
# 7.2 is the first release with explicit handling for it.
zope.interface>=7.2
+
+# Security: fonttools (via matplotlib) < 4.62.0 evaluates TTX XML values with
+# eval() in cffLib parseBlendList(), allowing arbitrary code execution from a
+# crafted TTX file (fonttools/fonttools#4039, fixed in 4.62.0 by #4040).
+fonttools>=4.62.0,<5.0.0
Review Comment:
โ
**Customized review instruction saved!**
**Instruction:**
> Do not block individual development-requirement security floors because they do not constrain optional extras installed from PyPI; treat security floors for extras as a separate, broader packaging issue.
**Applied to:**
- `requirements/development.in`
---
๐ก *To manage or update this instruction, visit: [CodeAnt AI Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): bump fonttools to 4.62.0 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #45383:
URL: https://github.com/apache/superset/pull/45383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): bump fonttools to 4.62.0 [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #45383:
URL: https://github.com/apache/superset/pull/45383#discussion_r4297210592
##########
requirements/development.in:
##########
@@ -61,3 +61,8 @@ testcontainers[cockroachdb,cratedb,mongodb,mssql,mysql,oracle,postgres,trino]>=4
# raises `zope.interface.exceptions.InvalidInterface` outright on 3.13.
# 7.2 is the first release with explicit handling for it.
zope.interface>=7.2
+
+# Security: fonttools (via matplotlib) < 4.62.0 evaluates TTX XML values with
+# eval() in cffLib parseBlendList(), allowing arbitrary code execution from a
+# crafted TTX file (fonttools/fonttools#4039, fixed in 4.62.0 by #4040).
+fonttools>=4.62.0,<5.0.0
Review Comment:
**Suggestion:** This floor applies only to development installs; `apache-superset[prophet]` can still resolve vulnerable `fonttools` through Prophet's `matplotlib` dependency.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Security`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill) [](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b0c733c127b84fe0a1a9f1c4f0f9f805&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b0c733c127b84fe0a1a9f1c4f0f9f805&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** requirements/development.in
**Line:** 68:68
**Comment:**
*Security: This floor applies only to development installs; `apache-superset[prophet]` can still resolve vulnerable `fonttools` through Prophet's `matplotlib` dependency.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45383&comment_hash=094d5cd91aa5005db19e2d8bd7b336825c3f97ac1d1cf9084fd00ecf64f1fbec&reaction=like'>๐</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F45383&comment_hash=094d5cd91aa5005db19e2d8bd7b336825c3f97ac1d1cf9084fd00ecf64f1fbec&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore(deps): bump fonttools to 4.62.0 [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #45383:
URL: https://github.com/apache/superset/pull/45383#discussion_r4385252155
##########
requirements/development.in:
##########
@@ -61,3 +61,8 @@ testcontainers[cockroachdb,cratedb,mongodb,mssql,mysql,oracle,postgres,trino]>=4
# raises `zope.interface.exceptions.InvalidInterface` outright on 3.13.
# 7.2 is the first release with explicit handling for it.
zope.interface>=7.2
+
+# Security: fonttools (via matplotlib) < 4.62.0 evaluates TTX XML values with
+# eval() in cffLib parseBlendList(), allowing arbitrary code execution from a
+# crafted TTX file (fonttools/fonttools#4039, fixed in 4.62.0 by #4040).
+fonttools>=4.62.0,<5.0.0
Review Comment:
Same answer as on the fastmcp-side CVE floors: this is a gap in how `prophet` (and every other optional extra) is packaged, not something this PR owes us. None of the ~50 extras in `pyproject.toml` carry their own security floor, so `apache-superset[prophet]` installed straight from PyPI has never been protected by anything in this repo. Worth a follow-up issue on extras getting their own floors in general, but not a blocker here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org