You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/04/24 10:15:50 UTC
[GitHub] zeppelin pull request #2941: [ZEPPELIN-3311] Zeppelin should ask user to re-...
GitHub user prabhjyotsingh opened a pull request:
https://github.com/apache/zeppelin/pull/2941
[ZEPPELIN-3311] Zeppelin should ask user to re-login after JWT cookie expires (KnoxJwtRealm)
### What is this PR for?
Zeppelin should ask user to re-login after JWT cookie expires.
### What type of PR is it?
[Bug Fix]
### What is the Jira issue?
* [ZEPPELIN-3311](https://issues.apache.org/jira/browse/ZEPPELIN-3311)
### How should this be tested?
Steps to reproduce :
1) Enable SSO for zeppelin
2) Login to zeppelin using SSO.
3) Now wait till JWT expires(knoxsso.token.ttl under Advanced knoxsso-topology could be set to lower values to get a short lived cookie)
4) Refresh zeppelin. Zeppelin doesn't ask for re-login, though JWT is already expired and not valid anymore.
### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3311
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2941.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2941
----
commit 0014d5ad81ba3834c5af06873fda017c7039697f
Author: Prabhjyot Singh <pr...@...>
Date: 2018-04-24T10:12:55Z
ZEPPELIN-3311: Zeppelin should ask user to re-login after JWT cookie expires (KnoxJwtRealm)
Change-Id: I3957863fb030a3d3426d88576a4aa149d00edc39
----
---
[GitHub] zeppelin issue #2941: [ZEPPELIN-3311] Zeppelin should ask user to re-login a...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/zeppelin/pull/2941
LGTM
---
[GitHub] zeppelin issue #2941: [ZEPPELIN-3311] Zeppelin should ask user to re-login a...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2941
Thanks for the review will merge this if no more discussion.
---
[GitHub] zeppelin issue #2941: [ZEPPELIN-3311] Zeppelin should ask user to re-login a...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the issue:
https://github.com/apache/zeppelin/pull/2941
@r-kamath @zjffdu can you help review this PR.
---
[GitHub] zeppelin pull request #2941: [ZEPPELIN-3311] Zeppelin should ask user to re-...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2941
---