You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/03/22 17:48:35 UTC

[GitHub] eiri opened a new pull request #1231: Remove resource expensive bcrypt test

eiri opened a new pull request #1231: Remove resource expensive bcrypt test
URL: https://github.com/apache/couchdb/pull/1231
 
 
   Since we are using 3rd party app for `bcrypt` and `couch_passwords: bcrypt/2` is just an interface for it there are no need to test correctness of the lib itself, just the fact that we are using it properly.
   
   Test `bcrypt_logRounds_18` is kind of a resource hog, so I suggest to remove it to easy a  burden on Travis and Jenkins. This reduces the test runtime on my laptop from 75s to 15s and I suspect the difference for CI will be even greater.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services