You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/09/04 22:05:26 UTC
[GitHub] [incubator-mxnet] anirudhacharya commented on a change in pull
request #16053: Fixes #15543
anirudhacharya commented on a change in pull request #16053: Fixes #15543
URL: https://github.com/apache/incubator-mxnet/pull/16053#discussion_r320995909
##########
File path: tests/python/unittest/test_optimizer.py
##########
@@ -396,6 +397,7 @@ def update(self, index, weight, grad, state):
weight32[:] += -lr * (grad32 + wd * weight32)
else:
weight32[:] += (self.momentum**2 * mom) - lr*(self.momentum+1)*(grad32 + wd*weight32)
+ mom = (self.momentum*mom) - lr*(grad32 + wd*weight32)
Review comment:
why? but that is not nesterov logic right?
![image](https://user-images.githubusercontent.com/2778341/64295137-695db800-cf25-11e9-880e-250298b2df12.png)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services