You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by John Speidel <js...@hortonworks.com> on 2014/03/20 00:46:00 UTC
Review Request 19432: Fix DB upgrade to use correct column types for table
blueprint_configuration
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19432/
-----------------------------------------------------------
Review request for Ambari and Sid Wagle.
Bugs: AMBARI-5153
https://issues.apache.org/jira/browse/AMBARI-5153
Repository: ambari
Description
-------
Fixes incorrect column type for table blueprint_configuration specified in UpgradeCatalog150.
The previous type, String.class, had too long a length value for Oracle.
Switched to byte[]. Also fixed Oracle create script to use CLOB.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java eb253a4
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql afe6497
Diff: https://reviews.apache.org/r/19432/diff/
Testing
-------
unit tests
OK
----------------------------------------------------------------------
Total run:507
Total errors:0
Total failures:0
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18:44.044s
[INFO] Finished at: Wed Mar 19 19:34:38 EDT 2014
[INFO] Final Memory: 28M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
John Speidel
Re: Review Request 19432: Fix DB upgrade to use correct column types for
table blueprint_configuration
Posted by John Speidel <js...@hortonworks.com>.
> On March 19, 2014, 11:51 p.m., Sid Wagle wrote:
> > Don't you want to change the data type to a blob type for Postgres / MySQL. It is probably inconsequential but I would have.
I kept it as it was because it is consistent with the other config_data types. I agree that the current type is odd but it was suggested to me that it be used to be consistent. We should consider changing all of the config_data columns in s separate patch.
- John
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19432/#review37825
-----------------------------------------------------------
On March 19, 2014, 11:45 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19432/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 11:45 p.m.)
>
>
> Review request for Ambari and Sid Wagle.
>
>
> Bugs: AMBARI-5153
> https://issues.apache.org/jira/browse/AMBARI-5153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixes incorrect column type for table blueprint_configuration specified in UpgradeCatalog150.
> The previous type, String.class, had too long a length value for Oracle.
> Switched to byte[]. Also fixed Oracle create script to use CLOB.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java eb253a4
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql afe6497
>
> Diff: https://reviews.apache.org/r/19432/diff/
>
>
> Testing
> -------
>
> unit tests
> OK
> ----------------------------------------------------------------------
> Total run:507
> Total errors:0
> Total failures:0
> ...
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:44.044s
> [INFO] Finished at: Wed Mar 19 19:34:38 EDT 2014
> [INFO] Final Memory: 28M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> John Speidel
>
>
Re: Review Request 19432: Fix DB upgrade to use correct column types for
table blueprint_configuration
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19432/#review37825
-----------------------------------------------------------
Ship it!
Don't you want to change the data type to a blob type for Postgres / MySQL. It is probably inconsequential but I would have.
- Sid Wagle
On March 19, 2014, 11:45 p.m., John Speidel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19432/
> -----------------------------------------------------------
>
> (Updated March 19, 2014, 11:45 p.m.)
>
>
> Review request for Ambari and Sid Wagle.
>
>
> Bugs: AMBARI-5153
> https://issues.apache.org/jira/browse/AMBARI-5153
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Fixes incorrect column type for table blueprint_configuration specified in UpgradeCatalog150.
> The previous type, String.class, had too long a length value for Oracle.
> Switched to byte[]. Also fixed Oracle create script to use CLOB.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog150.java eb253a4
> ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql afe6497
>
> Diff: https://reviews.apache.org/r/19432/diff/
>
>
> Testing
> -------
>
> unit tests
> OK
> ----------------------------------------------------------------------
> Total run:507
> Total errors:0
> Total failures:0
> ...
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 18:44.044s
> [INFO] Finished at: Wed Mar 19 19:34:38 EDT 2014
> [INFO] Final Memory: 28M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> John Speidel
>
>