[GitHub] [incubator-pinot] icefury71 commented on a change in pull request #4585: Presence vector

[GitBox <gi...@apache.org>]

icefury71 commented on a change in pull request #4585: Presence vector
URL: https://github.com/apache/incubator-pinot/pull/4585#discussion_r338210361
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/common/DataSource.java
 ##########
 @@ -45,4 +46,7 @@
    * Returns the bloom filter for the data source if exists, or {@code null} if not.
    */
   public abstract BloomFilterReader getBloomFilter();
+
+  public abstract PresenceVectorReader getPresenceVector();
 
 Review comment:
   PresenceVectorReader has a method called "isPresent(docId)" . So it is in fact a presence value vector (although internally it uses a null vector). 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org