You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/20 11:32:35 UTC
[GitHub] [incubator-dolphinscheduler] codecov-io commented on issue #1532:
fix MasterBaseTaskExecThread submit method bug
codecov-io commented on issue #1532: fix MasterBaseTaskExecThread submit method bug
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1532#issuecomment-567894912
# [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532?src=pr&el=h1) Report
> Merging [#1532](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532?src=pr&el=desc) into [dev](https://codecov.io/gh/apache/incubator-dolphinscheduler/commit/1868c56764a380a7dca80429c90b8faf58e2b51f?src=pr&el=desc) will **increase** coverage by `0.42%`.
> The diff coverage is `96.55%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532/graphs/tree.svg?width=650&token=bv9iXXRLi9&height=150&src=pr)](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## dev #1532 +/- ##
========================================
+ Coverage 6.97% 7.4% +0.42%
========================================
Files 272 272
Lines 13622 13647 +25
Branches 2168 2172 +4
========================================
+ Hits 950 1010 +60
+ Misses 12605 12570 -35
Partials 67 67
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ler/server/master/runner/MasterTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyVGFza0V4ZWNUaHJlYWQuamF2YQ==) | `0% <ø> (ø)` | :arrow_up: |
| [...server/master/runner/MasterBaseTaskExecThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9ydW5uZXIvTWFzdGVyQmFzZVRhc2tFeGVjVGhyZWFkLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...cheduler/server/worker/runner/FetchTaskThread.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL3dvcmtlci9ydW5uZXIvRmV0Y2hUYXNrVGhyZWFkLmphdmE=) | `0% <ø> (ø)` | :arrow_up: |
| [...pache/dolphinscheduler/common/utils/FileUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvY29tbW9uL3V0aWxzL0ZpbGVVdGlscy5qYXZh) | `16.83% <100%> (ø)` | :arrow_up: |
| [...he/dolphinscheduler/alert/utils/PropertyUtils.java](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532/diff?src=pr&el=tree#diff-ZG9scGhpbnNjaGVkdWxlci1hbGVydC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZG9scGhpbnNjaGVkdWxlci9hbGVydC91dGlscy9Qcm9wZXJ0eVV0aWxzLmphdmE=) | `88.23% <96.29%> (+88.23%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532?src=pr&el=footer). Last update [1868c56...7bb0beb](https://codecov.io/gh/apache/incubator-dolphinscheduler/pull/1532?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services