You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/19 12:56:03 UTC

[GitHub] [doris] xinyiZzz opened a new pull request, #13491: [branch-1.1-lts](cherry-pick) Fix bthread local consume mem tracker

xinyiZzz opened a new pull request, #13491:
URL: https://github.com/apache/doris/pull/13491

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   cherry-pick #13368 and some other modify
   
   Previously, bthread_getspecific was called every time bthread local was used. In the test at https://github.com/apache/doris/pull/10823, it was found that frequent calls to bthread_getspecific had performance problems.
   
   So a cache is implemented on pthread local based on the btls key, but the btls key cannot correctly sense bthread switching.
   
   So, based on bthread_self to get the bthread id to implement the cache.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [ ] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [ ] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [ ] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [ ] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #13491: [branch-1.1-lts](cherry-pick) Fix bthread local consume mem tracker

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13491:
URL: https://github.com/apache/doris/pull/13491#issuecomment-1284990203

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] yiguolei merged pull request #13491: [branch-1.1-lts](cherry-pick) Fix bthread local consume mem tracker

Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #13491:
URL: https://github.com/apache/doris/pull/13491


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [doris] github-actions[bot] commented on pull request #13491: [branch-1.1-lts](cherry-pick) Fix bthread local consume mem tracker

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13491:
URL: https://github.com/apache/doris/pull/13491#issuecomment-1284990254

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org