You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2022/03/07 15:31:13 UTC
[GitHub] [avro] zcsizmadia opened a new pull request #1583: AVRO-3435: Add --version to avrogen tool
zcsizmadia opened a new pull request #1583:
URL: https://github.com/apache/avro/pull/1583
Make sure you have checked _all_ steps below.
### Jira
- [X] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO-3435
- https://issues.apache.org/jira/browse/AVRO-3435
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [X] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [X] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] KyleSchoonover commented on a change in pull request #1583: AVRO-3435: Add --version to avrogen tool
Posted by GitBox <gi...@apache.org>.
KyleSchoonover commented on a change in pull request #1583:
URL: https://github.com/apache/avro/pull/1583#discussion_r822108706
##########
File path: lang/csharp/src/apache/codegen/AvroGen.cs
##########
@@ -39,6 +40,13 @@ static int Main(string[] args)
return 0;
}
+ if (args.Contains("--version"))
Review comment:
Is the expectation to also support -V? `args.Any(a => a is "--version" or "-V")` <-- Apparently this is only C# 8
`if (args.Contains("--version") || args.Contains("-V") )`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1583: AVRO-3435: Add --version to avrogen tool
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1583:
URL: https://github.com/apache/avro/pull/1583#issuecomment-1064180010
Unit tests should be added after #1595 is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on a change in pull request #1583: AVRO-3435: Add --version to avrogen tool
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on a change in pull request #1583:
URL: https://github.com/apache/avro/pull/1583#discussion_r830411718
##########
File path: lang/csharp/src/apache/codegen/AvroGen.cs
##########
@@ -39,6 +40,13 @@ static int Main(string[] args)
return 0;
}
+ if (args.Contains("--version"))
Review comment:
Good catch. I added -V to the cpp avrogen and I intended to add for C# as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] martin-g merged pull request #1583: AVRO-3435: Add --version to avrogen tool
Posted by GitBox <gi...@apache.org>.
martin-g merged pull request #1583:
URL: https://github.com/apache/avro/pull/1583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] zcsizmadia commented on pull request #1583: AVRO-3435: Add --version to avrogen tool
Posted by GitBox <gi...@apache.org>.
zcsizmadia commented on pull request #1583:
URL: https://github.com/apache/avro/pull/1583#issuecomment-1073264792
@martin-g I added some addition unit tests to make sure that the version returned by avrogen and the version for the main library match and both are SemVer2.0 compliant. Additionally added some tests to make sure that some mandatory attrributes are always defined (e.g. Company, Description ...)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org