You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "otaviojava (GitHub)" <gi...@apache.org> on 2019/01/02 13:34:04 UTC
[GitHub] [tinkerpop] otaviojava opened pull request #1029: Updates
the API within the core project.
## These updates include:
* Update to foreach
* Unnecessary unboxing
* Simplifies code with the newest method at Map
* Simplifies code with lambda expressions
This PR does not have performance progress, but it uses new API to make the code more readable and easy to maintain.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] otaviojava commented on issue #1029: Updates the
API within the core project.
Posted by "otaviojava (GitHub)" <gi...@apache.org>.
retest this please
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on issue #1029: Updates the
API within the core project.
Posted by "spmallette (GitHub)" <gi...@apache.org>.
sorry - i've been in the midst of releasing TinkerPop so i haven't had a chance to take a look at this yet. i can probably get to this by the end of the week.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on issue #1029: Updates the
API within the core project.
Posted by "spmallette (GitHub)" <gi...@apache.org>.
If we have to make these sorts of changes, I think that this PR should target the `tp33` branch so that both of our release branches have the same consistent look to them.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] otaviojava commented on pull request #1029:
Updates the API within the core project.
Posted by "otaviojava (GitHub)" <gi...@apache.org>.
Thank you, fixed.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] dkuppitz commented on pull request #1029:
Updates the API within the core project.
Posted by "dkuppitz (GitHub)" <gi...@apache.org>.
`ThreadLocal.withInitial(ArrayList::new)`
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] otaviojava commented on pull request #1029:
Updates the API within the core project.
Posted by "otaviojava (GitHub)" <gi...@apache.org>.
Thank you, fixed.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on issue #1029:
Updates the API within the core project.
Posted by "FlorianHockmann (GitHub)" <gi...@apache.org>.
> retest this please
I just triggered a new build on Travis.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] otaviojava commented on issue #1029: Updates the
API within the core project.
Posted by "otaviojava (GitHub)" <gi...@apache.org>.
Nice, as soon it is merged we can work in a cherry-pick :)
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] dkuppitz commented on pull request #1029:
Updates the API within the core project.
Posted by "dkuppitz (GitHub)" <gi...@apache.org>.
`ThreadLocal.withInitial(ArrayDeque::new)` to follow the previous patterns.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] spmallette commented on issue #1029: Updates the
API within the core project.
Posted by "spmallette (GitHub)" <gi...@apache.org>.
I hate to be a bother but our git workflow goes from `tp33 --> master`. we typically don't make it a habit of cherrypicking commits backwards in the flow as it makes the git history messy.
i'd much prefer a rebase on tp33 with a squash of all these commits into one. we can then merge forward to master. if you need to apply additional changes on master as they only apply there then that can come as a separate PR. In general, it's best to always target tp33 with your PRs unless there is explicit reason not to. If you ever have doubts on what branch to target, feel free to ask ahead of time.
sorry for the hassle and thank you.
[ Full content available at: https://github.com/apache/tinkerpop/pull/1029 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org