You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/17 09:05:50 UTC
[GitHub] [incubator-shardingsphere] cherrylzhao opened a new pull request
#5218: support mysql-client8 for sharding-proxy
cherrylzhao opened a new pull request #5218: support mysql-client8 for sharding-proxy
URL: https://github.com/apache/incubator-shardingsphere/pull/5218
implement AUTH_PLUGIN and AUTHENTICATION_METHOD_MISMATCH to support mysql8 in sharding-proxy according https://dev.mysql.com/doc/internals/en/connection-phase.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5218:
support mysql-client8 for sharding-proxy
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5218: support mysql-client8 for sharding-proxy
URL: https://github.com/apache/incubator-shardingsphere/pull/5218#issuecomment-615152301
## Pull Request Test Coverage Report for [Build 11103](https://coveralls.io/builds/30141998)
* **44** of **51** **(86.27%)** changed or added relevant lines in **9** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.03%**) to **57.453%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/auth/MySQLAuthenticationEngine.java](https://coveralls.io/builds/30141998/source?filename=sharding-proxy%2Fsharding-proxy-frontend%2Fsharding-proxy-frontend-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingproxy%2Ffrontend%2Fmysql%2Fauth%2FMySQLAuthenticationEngine.java#L105) | 27 | 28 | 96.43%
| [shardingsphere-database-protocol/shardingsphere-database-protocol-mysql/src/main/java/org/apache/shardingsphere/database/protocol/mysql/packet/handshake/MySQLAuthSwitchRequestPacket.java](https://coveralls.io/builds/30141998/source?filename=shardingsphere-database-protocol%2Fshardingsphere-database-protocol-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdatabase%2Fprotocol%2Fmysql%2Fpacket%2Fhandshake%2FMySQLAuthSwitchRequestPacket.java#L30) | 4 | 5 | 80.0%
| [shardingsphere-database-protocol/shardingsphere-database-protocol-mysql/src/main/java/org/apache/shardingsphere/database/protocol/mysql/constant/MySQLConnectionPhase.java](https://coveralls.io/builds/30141998/source?filename=shardingsphere-database-protocol%2Fshardingsphere-database-protocol-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdatabase%2Fprotocol%2Fmysql%2Fconstant%2FMySQLConnectionPhase.java#L25) | 0 | 2 | 0.0%
| [shardingsphere-database-protocol/shardingsphere-database-protocol-mysql/src/main/java/org/apache/shardingsphere/database/protocol/mysql/payload/MySQLPacketPayload.java](https://coveralls.io/builds/30141998/source?filename=shardingsphere-database-protocol%2Fshardingsphere-database-protocol-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdatabase%2Fprotocol%2Fmysql%2Fpayload%2FMySQLPacketPayload.java#L406) | 0 | 3 | 0.0%
<!-- | **Total:** | **44** | **51** | **86.27%** | -->
| Totals | [](https://coveralls.io/builds/30141998) |
| :-- | --: |
| Change from base [Build 11100](https://coveralls.io/builds/30137476): | 0.03% |
| Covered Lines: | 11856 |
| Relevant Lines: | 20636 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5218:
support mysql-client8 for sharding-proxy
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5218: support mysql-client8 for sharding-proxy
URL: https://github.com/apache/incubator-shardingsphere/pull/5218#issuecomment-615150781
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218?src=pr&el=h1) Report
> Merging [#5218](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/f102fa5557566534c0a4a25d7af2dba44af8dc34&el=desc) will **decrease** coverage by `0.07%`.
> The diff coverage is `72.54%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5218 +/- ##
============================================
- Coverage 54.07% 53.99% -0.08%
- Complexity 406 408 +2
============================================
Files 1159 1162 +3
Lines 20604 20636 +32
Branches 3712 3717 +5
============================================
+ Hits 11141 11143 +2
- Misses 8766 8793 +27
- Partials 697 700 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../protocol/mysql/constant/MySQLConnectionPhase.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL2NvbnN0YW50L015U1FMQ29ubmVjdGlvblBoYXNlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...cket/handshake/MySQLHandshakeResponse41Packet.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxIYW5kc2hha2VSZXNwb25zZTQxUGFja2V0LmphdmE=) | `95.83% <0.00%> (-2.09%)` | `0.00 <0.00> (ø)` | |
| [...ase/protocol/mysql/payload/MySQLPacketPayload.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BheWxvYWQvTXlTUUxQYWNrZXRQYXlsb2FkLmphdmE=) | `97.05% <0.00%> (-2.95%)` | `0.00 <0.00> (ø)` | |
| [...l/mysql/packet/handshake/MySQLHandshakePacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxIYW5kc2hha2VQYWNrZXQuamF2YQ==) | `81.48% <25.00%> (-7.41%)` | `1.00 <0.00> (ø)` | |
| [...packet/handshake/MySQLAuthSwitchRequestPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxBdXRoU3dpdGNoUmVxdWVzdFBhY2tldC5qYXZh) | `80.00% <80.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...frontend/mysql/auth/MySQLAuthenticationEngine.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktZnJvbnRlbmQvc2hhcmRpbmctcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5ncHJveHkvZnJvbnRlbmQvbXlzcWwvYXV0aC9NeVNRTEF1dGhlbnRpY2F0aW9uRW5naW5lLmphdmE=) | `87.17% <85.71%> (+0.22%)` | `0.00 <0.00> (ø)` | |
| [...rontend/mysql/auth/MySQLAuthenticationHandler.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218/diff?src=pr&el=tree#diff-c2hhcmRpbmctcHJveHkvc2hhcmRpbmctcHJveHktZnJvbnRlbmQvc2hhcmRpbmctcHJveHktZnJvbnRlbmQtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5ncHJveHkvZnJvbnRlbmQvbXlzcWwvYXV0aC9NeVNRTEF1dGhlbnRpY2F0aW9uSGFuZGxlci5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...e/protocol/mysql/constant/MySQLCapabilityFlag.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL2NvbnN0YW50L015U1FMQ2FwYWJpbGl0eUZsYWcuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...acket/handshake/MySQLAuthSwitchResponsePacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9oYW5kc2hha2UvTXlTUUxBdXRoU3dpdGNoUmVzcG9uc2VQYWNrZXQuamF2YQ==) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...gscaling/core/synctask/DefaultSyncTaskFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218/diff?src=pr&el=tree#diff-c2hhcmRpbmctc2NhbGluZy9zaGFyZGluZy1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nc2NhbGluZy9jb3JlL3N5bmN0YXNrL0RlZmF1bHRTeW5jVGFza0ZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [46 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218?src=pr&el=footer). Last update [f102fa5...0f70138](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5218?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #5218:
support mysql-client8 for sharding-proxy
Posted by GitBox <gi...@apache.org>.
tuohai666 merged pull request #5218: support mysql-client8 for sharding-proxy
URL: https://github.com/apache/incubator-shardingsphere/pull/5218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services