You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/30 06:53:22 UTC

[GitHub] [incubator-nuttx] yamt opened a new pull request #650: sim: Remove CONFIG_SIM_M32 and CONFIG_ELF where unnecessary

yamt opened a new pull request #650: sim: Remove CONFIG_SIM_M32 and CONFIG_ELF where unnecessary
URL: https://github.com/apache/incubator-nuttx/pull/650
 
 
   Namely these defconfig files:
   
       boards/sim/sim/sim/configs/mtdpart/defconfig
       boards/sim/sim/sim/configs/mtdrwb/defconfig
       boards/sim/sim/sim/configs/rpproxy/defconfig
       boards/sim/sim/sim/configs/rpserver/defconfig
       boards/sim/sim/sim/configs/tcpblaster/defconfig
   
   Because the recent versions of macOS is 64-bit only and thus
   incompatible with CONFIG_SIM_M32=y.
   
   The following defconfig files are left intact as these configs
   are important for them:
   
       boards/sim/sim/sim/configs/loadable/defconfig
       boards/sim/sim/sim/configs/module32/defconfig

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #650: sim: Remove CONFIG_SIM_M32 and CONFIG_ELF where unnecessary

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #650: sim: Remove CONFIG_SIM_M32 and CONFIG_ELF where unnecessary
URL: https://github.com/apache/incubator-nuttx/pull/650
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #650: sim: Remove CONFIG_SIM_M32 and CONFIG_ELF where unnecessary

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #650:
URL: https://github.com/apache/incubator-nuttx/pull/650#discussion_r469144195



##########
File path: boards/sim/sim/sim/configs/rpserver/defconfig
##########
@@ -54,7 +54,6 @@ CONFIG_SCHED_CHILD_STATUS=y
 CONFIG_SCHED_HAVE_PARENT=y
 CONFIG_SCHED_HPWORK=y
 CONFIG_SCHED_WAITPID=y
-CONFIG_SIM_M32=y

Review comment:
       But the 64bit rpproxy/rpserver will crash directly, so it's better to skip some build on macOS, maybe enhance datalist format like this:
   sim:rpproxy,!macOS




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #650: sim: Remove CONFIG_SIM_M32 and CONFIG_ELF where unnecessary

Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #650:
URL: https://github.com/apache/incubator-nuttx/pull/650#discussion_r469140299



##########
File path: boards/sim/sim/sim/configs/rpserver/defconfig
##########
@@ -54,7 +54,6 @@ CONFIG_SCHED_CHILD_STATUS=y
 CONFIG_SCHED_HAVE_PARENT=y
 CONFIG_SCHED_HPWORK=y
 CONFIG_SCHED_WAITPID=y
-CONFIG_SIM_M32=y

Review comment:
       no. the recent versions of macOS are 64-bit only.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #650: sim: Remove CONFIG_SIM_M32 and CONFIG_ELF where unnecessary

Posted by GitBox <gi...@apache.org>.
yamt commented on a change in pull request #650:
URL: https://github.com/apache/incubator-nuttx/pull/650#discussion_r469148758



##########
File path: boards/sim/sim/sim/configs/rpserver/defconfig
##########
@@ -54,7 +54,6 @@ CONFIG_SCHED_CHILD_STATUS=y
 CONFIG_SCHED_HAVE_PARENT=y
 CONFIG_SCHED_HPWORK=y
 CONFIG_SCHED_WAITPID=y
-CONFIG_SIM_M32=y

Review comment:
       maybe we can just preprocess the list with m4 or cpp or whatever.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #650: sim: Remove CONFIG_SIM_M32 and CONFIG_ELF where unnecessary

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #650:
URL: https://github.com/apache/incubator-nuttx/pull/650#discussion_r468443051



##########
File path: boards/sim/sim/sim/configs/rpserver/defconfig
##########
@@ -54,7 +54,6 @@ CONFIG_SCHED_CHILD_STATUS=y
 CONFIG_SCHED_HAVE_PARENT=y
 CONFIG_SCHED_HPWORK=y
 CONFIG_SCHED_WAITPID=y
-CONFIG_SIM_M32=y

Review comment:
       @yamt can we support 32bit on macOS? since OpenAMP just support 32bit address space now, rpproxy/rpserver stop work without CONFIG_SIM_M32.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org