[GitHub] jonpspri commented on a change in pull request #3100: add remote_redirect mode for openwhisk_cli installation

[GitBox <gi...@apache.org>]

jonpspri commented on a change in pull request #3100: add remote_redirect mode for openwhisk_cli installation
URL: https://github.com/apache/incubator-openwhisk/pull/3100#discussion_r158591328
 
 

 ##########
 File path: ansible/roles/nginx/templates/nginx.conf.j2
 ##########
 @@ -90,9 +90,25 @@ http {
             return 301 https://github.com/apache/incubator-openwhisk-client-swift/releases/download/0.2.3/starterapp-0.2.3.zip;
         }
 
+{% if openwhisk_cli.installation_mode == "remote_redirect" %}
+        # redirect requests for specific binaries to the matching one from the {{ openwhisk_cli_tag }} openwhisk-cli release.
+  {% for os in cli_os %}
+     {% for arch in cli_arch %}
 
 Review comment:
   This concerns me given changes I made in #3133 to introduce cli_os_arch.  It will be a simple update, depending on which goes first.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services