You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@whimsical.apache.org by GitBox <gi...@apache.org> on 2021/07/25 10:03:42 UTC

[GitHub] [whimsy] sebbASF commented on pull request #120: Family First support in secretary workbench

sebbASF commented on pull request #120:
URL: https://github.com/apache/whimsy/pull/120#issuecomment-886177003


   I think the name parsing should be done in lib/whimsy/asf/person.rb alongside ldap_name, using an API of the form:
   
   sn, givenname = def ldap_parsecn(cn, familyfirst)
   
   This would make it easier to test (and re-use)
   
   Also givenname can be omitted.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@whimsical.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org