You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-commits@xmlgraphics.apache.org by ss...@apache.org on 2022/02/14 09:07:28 UTC
svn commit: r1898051 - in /xmlgraphics/fop/trunk/fop-core/src/test/java/org/apache/fop: URIResolutionTestCase.java intermediate/TestAssistant.java
Author: ssteiner
Date: Mon Feb 14 09:07:28 2022
New Revision: 1898051
URL: http://svn.apache.org/viewvc?rev=1898051&view=rev
Log:
FOP-3053: Reduce use of xalan
Modified:
xmlgraphics/fop/trunk/fop-core/src/test/java/org/apache/fop/URIResolutionTestCase.java
xmlgraphics/fop/trunk/fop-core/src/test/java/org/apache/fop/intermediate/TestAssistant.java
Modified: xmlgraphics/fop/trunk/fop-core/src/test/java/org/apache/fop/URIResolutionTestCase.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/fop-core/src/test/java/org/apache/fop/URIResolutionTestCase.java?rev=1898051&r1=1898050&r2=1898051&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/fop-core/src/test/java/org/apache/fop/URIResolutionTestCase.java (original)
+++ xmlgraphics/fop/trunk/fop-core/src/test/java/org/apache/fop/URIResolutionTestCase.java Mon Feb 14 09:07:28 2022
@@ -36,6 +36,10 @@ import javax.xml.transform.sax.SAXTransf
import javax.xml.transform.sax.TransformerHandler;
import javax.xml.transform.stream.StreamResult;
import javax.xml.transform.stream.StreamSource;
+import javax.xml.xpath.XPath;
+import javax.xml.xpath.XPathConstants;
+import javax.xml.xpath.XPathExpressionException;
+import javax.xml.xpath.XPathFactory;
import org.junit.BeforeClass;
import org.junit.Test;
@@ -46,8 +50,6 @@ import static org.junit.Assert.assertTru
import org.apache.commons.io.IOUtils;
import org.apache.commons.io.output.ByteArrayOutputStream;
-import org.apache.xpath.XPathAPI;
-import org.apache.xpath.objects.XObject;
import org.apache.xmlgraphics.io.Resource;
import org.apache.xmlgraphics.io.ResourceResolver;
@@ -155,14 +157,9 @@ public class URIResolutionTestCase {
return doc;
}
- private String evalXPath(Document doc, String xpath) {
- XObject res;
- try {
- res = XPathAPI.eval(doc, xpath);
- } catch (TransformerException e) {
- throw new RuntimeException("XPath evaluation failed: " + e.getMessage());
- }
- return res.str();
+ private String evalXPath(Document doc, String xpath) throws XPathExpressionException {
+ XPath xPath = XPathFactory.newInstance().newXPath();
+ return (String) xPath.compile(xpath).evaluate(doc, XPathConstants.STRING);
}
/**
Modified: xmlgraphics/fop/trunk/fop-core/src/test/java/org/apache/fop/intermediate/TestAssistant.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/fop-core/src/test/java/org/apache/fop/intermediate/TestAssistant.java?rev=1898051&r1=1898050&r2=1898051&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/fop-core/src/test/java/org/apache/fop/intermediate/TestAssistant.java (original)
+++ xmlgraphics/fop/trunk/fop-core/src/test/java/org/apache/fop/intermediate/TestAssistant.java Mon Feb 14 09:07:28 2022
@@ -35,13 +35,14 @@ import javax.xml.transform.dom.DOMSource
import javax.xml.transform.sax.SAXTransformerFactory;
import javax.xml.transform.stream.StreamResult;
import javax.xml.transform.stream.StreamSource;
+import javax.xml.xpath.XPath;
+import javax.xml.xpath.XPathConstants;
+import javax.xml.xpath.XPathExpressionException;
+import javax.xml.xpath.XPathFactory;
import org.w3c.dom.Document;
import org.w3c.dom.Element;
-import org.apache.xpath.XPathAPI;
-import org.apache.xpath.objects.XObject;
-
import org.apache.fop.apps.EnvironmentProfile;
import org.apache.fop.apps.EnvironmentalProfileFactory;
import org.apache.fop.apps.FopFactory;
@@ -128,33 +129,36 @@ public class TestAssistant {
private boolean isBase14KerningEnabled(Document testDoc) {
try {
- XObject xo = XPathAPI.eval(testDoc, "/testcase/cfg/base14kerning");
- String s = xo.str();
+ String s = eval(testDoc, "/testcase/cfg/base14kerning");
return ("true".equalsIgnoreCase(s));
- } catch (TransformerException e) {
+ } catch (XPathExpressionException e) {
throw new RuntimeException("Error while evaluating XPath expression", e);
}
}
private boolean isStrictValidation(Document testDoc) {
try {
- XObject xo = XPathAPI.eval(testDoc, "/testcase/cfg/strict-validation");
- return !("false".equalsIgnoreCase(xo.str()));
- } catch (TransformerException e) {
+ String s = eval(testDoc, "/testcase/cfg/strict-validation");
+ return !("false".equalsIgnoreCase(s));
+ } catch (XPathExpressionException e) {
throw new RuntimeException("Error while evaluating XPath expression", e);
}
}
private boolean isTableBorderOverpaint(Document testDoc) {
try {
- XObject xo = XPathAPI.eval(testDoc, "/testcase/cfg/table-border-overpaint");
- String s = xo.str();
+ String s = eval(testDoc, "/testcase/cfg/table-border-overpaint");
return "true".equalsIgnoreCase(s);
- } catch (TransformerException e) {
+ } catch (XPathExpressionException e) {
throw new RuntimeException("Error while evaluating XPath expression", e);
}
}
+ private String eval(Document doc, String xpath) throws XPathExpressionException {
+ XPath xPath = XPathFactory.newInstance().newXPath();
+ return (String) xPath.compile(xpath).evaluate(doc, XPathConstants.STRING);
+ }
+
/**
* Loads a test case into a DOM document.
* @param testFile the test file
---------------------------------------------------------------------
To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org