You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Manikumar Reddy O <ma...@gmail.com> on 2014/11/29 11:20:53 UTC
Review Request 28536: Patch for KAFKA-1799
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28536/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1799
https://issues.apache.org/jira/browse/KAFKA-1799
Repository: kafka
Description
-------
Explicit string to class conversion done in gAbstractConfig.getConfiguredInstances()
Diffs
-----
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java 8d886105341555a548ecc7b2901e7fc5d6b1ee8c
Diff: https://reviews.apache.org/r/28536/diff/
Testing
-------
Thanks,
Manikumar Reddy O
Re: Review Request 28536: Patch for KAFKA-1799
Posted by Manikumar Reddy O <ma...@gmail.com>.
> On Nov. 29, 2014, 8:02 p.m., Jun Rao wrote:
> > clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java, line 153
> > <https://reviews.apache.org/r/28536/diff/1/?file=778386#file778386line153>
> >
> > We probably should throw a ConfigException instead.
Used ConfigException.
- Manikumar Reddy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28536/#review63295
-----------------------------------------------------------
On Nov. 30, 2014, 10:35 a.m., Manikumar Reddy O wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28536/
> -----------------------------------------------------------
>
> (Updated Nov. 30, 2014, 10:35 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1799
> https://issues.apache.org/jira/browse/KAFKA-1799
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Explicit string to class conversion done in gAbstractConfig.getConfiguredInstances(), Addrresing Jun's comments
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java 8d886105341555a548ecc7b2901e7fc5d6b1ee8c
> clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28536/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Manikumar Reddy O
>
>
Re: Review Request 28536: Patch for KAFKA-1799
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28536/#review63295
-----------------------------------------------------------
Thanks for the patch. Some comments below.
Also, could we add a unit test for getConfiguredInstances()?
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
<https://reviews.apache.org/r/28536/#comment105451>
Do we really need to special case this? If we don't handle this, we will get a ConfigException anyway.
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java
<https://reviews.apache.org/r/28536/#comment105450>
We probably should throw a ConfigException instead.
- Jun Rao
On Nov. 29, 2014, 10:20 a.m., Manikumar Reddy O wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28536/
> -----------------------------------------------------------
>
> (Updated Nov. 29, 2014, 10:20 a.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1799
> https://issues.apache.org/jira/browse/KAFKA-1799
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Explicit string to class conversion done in gAbstractConfig.getConfiguredInstances()
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java 8d886105341555a548ecc7b2901e7fc5d6b1ee8c
>
> Diff: https://reviews.apache.org/r/28536/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Manikumar Reddy O
>
>
Re: Review Request 28536: Patch for KAFKA-1799
Posted by Manikumar Reddy O <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28536/
-----------------------------------------------------------
(Updated Nov. 30, 2014, 10:35 a.m.)
Review request for kafka.
Bugs: KAFKA-1799
https://issues.apache.org/jira/browse/KAFKA-1799
Repository: kafka
Description (updated)
-------
Explicit string to class conversion done in gAbstractConfig.getConfiguredInstances(), Addrresing Jun's comments
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java 8d886105341555a548ecc7b2901e7fc5d6b1ee8c
clients/src/test/java/org/apache/kafka/common/config/AbstractConfigTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/28536/diff/
Testing
-------
Thanks,
Manikumar Reddy O
Re: Review Request 28536: Patch for KAFKA-1799
Posted by Manikumar Reddy O <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28536/
-----------------------------------------------------------
(Updated Nov. 30, 2014, 10:29 a.m.)
Review request for kafka.
Bugs: KAFKA-1799
https://issues.apache.org/jira/browse/KAFKA-1799
Repository: kafka
Description
-------
Explicit string to class conversion done in gAbstractConfig.getConfiguredInstances()
Diffs (updated)
-----
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java 8d886105341555a548ecc7b2901e7fc5d6b1ee8c
Diff: https://reviews.apache.org/r/28536/diff/
Testing
-------
Thanks,
Manikumar Reddy O