You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/15 05:07:06 UTC
[GitHub] [kafka] kamalcph opened a new pull request #10126: MINOR: Updated the Kafka JUnit extension document.
kamalcph opened a new pull request #10126:
URL: https://github.com/apache/kafka/pull/10126
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on a change in pull request #10126: MINOR: Fix wrong Import control declaration
Posted by GitBox <gi...@apache.org>.
kamalcph commented on a change in pull request #10126:
URL: https://github.com/apache/kafka/pull/10126#discussion_r623813083
##########
File path: checkstyle/import-control-core.xml
##########
@@ -65,7 +65,7 @@
<allow pkg="kafka.api"/>
<allow pkg="kafka.server"/>
<allow pkg="org.apache.kafka.clients.admin"/>
- <allow pkg="integration.kafka.server" class="IntegrationTestHelper"/>
Review comment:
Updated. Also, closed #10099.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #10126: MINOR: Updated the Kafka JUnit extension document.
Posted by GitBox <gi...@apache.org>.
kamalcph commented on pull request #10126:
URL: https://github.com/apache/kafka/pull/10126#issuecomment-778941743
@chia7712 @mumrah
Please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #10126: MINOR: Updated the Kafka JUnit extension document.
Posted by GitBox <gi...@apache.org>.
kamalcph commented on pull request #10126:
URL: https://github.com/apache/kafka/pull/10126#issuecomment-781048342
@mumrah @chia7712
Ping for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on pull request #10126: MINOR: Updated the Kafka JUnit extension document.
Posted by GitBox <gi...@apache.org>.
kamalcph commented on pull request #10126:
URL: https://github.com/apache/kafka/pull/10126#issuecomment-794188424
@mumrah ping for review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph commented on a change in pull request #10126: MINOR: Fix wrong Import control declaration
Posted by GitBox <gi...@apache.org>.
kamalcph commented on a change in pull request #10126:
URL: https://github.com/apache/kafka/pull/10126#discussion_r623813083
##########
File path: checkstyle/import-control-core.xml
##########
@@ -65,7 +65,7 @@
<allow pkg="kafka.api"/>
<allow pkg="kafka.server"/>
<allow pkg="org.apache.kafka.clients.admin"/>
- <allow pkg="integration.kafka.server" class="IntegrationTestHelper"/>
Review comment:
Updated. Also, closed #10099 as it's done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] kamalcph closed pull request #10126: MINOR: Fix wrong Import control declaration
Posted by GitBox <gi...@apache.org>.
kamalcph closed pull request #10126:
URL: https://github.com/apache/kafka/pull/10126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on a change in pull request #10126: MINOR: Updated the Kafka JUnit extension document.
Posted by GitBox <gi...@apache.org>.
dengziming commented on a change in pull request #10126:
URL: https://github.com/apache/kafka/pull/10126#discussion_r623650403
##########
File path: checkstyle/import-control-core.xml
##########
@@ -65,7 +65,7 @@
<allow pkg="kafka.api"/>
<allow pkg="kafka.server"/>
<allow pkg="org.apache.kafka.clients.admin"/>
- <allow pkg="integration.kafka.server" class="IntegrationTestHelper"/>
Review comment:
pkg has been changed to kafka.server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org