You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/02/01 20:15:15 UTC

[GitHub] [accumulo] brianloss commented on pull request #1891: Add TabletBalancer to SPI package

brianloss commented on pull request #1891:
URL: https://github.com/apache/accumulo/pull/1891#issuecomment-771128349


   > This is a big PR, I feel like I can only review it in chunks. Here's a few comments from stuff I noticed today.
   
   Yeah, and I even tried to keep it as small as I could. One thing to keep in mind that could help... The balancers and tests are all just copies of those in the org.apache.accumulo.server.master.balancer package, but updated with the new interface and types added to the SPI package. If you check this branch out, then you can diff each balancer new file with its deprecated equivalent.
   
   I figured any improvements to the balancers themselves could be addressed as we want with a follow-on issue/pull request.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org