[GitHub] rabbah commented on a change in pull request #1: Repo migration for openwhisk-runtime-dotnet

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #1: Repo migration for openwhisk-runtime-dotnet
URL: https://github.com/apache/incubator-openwhisk-runtime-dotnet/pull/1#discussion_r224562993
 
 

 ##########
 File path: tests/src/test/scala/actionContainers/DotNetActionContainerTests.scala
 ##########
 @@ -0,0 +1,227 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package actionContainers
+
+import org.junit.runner.RunWith
+import org.scalatest.junit.JUnitRunner
+import common.WskActorSystem
+import spray.json._
+import actionContainers.ActionContainer.withContainer
+import java.nio.file.Paths
+
+@RunWith(classOf[JUnitRunner])
+class DotNetActionContainerTests extends BasicActionRunnerTests with WskActorSystem {
+  val functionb64 = ResourceHelpers.readAsBase64(Paths.get(getClass.getResource("/dotnettests.zip").getPath))
+
+  // Helpers specific to java actions
+  override def withActionContainer(env: Map[String, String] = Map.empty)(
+    code: ActionContainer => Unit): (String, String) = withContainer("action-dotnet-v2.1", env)(code)
+
+  behavior of "dotnet action"
+
+  override val testNoSourceOrExec = {
+    TestConfig("")
+  }
+
+  override val testNotReturningJson = {
+    // skip this test since and add own below (see Nuller)
+    TestConfig("", skipTest = true)
+  }
+
+  override val testEnv = {
+    TestConfig(
+      functionb64,
+      main = "Apache.OpenWhisk.Tests.Dotnet::Apache.OpenWhisk.Tests.Dotnet.Environment::Main"
+    )
+  }
+
+  override val testEcho = {
+    TestConfig(
+      functionb64,
+      main = "Apache.OpenWhisk.Tests.Dotnet::Apache.OpenWhisk.Tests.Dotnet.AltEcho::Main"
+    )
+  }
+
+  val testEchoNoWrite = {
+    TestConfig(
+      functionb64,
+      main = "Apache.OpenWhisk.Tests.Dotnet::Apache.OpenWhisk.Tests.Dotnet.Echo::Main"
+    )
+  }
+
+  override val testUnicode = {
+    TestConfig(
+      functionb64,
+      main = "Apache.OpenWhisk.Tests.Dotnet::Apache.OpenWhisk.Tests.Dotnet.Unicode::Main"
+    )
+  }
+
+  override val testInitCannotBeCalledMoreThanOnce = testEchoNoWrite
+
+  override val testEntryPointOtherThanMain = testEchoNoWrite
+
+  override val testLargeInput = testEchoNoWrite
+
+  it should "fail to initialize with bad archive" in {
+    val (out, err) = withActionContainer() { c =>
+      val brokenArchive = ("NOTAVALIDZIPFILE")
+
+      val (initCode, initRes) = c.init(initPayload(brokenArchive, "Apache.OpenWhisk.Tests.Dotnet::Apache.OpenWhisk.Tests.Dotnet.Invalid::Main"))
+      initCode should not be (200)
+
+      initRes shouldBe defined
+
+      initRes should {
+          be(Some(JsObject("error" -> JsString("Unable to decompress package."))))
+      }
+    }
+  }
+
+  it should "return some error on action error" in {
+    val (out, err) = withActionContainer() { c =>
+      val (initCode, _) = c.init(initPayload(functionb64, "Apache.OpenWhisk.Tests.Dotnet::Apache.OpenWhisk.Tests.Dotnet.Exception::Main"))
+      initCode should be(200)
+
+      val (runCode, runRes) = c.run(runPayload(JsObject.empty))
+      runCode should not be (200)
+
+      runRes shouldBe defined
+      runRes.get.fields.get("error") shouldBe defined
+    }
+
+    checkStreams(out, err, {
+      case (o, e) =>
+        (o + e).toLowerCase should include("exception")
+    })
+  }
+
+  it should "support application errors" in {
+    val (out, err) = withActionContainer() { c =>
+      val (initCode, _) = c.init(initPayload(functionb64, "Apache.OpenWhisk.Tests.Dotnet::Apache.OpenWhisk.Tests.Dotnet.Error::Main"))
+      initCode should be(200)
+
+      val (runCode, runRes) = c.run(runPayload(JsObject.empty))
+      runCode should be(200)
+
+      runRes shouldBe defined
+      runRes.get.fields.get("error") shouldBe defined
+    }
+
+    checkStreams(out, err, {
+      case (o, e) =>
+        o shouldBe empty
+        e shouldBe empty
+    })
+  }
+
+  it should "fails on invalid assembly reference" in {
+    val (out, err) = withActionContainer() { c =>
+      val (initCode, initRes) = c.init(initPayload(functionb64, "Apache.OpenWhisk.Tests.Dotnet.DoesntExist::Apache.OpenWhisk.Tests.Dotnet.Echo::Main"))
+      initCode should be(502)
+
+      initRes shouldBe defined
 
 Review comment:
   redundant with next statement.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services