You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/03 22:47:19 UTC
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #9982: feat: implement secondary navigation for datasets
codecov-commenter edited a comment on pull request #9982:
URL: https://github.com/apache/incubator-superset/pull/9982#issuecomment-638500172
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=h1) Report
> Merging [#9982](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/dcac860f3e5528ecbc39e58f045c7388adb5c3d0&el=desc) will **decrease** coverage by `0.00%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9982 +/- ##
==========================================
- Coverage 71.38% 71.38% -0.01%
==========================================
Files 585 586 +1
Lines 30949 30987 +38
Branches 3261 3267 +6
==========================================
+ Hits 22094 22119 +25
- Misses 8746 8758 +12
- Partials 109 110 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.98% <ø> (-0.11%)` | :arrow_down: |
| #javascript | `59.43% <84.61%> (+0.04%)` | :arrow_up: |
| #python | `71.58% <ø> (+<0.01%)` | :arrow_up: |
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...set-frontend/src/views/datasetList/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2RhdGFzZXRMaXN0L0RhdGFzZXRMaXN0LnRzeA==) | `55.45% <77.77%> (+0.82%)` | :arrow_up: |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `88.23% <88.23%> (ø)` | |
| [...rontend/src/SqlLab/components/QueryAutoRefresh.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5QXV0b1JlZnJlc2guanN4) | `65.90% <0.00%> (-6.82%)` | :arrow_down: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `93.10% <0.00%> (-3.45%)` | :arrow_down: |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | `80.95% <0.00%> (-0.78%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `66.15% <0.00%> (-0.66%)` | :arrow_down: |
| [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `71.94% <0.00%> (-0.03%)` | :arrow_down: |
| [superset/typing.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHlwaW5nLnB5) | `100.00% <0.00%> (ø)` | |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.29% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| ... and [7 more](https://codecov.io/gh/apache/incubator-superset/pull/9982/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=footer). Last update [dcac860...dd933bc](https://codecov.io/gh/apache/incubator-superset/pull/9982?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org