You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacopo Cappellato <ti...@sastau.it> on 2007/12/21 06:31:55 UTC
Re: svn commit: r606031 - in /ofbiz/trunk/applications/accounting:
config/payment.properties src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
Premise: I don't know much about PayPalEvents.java and I didn't really
reviewed BJ Freeman's patch.
That said, I have a question: I've noticed that the change to the
PayPalEvents.java slightly modify the logic of the event... are we sure
that it is something we need? What is it supposed to fix/improve
exactly? I cannot understand this (due to my limited knowledge of PayPal
events) simply reading the comments in Jira and the svn log.
Thanks,
Jacopo
jleroux@apache.org wrote:
> Author: jleroux
> Date: Thu Dec 20 13:21:47 2007
> New Revision: 606031
>
> URL: http://svn.apache.org/viewvc?rev=606031&view=rev
> Log:
> Done by hand from an unusable patch of BJ Freeman "Authorize.NET Payment Gateway Implementation" (https://issues.apache.org/jira/browse/OFBIZ-274) - OFBIZ-274
>
> Modified:
> ofbiz/trunk/applications/accounting/config/payment.properties
> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>
> Modified: ofbiz/trunk/applications/accounting/config/payment.properties
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/payment.properties?rev=606031&r1=606030&r2=606031&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/accounting/config/payment.properties (original)
> +++ ofbiz/trunk/applications/accounting/config/payment.properties Thu Dec 20 13:21:47 2007
> @@ -240,33 +240,39 @@
>
> # PayPal E-Mail address
> #payment.paypal.business=vote@ofbiz.org
> -payment.paypal.business=vote@[yourServerName]
> +payment.paypal.business=
>
> # PayPal Notify URL
> -payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
> +#payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
> +payment.paypal.notify=
>
> # PayPal Return URL
> -payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
> +#payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
> +payment.paypal.return=
>
> # PayPal Return On Cancel URL
> -payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
> +#payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
> +payment.paypal.cancelReturn=
>
> # Image To Use On PayPal
> #payment.paypal.image=http://[yourServerName]/images/ofbiz_logo.jpg
> -payment.paypal.image=http://[yourServerName]/images/[your_logo].jpg
> +payment.paypal.image=
>
> # Thank-You / Confirm Order Template (rendered via Freemarker)
> -payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
> +#payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
> +payment.paypal.confirmTemplate=
>
> # Production PayPal Redirect URL
> #payment.paypal.redirect=https://www.paypal.com/cgi-bin/webscr
> # Sandbox PayPal Redirect URL
> -payment.paypal.redirect=https://www.sandbox.paypal.com/us/cgi-bin/webscr
> +#payment.paypal.redirect=https://www.sandbox.paypal.com/us/cgi-bin/webscr
> +payment.paypal.redirect=
>
> # Production PayPal Confirm URL (JSSE must be configured to use SSL)
> #payment.paypal.confirm=http://www.paypal.com/cgi-bin/webscr
> # Sandbox PayPal Confirm URL (JSSE must be configured to use SSL)
> -payment.paypal.confirm=https://www.sandbox.paypal.com/us/cgi-bin/webscr
> +#payment.paypal.confirm=https://www.sandbox.paypal.com/us/cgi-bin/webscr
> +payment.paypal.confirm=
>
> ############################################
> # PCCharge Configuration
>
> Modified: ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java?rev=606031&r1=606030&r2=606031&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java (original)
> +++ ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java Thu Dec 20 13:21:47 2007
> @@ -129,7 +129,12 @@
> // get the paypal account
> String payPalAccount = UtilProperties.getPropertyValue(configString, "payment.paypal.business");
>
> - if (UtilValidate.isEmpty(notifyUrl) || UtilValidate.isEmpty(returnUrl) || UtilValidate.isEmpty(cancelReturnUrl)) {
> + if (UtilValidate.isEmpty(redirectUrl)
> + || UtilValidate.isEmpty(notifyUrl)
> + || UtilValidate.isEmpty(returnUrl)
> + || UtilValidate.isEmpty(cancelReturnUrl)
> + || UtilValidate.isEmpty(imageUrl)
> + || UtilValidate.isEmpty(payPalAccount) ) {
> Debug.logError("Payment properties is not configured properly, some notify URL from PayPal is not correctly defined!", module);
> request.setAttribute("_ERROR_MESSAGE_", UtilProperties.getMessage(resource, "payPalEvents.problemsGettingMerchantConfiguration", locale));
> return "error";
>
Re: svn commit: r606031 - in /ofbiz/trunk/applications/accounting:
config/payment.properties src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
Posted by BJ Freeman <bj...@free-man.net>.
Egg on face.
:D
just shows I should not code at night.
Jacques Le Roux sent the following on 12/21/2007 5:58 AM:
> From: "BJ Freeman" <bj...@free-man.net>
>> please explain IIRC.
>> not sure were +129 is, I am guessing UtilValidate.isEmpty(payPalAccount)
>> UtilValidate.isEmpty(payPalAccount) is not in my patch.
>> Don't see payPalAccount in the properties file
>
> Trunk and release
> # PayPal E-Mail address
> #payment.paypal.business=vote@ofbiz.org
> payment.paypal.business=
>
> String payPalAccount = UtilProperties.getPropertyValue(configString,
> "payment.paypal.business");
>
> Jacques
>
>> this is minor
>>>>>> #payment.paypal.business=vote@ofbiz.org
>>>>>> -payment.paypal.business=vote@[yourServerName]
>> should be
>>>>>> -#payment.paypal.business=vote@ofbiz.org
>>>>>> +#payment.paypal.business=[your emailaddress at paypal like
>> vote@ofbiz.org]
>>
>> so letme go thru my patch and see if I can make it work for you.
>> you can revert what is done.
>> :)
>>
>> Jacques Le Roux sent the following on 12/21/2007 2:09 AM:
>>> From: "BJ Freeman" <bj...@free-man.net>
>>> [...]
>>>> This is not only for paypal but any property (method) that send data
>>>> erroneously to somewhere and not make the user aware it is happening
>>>
>>> Yes, but IIRC there are currently only code for dealing with paypal. See
>>> UtilValidate.isEmpty at the end of this message
>>> (PayPalEvents.java[129+...]
>>>
>>> Jacques
>>>
>>>> Jacopo Cappellato sent the following on 12/20/2007 9:31 PM:
>>>>> Premise: I don't know much about PayPalEvents.java and I didn't really
>>>>> reviewed BJ Freeman's patch.
>>>>>
>>>>> That said, I have a question: I've noticed that the change to the
>>>>> PayPalEvents.java slightly modify the logic of the event... are we
>>>>> sure
>>>>> that it is something we need? What is it supposed to fix/improve
>>>>> exactly? I cannot understand this (due to my limited knowledge of
>>>>> PayPal
>>>>> events) simply reading the comments in Jira and the svn log.
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Jacopo
>>>>>
>>>>>
>>>>> jleroux@apache.org wrote:
>>>>>> Author: jleroux
>>>>>> Date: Thu Dec 20 13:21:47 2007
>>>>>> New Revision: 606031
>>>>>>
>>>>>> URL: http://svn.apache.org/viewvc?rev=606031&view=rev
>>>>>> Log:
>>>>>> Done by hand from an unusable patch of BJ Freeman "Authorize.NET
>>>>>> Payment Gateway Implementation"
>>>>>> (https://issues.apache.org/jira/browse/OFBIZ-274) - OFBIZ-274
>>>>>>
>>>>>> Modified:
>>>>>> ofbiz/trunk/applications/accounting/config/payment.properties
>>>>>>
>>>>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> Modified:
>>>>>> ofbiz/trunk/applications/accounting/config/payment.properties
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/payment.properties?rev=606031&r1=606030&r2=606031&view=diff
>>>>>>
>>>>>>
>>>>>>
>>>>>> ==============================================================================
>>>>>>
>>>>>>
>>>>>>
>>>>>> --- ofbiz/trunk/applications/accounting/config/payment.properties
>>>>>> (original)
>>>>>> +++ ofbiz/trunk/applications/accounting/config/payment.properties Thu
>>>>>> Dec 20 13:21:47 2007
>>>>>> @@ -240,33 +240,39 @@
>>>>>>
>>>>>> # PayPal E-Mail address
>>>>>> #payment.paypal.business=vote@ofbiz.org
>>>>>> -payment.paypal.business=vote@[yourServerName]
>>>>>> +payment.paypal.business=
>>>>>>
>>>>>> # PayPal Notify URL
>>>>>> -payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
>>>>>>
>>>>>>
>>>>>>
>>>>>> +#payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
>>>>>>
>>>>>>
>>>>>>
>>>>>> +payment.paypal.notify=
>>>>>>
>>>>>> # PayPal Return URL
>>>>>> -payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
>>>>>>
>>>>>>
>>>>>>
>>>>>> +#payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
>>>>>>
>>>>>>
>>>>>>
>>>>>> +payment.paypal.return=
>>>>>>
>>>>>> # PayPal Return On Cancel URL
>>>>>> -payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
>>>>>>
>>>>>>
>>>>>>
>>>>>> +#payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
>>>>>>
>>>>>>
>>>>>>
>>>>>> +payment.paypal.cancelReturn=
>>>>>>
>>>>>> # Image To Use On PayPal
>>>>>> #payment.paypal.image=http://[yourServerName]/images/ofbiz_logo.jpg
>>>>>> -payment.paypal.image=http://[yourServerName]/images/[your_logo].jpg
>>>>>> +payment.paypal.image=
>>>>>>
>>>>>> # Thank-You / Confirm Order Template (rendered via Freemarker)
>>>>>> -payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
>>>>>> +#payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
>>>>>> +payment.paypal.confirmTemplate=
>>>>>>
>>>>>> # Production PayPal Redirect URL
>>>>>> #payment.paypal.redirect=https://www.paypal.com/cgi-bin/webscr
>>>>>> # Sandbox PayPal Redirect URL
>>>>>> -payment.paypal.redirect=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>>>>>
>>>>>>
>>>>>> +#payment.paypal.redirect=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>>>>>
>>>>>>
>>>>>>
>>>>>> +payment.paypal.redirect=
>>>>>>
>>>>>> # Production PayPal Confirm URL (JSSE must be configured to use SSL)
>>>>>> #payment.paypal.confirm=http://www.paypal.com/cgi-bin/webscr
>>>>>> # Sandbox PayPal Confirm URL (JSSE must be configured to use SSL)
>>>>>> -payment.paypal.confirm=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>>>>>
>>>>>>
>>>>>> +#payment.paypal.confirm=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>>>>>
>>>>>>
>>>>>> +payment.paypal.confirm=
>>>>>>
>>>>>> ############################################
>>>>>> # PCCharge Configuration
>>>>>>
>>>>>> Modified:
>>>>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>>>>>
>>>>>>
>>>>>>
>>>>>> URL:
>>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java?rev=606031&r1=606030&r2=606031&view=diff
>>>>>>
>>>>>>
>>>>>>
>>>>>> ==============================================================================
>>>>>>
>>>>>>
>>>>>>
>>>>>> ---
>>>>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>>>>>
>>>>>>
>>>>>> (original)
>>>>>> +++
>>>>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>>>>>
>>>>>>
>>>>>> Thu Dec 20 13:21:47 2007
>>>>>> @@ -129,7 +129,12 @@
>>>>>> // get the paypal account
>>>>>> String payPalAccount =
>>>>>> UtilProperties.getPropertyValue(configString,
>>>>>> "payment.paypal.business");
>>>>>> - if (UtilValidate.isEmpty(notifyUrl) ||
>>>>>> UtilValidate.isEmpty(returnUrl) ||
>>>>>> UtilValidate.isEmpty(cancelReturnUrl)) {
>>>>>> + if (UtilValidate.isEmpty(redirectUrl) + ||
>>>>>> UtilValidate.isEmpty(notifyUrl) + ||
>>>>>> UtilValidate.isEmpty(returnUrl) + ||
>>>>>> UtilValidate.isEmpty(cancelReturnUrl) + ||
>>>>>> UtilValidate.isEmpty(imageUrl)
>>>>>> + || UtilValidate.isEmpty(payPalAccount) ) {
>>>>>> Debug.logError("Payment properties is not configured
>>>>>> properly, some notify URL from PayPal is not correctly defined!",
>>>>>> module);
>>>>>> request.setAttribute("_ERROR_MESSAGE_",
>>>>>> UtilProperties.getMessage(resource,
>>>>>> "payPalEvents.problemsGettingMerchantConfiguration", locale));
>>>>>> return "error";
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>
>>>
>>>
>>>
>>
>>
>
>
>
>
Re: svn commit: r606031 - in /ofbiz/trunk/applications/accounting: config/payment.properties src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
From: "BJ Freeman" <bj...@free-man.net>
> please explain IIRC.
> not sure were +129 is, I am guessing UtilValidate.isEmpty(payPalAccount)
> UtilValidate.isEmpty(payPalAccount) is not in my patch.
> Don't see payPalAccount in the properties file
Trunk and release
# PayPal E-Mail address
#payment.paypal.business=vote@ofbiz.org
payment.paypal.business=
String payPalAccount = UtilProperties.getPropertyValue(configString, "payment.paypal.business");
Jacques
> this is minor
>>>>> #payment.paypal.business=vote@ofbiz.org
>>>>> -payment.paypal.business=vote@[yourServerName]
> should be
>>>>> -#payment.paypal.business=vote@ofbiz.org
>>>>> +#payment.paypal.business=[your emailaddress at paypal like
> vote@ofbiz.org]
>
> so letme go thru my patch and see if I can make it work for you.
> you can revert what is done.
> :)
>
> Jacques Le Roux sent the following on 12/21/2007 2:09 AM:
>> From: "BJ Freeman" <bj...@free-man.net>
>> [...]
>>> This is not only for paypal but any property (method) that send data
>>> erroneously to somewhere and not make the user aware it is happening
>>
>> Yes, but IIRC there are currently only code for dealing with paypal. See
>> UtilValidate.isEmpty at the end of this message
>> (PayPalEvents.java[129+...]
>>
>> Jacques
>>
>>> Jacopo Cappellato sent the following on 12/20/2007 9:31 PM:
>>>> Premise: I don't know much about PayPalEvents.java and I didn't really
>>>> reviewed BJ Freeman's patch.
>>>>
>>>> That said, I have a question: I've noticed that the change to the
>>>> PayPalEvents.java slightly modify the logic of the event... are we sure
>>>> that it is something we need? What is it supposed to fix/improve
>>>> exactly? I cannot understand this (due to my limited knowledge of PayPal
>>>> events) simply reading the comments in Jira and the svn log.
>>>>
>>>> Thanks,
>>>>
>>>> Jacopo
>>>>
>>>>
>>>> jleroux@apache.org wrote:
>>>>> Author: jleroux
>>>>> Date: Thu Dec 20 13:21:47 2007
>>>>> New Revision: 606031
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=606031&view=rev
>>>>> Log:
>>>>> Done by hand from an unusable patch of BJ Freeman "Authorize.NET
>>>>> Payment Gateway Implementation"
>>>>> (https://issues.apache.org/jira/browse/OFBIZ-274) - OFBIZ-274
>>>>>
>>>>> Modified:
>>>>> ofbiz/trunk/applications/accounting/config/payment.properties
>>>>>
>>>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>>>>
>>>>>
>>>>>
>>>>> Modified: ofbiz/trunk/applications/accounting/config/payment.properties
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/payment.properties?rev=606031&r1=606030&r2=606031&view=diff
>>>>>
>>>>>
>>>>> ==============================================================================
>>>>>
>>>>>
>>>>> --- ofbiz/trunk/applications/accounting/config/payment.properties
>>>>> (original)
>>>>> +++ ofbiz/trunk/applications/accounting/config/payment.properties Thu
>>>>> Dec 20 13:21:47 2007
>>>>> @@ -240,33 +240,39 @@
>>>>>
>>>>> # PayPal E-Mail address
>>>>> #payment.paypal.business=vote@ofbiz.org
>>>>> -payment.paypal.business=vote@[yourServerName]
>>>>> +payment.paypal.business=
>>>>>
>>>>> # PayPal Notify URL
>>>>> -payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
>>>>>
>>>>>
>>>>> +#payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
>>>>>
>>>>>
>>>>> +payment.paypal.notify=
>>>>>
>>>>> # PayPal Return URL
>>>>> -payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
>>>>>
>>>>>
>>>>> +#payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
>>>>>
>>>>>
>>>>> +payment.paypal.return=
>>>>>
>>>>> # PayPal Return On Cancel URL
>>>>> -payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
>>>>>
>>>>>
>>>>> +#payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
>>>>>
>>>>>
>>>>> +payment.paypal.cancelReturn=
>>>>>
>>>>> # Image To Use On PayPal
>>>>> #payment.paypal.image=http://[yourServerName]/images/ofbiz_logo.jpg
>>>>> -payment.paypal.image=http://[yourServerName]/images/[your_logo].jpg
>>>>> +payment.paypal.image=
>>>>>
>>>>> # Thank-You / Confirm Order Template (rendered via Freemarker)
>>>>> -payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
>>>>> +#payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
>>>>> +payment.paypal.confirmTemplate=
>>>>>
>>>>> # Production PayPal Redirect URL
>>>>> #payment.paypal.redirect=https://www.paypal.com/cgi-bin/webscr
>>>>> # Sandbox PayPal Redirect URL
>>>>> -payment.paypal.redirect=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>>>>
>>>>> +#payment.paypal.redirect=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>>>>
>>>>>
>>>>> +payment.paypal.redirect=
>>>>>
>>>>> # Production PayPal Confirm URL (JSSE must be configured to use SSL)
>>>>> #payment.paypal.confirm=http://www.paypal.com/cgi-bin/webscr
>>>>> # Sandbox PayPal Confirm URL (JSSE must be configured to use SSL)
>>>>> -payment.paypal.confirm=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>>>>
>>>>> +#payment.paypal.confirm=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>>>>
>>>>> +payment.paypal.confirm=
>>>>>
>>>>> ############################################
>>>>> # PCCharge Configuration
>>>>>
>>>>> Modified:
>>>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>>>>
>>>>>
>>>>> URL:
>>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java?rev=606031&r1=606030&r2=606031&view=diff
>>>>>
>>>>>
>>>>> ==============================================================================
>>>>>
>>>>>
>>>>> ---
>>>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>>>>
>>>>> (original)
>>>>> +++
>>>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>>>>
>>>>> Thu Dec 20 13:21:47 2007
>>>>> @@ -129,7 +129,12 @@
>>>>> // get the paypal account
>>>>> String payPalAccount =
>>>>> UtilProperties.getPropertyValue(configString,
>>>>> "payment.paypal.business");
>>>>> - if (UtilValidate.isEmpty(notifyUrl) ||
>>>>> UtilValidate.isEmpty(returnUrl) ||
>>>>> UtilValidate.isEmpty(cancelReturnUrl)) {
>>>>> + if (UtilValidate.isEmpty(redirectUrl) + ||
>>>>> UtilValidate.isEmpty(notifyUrl) + ||
>>>>> UtilValidate.isEmpty(returnUrl) + ||
>>>>> UtilValidate.isEmpty(cancelReturnUrl) + ||
>>>>> UtilValidate.isEmpty(imageUrl)
>>>>> + || UtilValidate.isEmpty(payPalAccount) ) {
>>>>> Debug.logError("Payment properties is not configured
>>>>> properly, some notify URL from PayPal is not correctly defined!",
>>>>> module);
>>>>> request.setAttribute("_ERROR_MESSAGE_",
>>>>> UtilProperties.getMessage(resource,
>>>>> "payPalEvents.problemsGettingMerchantConfiguration", locale));
>>>>> return "error";
>>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>
>>
>>
>>
>
>
Re: svn commit: r606031 - in /ofbiz/trunk/applications/accounting:
config/payment.properties src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
Posted by BJ Freeman <bj...@free-man.net>.
please explain IIRC.
not sure were +129 is, I am guessing UtilValidate.isEmpty(payPalAccount)
UtilValidate.isEmpty(payPalAccount) is not in my patch.
Don't see payPalAccount in the properties file
this is minor
>>>> #payment.paypal.business=vote@ofbiz.org
>>>> -payment.paypal.business=vote@[yourServerName]
should be
>>>> -#payment.paypal.business=vote@ofbiz.org
>>>> +#payment.paypal.business=[your emailaddress at paypal like
vote@ofbiz.org]
so letme go thru my patch and see if I can make it work for you.
you can revert what is done.
:)
Jacques Le Roux sent the following on 12/21/2007 2:09 AM:
> From: "BJ Freeman" <bj...@free-man.net>
> [...]
>> This is not only for paypal but any property (method) that send data
>> erroneously to somewhere and not make the user aware it is happening
>
> Yes, but IIRC there are currently only code for dealing with paypal. See
> UtilValidate.isEmpty at the end of this message
> (PayPalEvents.java[129+...]
>
> Jacques
>
>> Jacopo Cappellato sent the following on 12/20/2007 9:31 PM:
>>> Premise: I don't know much about PayPalEvents.java and I didn't really
>>> reviewed BJ Freeman's patch.
>>>
>>> That said, I have a question: I've noticed that the change to the
>>> PayPalEvents.java slightly modify the logic of the event... are we sure
>>> that it is something we need? What is it supposed to fix/improve
>>> exactly? I cannot understand this (due to my limited knowledge of PayPal
>>> events) simply reading the comments in Jira and the svn log.
>>>
>>> Thanks,
>>>
>>> Jacopo
>>>
>>>
>>> jleroux@apache.org wrote:
>>>> Author: jleroux
>>>> Date: Thu Dec 20 13:21:47 2007
>>>> New Revision: 606031
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=606031&view=rev
>>>> Log:
>>>> Done by hand from an unusable patch of BJ Freeman "Authorize.NET
>>>> Payment Gateway Implementation"
>>>> (https://issues.apache.org/jira/browse/OFBIZ-274) - OFBIZ-274
>>>>
>>>> Modified:
>>>> ofbiz/trunk/applications/accounting/config/payment.properties
>>>>
>>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>>>
>>>>
>>>>
>>>> Modified: ofbiz/trunk/applications/accounting/config/payment.properties
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/payment.properties?rev=606031&r1=606030&r2=606031&view=diff
>>>>
>>>>
>>>> ==============================================================================
>>>>
>>>>
>>>> --- ofbiz/trunk/applications/accounting/config/payment.properties
>>>> (original)
>>>> +++ ofbiz/trunk/applications/accounting/config/payment.properties Thu
>>>> Dec 20 13:21:47 2007
>>>> @@ -240,33 +240,39 @@
>>>>
>>>> # PayPal E-Mail address
>>>> #payment.paypal.business=vote@ofbiz.org
>>>> -payment.paypal.business=vote@[yourServerName]
>>>> +payment.paypal.business=
>>>>
>>>> # PayPal Notify URL
>>>> -payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
>>>>
>>>>
>>>> +#payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
>>>>
>>>>
>>>> +payment.paypal.notify=
>>>>
>>>> # PayPal Return URL
>>>> -payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
>>>>
>>>>
>>>> +#payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
>>>>
>>>>
>>>> +payment.paypal.return=
>>>>
>>>> # PayPal Return On Cancel URL
>>>> -payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
>>>>
>>>>
>>>> +#payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
>>>>
>>>>
>>>> +payment.paypal.cancelReturn=
>>>>
>>>> # Image To Use On PayPal
>>>> #payment.paypal.image=http://[yourServerName]/images/ofbiz_logo.jpg
>>>> -payment.paypal.image=http://[yourServerName]/images/[your_logo].jpg
>>>> +payment.paypal.image=
>>>>
>>>> # Thank-You / Confirm Order Template (rendered via Freemarker)
>>>> -payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
>>>> +#payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
>>>> +payment.paypal.confirmTemplate=
>>>>
>>>> # Production PayPal Redirect URL
>>>> #payment.paypal.redirect=https://www.paypal.com/cgi-bin/webscr
>>>> # Sandbox PayPal Redirect URL
>>>> -payment.paypal.redirect=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>>>
>>>> +#payment.paypal.redirect=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>>>
>>>>
>>>> +payment.paypal.redirect=
>>>>
>>>> # Production PayPal Confirm URL (JSSE must be configured to use SSL)
>>>> #payment.paypal.confirm=http://www.paypal.com/cgi-bin/webscr
>>>> # Sandbox PayPal Confirm URL (JSSE must be configured to use SSL)
>>>> -payment.paypal.confirm=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>>>
>>>> +#payment.paypal.confirm=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>>>
>>>> +payment.paypal.confirm=
>>>>
>>>> ############################################
>>>> # PCCharge Configuration
>>>>
>>>> Modified:
>>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>>>
>>>>
>>>> URL:
>>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java?rev=606031&r1=606030&r2=606031&view=diff
>>>>
>>>>
>>>> ==============================================================================
>>>>
>>>>
>>>> ---
>>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>>>
>>>> (original)
>>>> +++
>>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>>>
>>>> Thu Dec 20 13:21:47 2007
>>>> @@ -129,7 +129,12 @@
>>>> // get the paypal account
>>>> String payPalAccount =
>>>> UtilProperties.getPropertyValue(configString,
>>>> "payment.paypal.business");
>>>> - if (UtilValidate.isEmpty(notifyUrl) ||
>>>> UtilValidate.isEmpty(returnUrl) ||
>>>> UtilValidate.isEmpty(cancelReturnUrl)) {
>>>> + if (UtilValidate.isEmpty(redirectUrl) + ||
>>>> UtilValidate.isEmpty(notifyUrl) + ||
>>>> UtilValidate.isEmpty(returnUrl) + ||
>>>> UtilValidate.isEmpty(cancelReturnUrl) + ||
>>>> UtilValidate.isEmpty(imageUrl)
>>>> + || UtilValidate.isEmpty(payPalAccount) ) {
>>>> Debug.logError("Payment properties is not configured
>>>> properly, some notify URL from PayPal is not correctly defined!",
>>>> module);
>>>> request.setAttribute("_ERROR_MESSAGE_",
>>>> UtilProperties.getMessage(resource,
>>>> "payPalEvents.problemsGettingMerchantConfiguration", locale));
>>>> return "error";
>>>>
>>>
>>>
>>>
>>>
>>
>>
>
>
>
>
Re: svn commit: r606031 - in /ofbiz/trunk/applications/accounting: config/payment.properties src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
Posted by Jacques Le Roux <ja...@les7arts.com>.
From: "BJ Freeman" <bj...@free-man.net>
[...]
> This is not only for paypal but any property (method) that send data
> erroneously to somewhere and not make the user aware it is happening
Yes, but IIRC there are currently only code for dealing with paypal. See UtilValidate.isEmpty at the end of this message
(PayPalEvents.java[129+...]
Jacques
> Jacopo Cappellato sent the following on 12/20/2007 9:31 PM:
>> Premise: I don't know much about PayPalEvents.java and I didn't really
>> reviewed BJ Freeman's patch.
>>
>> That said, I have a question: I've noticed that the change to the
>> PayPalEvents.java slightly modify the logic of the event... are we sure
>> that it is something we need? What is it supposed to fix/improve
>> exactly? I cannot understand this (due to my limited knowledge of PayPal
>> events) simply reading the comments in Jira and the svn log.
>>
>> Thanks,
>>
>> Jacopo
>>
>>
>> jleroux@apache.org wrote:
>>> Author: jleroux
>>> Date: Thu Dec 20 13:21:47 2007
>>> New Revision: 606031
>>>
>>> URL: http://svn.apache.org/viewvc?rev=606031&view=rev
>>> Log:
>>> Done by hand from an unusable patch of BJ Freeman "Authorize.NET
>>> Payment Gateway Implementation"
>>> (https://issues.apache.org/jira/browse/OFBIZ-274) - OFBIZ-274
>>>
>>> Modified:
>>> ofbiz/trunk/applications/accounting/config/payment.properties
>>>
>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>>
>>>
>>> Modified: ofbiz/trunk/applications/accounting/config/payment.properties
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/payment.properties?rev=606031&r1=606030&r2=606031&view=diff
>>>
>>> ==============================================================================
>>>
>>> --- ofbiz/trunk/applications/accounting/config/payment.properties
>>> (original)
>>> +++ ofbiz/trunk/applications/accounting/config/payment.properties Thu
>>> Dec 20 13:21:47 2007
>>> @@ -240,33 +240,39 @@
>>>
>>> # PayPal E-Mail address
>>> #payment.paypal.business=vote@ofbiz.org
>>> -payment.paypal.business=vote@[yourServerName]
>>> +payment.paypal.business=
>>>
>>> # PayPal Notify URL
>>> -payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
>>>
>>> +#payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
>>>
>>> +payment.paypal.notify=
>>>
>>> # PayPal Return URL
>>> -payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
>>>
>>> +#payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
>>>
>>> +payment.paypal.return=
>>>
>>> # PayPal Return On Cancel URL
>>> -payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
>>>
>>> +#payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
>>>
>>> +payment.paypal.cancelReturn=
>>>
>>> # Image To Use On PayPal
>>> #payment.paypal.image=http://[yourServerName]/images/ofbiz_logo.jpg
>>> -payment.paypal.image=http://[yourServerName]/images/[your_logo].jpg
>>> +payment.paypal.image=
>>>
>>> # Thank-You / Confirm Order Template (rendered via Freemarker)
>>> -payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
>>> +#payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
>>> +payment.paypal.confirmTemplate=
>>>
>>> # Production PayPal Redirect URL
>>> #payment.paypal.redirect=https://www.paypal.com/cgi-bin/webscr
>>> # Sandbox PayPal Redirect URL
>>> -payment.paypal.redirect=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>> +#payment.paypal.redirect=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>>
>>> +payment.paypal.redirect=
>>>
>>> # Production PayPal Confirm URL (JSSE must be configured to use SSL)
>>> #payment.paypal.confirm=http://www.paypal.com/cgi-bin/webscr
>>> # Sandbox PayPal Confirm URL (JSSE must be configured to use SSL)
>>> -payment.paypal.confirm=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>> +#payment.paypal.confirm=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>> +payment.paypal.confirm=
>>>
>>> ############################################
>>> # PCCharge Configuration
>>>
>>> Modified:
>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>>
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java?rev=606031&r1=606030&r2=606031&view=diff
>>>
>>> ==============================================================================
>>>
>>> ---
>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>> (original)
>>> +++
>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>> Thu Dec 20 13:21:47 2007
>>> @@ -129,7 +129,12 @@
>>> // get the paypal account
>>> String payPalAccount =
>>> UtilProperties.getPropertyValue(configString, "payment.paypal.business");
>>> - if (UtilValidate.isEmpty(notifyUrl) ||
>>> UtilValidate.isEmpty(returnUrl) ||
>>> UtilValidate.isEmpty(cancelReturnUrl)) {
>>> + if (UtilValidate.isEmpty(redirectUrl) + ||
>>> UtilValidate.isEmpty(notifyUrl) + ||
>>> UtilValidate.isEmpty(returnUrl) + ||
>>> UtilValidate.isEmpty(cancelReturnUrl) + ||
>>> UtilValidate.isEmpty(imageUrl)
>>> + || UtilValidate.isEmpty(payPalAccount) ) {
>>> Debug.logError("Payment properties is not configured
>>> properly, some notify URL from PayPal is not correctly defined!",
>>> module);
>>> request.setAttribute("_ERROR_MESSAGE_",
>>> UtilProperties.getMessage(resource,
>>> "payPalEvents.problemsGettingMerchantConfiguration", locale));
>>> return "error";
>>>
>>
>>
>>
>>
>
>
Re: svn commit: r606031 - in /ofbiz/trunk/applications/accounting:
config/payment.properties src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
Posted by BJ Freeman <bj...@free-man.net>.
callPayPal()
is an entry point
determined by
checkExternalPayment service.
in the checkExternalPayment request map of ecommerce controller.
possibly make the retun "configerror" and add it to the controller.
so you have it got to the error.jsp
be glad to provide patch.
BJ Freeman sent the following on 12/20/2007 10:33 PM:
> it started with a commit
> see svn commit: r604632 -
> and comments
> then another commit after some discussion
> finally did a patch that covered the discussion.
>
> This being that if there are properties that need to be configured
> before using, that they should not have dummy data in them but have no
> data. And so the configuration data is not lost or hard to find to put
> in a comment as to the configuration.
>
> I was decided that a Null property string would be check for and a log
> entry made that warn the user it that things needed to be configured.
> once the configuration is complete, the logic should not be effected.
>
> This is not only for paypal but any property (method) that send data
> erroneously to somewhere and not make the user aware it is happening
>
> Jacopo Cappellato sent the following on 12/20/2007 9:31 PM:
>> Premise: I don't know much about PayPalEvents.java and I didn't really
>> reviewed BJ Freeman's patch.
>>
>> That said, I have a question: I've noticed that the change to the
>> PayPalEvents.java slightly modify the logic of the event... are we sure
>> that it is something we need? What is it supposed to fix/improve
>> exactly? I cannot understand this (due to my limited knowledge of PayPal
>> events) simply reading the comments in Jira and the svn log.
>>
>> Thanks,
>>
>> Jacopo
>>
>>
>> jleroux@apache.org wrote:
>>> Author: jleroux
>>> Date: Thu Dec 20 13:21:47 2007
>>> New Revision: 606031
>>>
>>> URL: http://svn.apache.org/viewvc?rev=606031&view=rev
>>> Log:
>>> Done by hand from an unusable patch of BJ Freeman "Authorize.NET
>>> Payment Gateway Implementation"
>>> (https://issues.apache.org/jira/browse/OFBIZ-274) - OFBIZ-274
>>>
>>> Modified:
>>> ofbiz/trunk/applications/accounting/config/payment.properties
>>>
>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>>
>>>
>>> Modified: ofbiz/trunk/applications/accounting/config/payment.properties
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/payment.properties?rev=606031&r1=606030&r2=606031&view=diff
>>>
>>> ==============================================================================
>>>
>>> --- ofbiz/trunk/applications/accounting/config/payment.properties
>>> (original)
>>> +++ ofbiz/trunk/applications/accounting/config/payment.properties Thu
>>> Dec 20 13:21:47 2007
>>> @@ -240,33 +240,39 @@
>>>
>>> # PayPal E-Mail address
>>> #payment.paypal.business=vote@ofbiz.org
>>> -payment.paypal.business=vote@[yourServerName]
>>> +payment.paypal.business=
>>>
>>> # PayPal Notify URL
>>> -payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
>>>
>>> +#payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
>>>
>>> +payment.paypal.notify=
>>>
>>> # PayPal Return URL
>>> -payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
>>>
>>> +#payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
>>>
>>> +payment.paypal.return=
>>>
>>> # PayPal Return On Cancel URL
>>> -payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
>>>
>>> +#payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
>>>
>>> +payment.paypal.cancelReturn=
>>>
>>> # Image To Use On PayPal
>>> #payment.paypal.image=http://[yourServerName]/images/ofbiz_logo.jpg
>>> -payment.paypal.image=http://[yourServerName]/images/[your_logo].jpg
>>> +payment.paypal.image=
>>>
>>> # Thank-You / Confirm Order Template (rendered via Freemarker)
>>> -payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
>>> +#payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
>>> +payment.paypal.confirmTemplate=
>>>
>>> # Production PayPal Redirect URL
>>> #payment.paypal.redirect=https://www.paypal.com/cgi-bin/webscr
>>> # Sandbox PayPal Redirect URL
>>> -payment.paypal.redirect=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>> +#payment.paypal.redirect=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>>
>>> +payment.paypal.redirect=
>>>
>>> # Production PayPal Confirm URL (JSSE must be configured to use SSL)
>>> #payment.paypal.confirm=http://www.paypal.com/cgi-bin/webscr
>>> # Sandbox PayPal Confirm URL (JSSE must be configured to use SSL)
>>> -payment.paypal.confirm=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>> +#payment.paypal.confirm=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>> +payment.paypal.confirm=
>>>
>>> ############################################
>>> # PCCharge Configuration
>>>
>>> Modified:
>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>>
>>> URL:
>>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java?rev=606031&r1=606030&r2=606031&view=diff
>>>
>>> ==============================================================================
>>>
>>> ---
>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>> (original)
>>> +++
>>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>> Thu Dec 20 13:21:47 2007
>>> @@ -129,7 +129,12 @@
>>> // get the paypal account
>>> String payPalAccount =
>>> UtilProperties.getPropertyValue(configString, "payment.paypal.business");
>>> - if (UtilValidate.isEmpty(notifyUrl) ||
>>> UtilValidate.isEmpty(returnUrl) ||
>>> UtilValidate.isEmpty(cancelReturnUrl)) {
>>> + if (UtilValidate.isEmpty(redirectUrl) + ||
>>> UtilValidate.isEmpty(notifyUrl) + ||
>>> UtilValidate.isEmpty(returnUrl) + ||
>>> UtilValidate.isEmpty(cancelReturnUrl) + ||
>>> UtilValidate.isEmpty(imageUrl)
>>> + || UtilValidate.isEmpty(payPalAccount) ) {
>>> Debug.logError("Payment properties is not configured
>>> properly, some notify URL from PayPal is not correctly defined!",
>>> module);
>>> request.setAttribute("_ERROR_MESSAGE_",
>>> UtilProperties.getMessage(resource,
>>> "payPalEvents.problemsGettingMerchantConfiguration", locale));
>>> return "error";
>>>
>>
>>
>>
>
>
>
>
Re: svn commit: r606031 - in /ofbiz/trunk/applications/accounting:
config/payment.properties src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
Posted by BJ Freeman <bj...@free-man.net>.
it started with a commit
see svn commit: r604632 -
and comments
then another commit after some discussion
finally did a patch that covered the discussion.
This being that if there are properties that need to be configured
before using, that they should not have dummy data in them but have no
data. And so the configuration data is not lost or hard to find to put
in a comment as to the configuration.
I was decided that a Null property string would be check for and a log
entry made that warn the user it that things needed to be configured.
once the configuration is complete, the logic should not be effected.
This is not only for paypal but any property (method) that send data
erroneously to somewhere and not make the user aware it is happening
Jacopo Cappellato sent the following on 12/20/2007 9:31 PM:
> Premise: I don't know much about PayPalEvents.java and I didn't really
> reviewed BJ Freeman's patch.
>
> That said, I have a question: I've noticed that the change to the
> PayPalEvents.java slightly modify the logic of the event... are we sure
> that it is something we need? What is it supposed to fix/improve
> exactly? I cannot understand this (due to my limited knowledge of PayPal
> events) simply reading the comments in Jira and the svn log.
>
> Thanks,
>
> Jacopo
>
>
> jleroux@apache.org wrote:
>> Author: jleroux
>> Date: Thu Dec 20 13:21:47 2007
>> New Revision: 606031
>>
>> URL: http://svn.apache.org/viewvc?rev=606031&view=rev
>> Log:
>> Done by hand from an unusable patch of BJ Freeman "Authorize.NET
>> Payment Gateway Implementation"
>> (https://issues.apache.org/jira/browse/OFBIZ-274) - OFBIZ-274
>>
>> Modified:
>> ofbiz/trunk/applications/accounting/config/payment.properties
>>
>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>
>>
>> Modified: ofbiz/trunk/applications/accounting/config/payment.properties
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/config/payment.properties?rev=606031&r1=606030&r2=606031&view=diff
>>
>> ==============================================================================
>>
>> --- ofbiz/trunk/applications/accounting/config/payment.properties
>> (original)
>> +++ ofbiz/trunk/applications/accounting/config/payment.properties Thu
>> Dec 20 13:21:47 2007
>> @@ -240,33 +240,39 @@
>>
>> # PayPal E-Mail address
>> #payment.paypal.business=vote@ofbiz.org
>> -payment.paypal.business=vote@[yourServerName]
>> +payment.paypal.business=
>>
>> # PayPal Notify URL
>> -payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
>>
>> +#payment.paypal.notify=http://[yourServerName]/ecommerce/control/payPalNotify
>>
>> +payment.paypal.notify=
>>
>> # PayPal Return URL
>> -payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
>>
>> +#payment.paypal.return=http://[yourServerName]/ecommerce/control/orderhistory
>>
>> +payment.paypal.return=
>>
>> # PayPal Return On Cancel URL
>> -payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
>>
>> +#payment.paypal.cancelReturn=http://[yourServerName]/ecommerce/control/payPalCancel/main
>>
>> +payment.paypal.cancelReturn=
>>
>> # Image To Use On PayPal
>> #payment.paypal.image=http://[yourServerName]/images/ofbiz_logo.jpg
>> -payment.paypal.image=http://[yourServerName]/images/[your_logo].jpg
>> +payment.paypal.image=
>>
>> # Thank-You / Confirm Order Template (rendered via Freemarker)
>> -payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
>> +#payment.paypal.confirmTemplate=/order/emailconfirmation.ftl
>> +payment.paypal.confirmTemplate=
>>
>> # Production PayPal Redirect URL
>> #payment.paypal.redirect=https://www.paypal.com/cgi-bin/webscr
>> # Sandbox PayPal Redirect URL
>> -payment.paypal.redirect=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>> +#payment.paypal.redirect=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>>
>> +payment.paypal.redirect=
>>
>> # Production PayPal Confirm URL (JSSE must be configured to use SSL)
>> #payment.paypal.confirm=http://www.paypal.com/cgi-bin/webscr
>> # Sandbox PayPal Confirm URL (JSSE must be configured to use SSL)
>> -payment.paypal.confirm=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>> +#payment.paypal.confirm=https://www.sandbox.paypal.com/us/cgi-bin/webscr
>> +payment.paypal.confirm=
>>
>> ############################################
>> # PCCharge Configuration
>>
>> Modified:
>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>>
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java?rev=606031&r1=606030&r2=606031&view=diff
>>
>> ==============================================================================
>>
>> ---
>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>> (original)
>> +++
>> ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/paypal/PayPalEvents.java
>> Thu Dec 20 13:21:47 2007
>> @@ -129,7 +129,12 @@
>> // get the paypal account
>> String payPalAccount =
>> UtilProperties.getPropertyValue(configString, "payment.paypal.business");
>> - if (UtilValidate.isEmpty(notifyUrl) ||
>> UtilValidate.isEmpty(returnUrl) ||
>> UtilValidate.isEmpty(cancelReturnUrl)) {
>> + if (UtilValidate.isEmpty(redirectUrl) + ||
>> UtilValidate.isEmpty(notifyUrl) + ||
>> UtilValidate.isEmpty(returnUrl) + ||
>> UtilValidate.isEmpty(cancelReturnUrl) + ||
>> UtilValidate.isEmpty(imageUrl)
>> + || UtilValidate.isEmpty(payPalAccount) ) {
>> Debug.logError("Payment properties is not configured
>> properly, some notify URL from PayPal is not correctly defined!",
>> module);
>> request.setAttribute("_ERROR_MESSAGE_",
>> UtilProperties.getMessage(resource,
>> "payPalEvents.problemsGettingMerchantConfiguration", locale));
>> return "error";
>>
>
>
>
>