You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by purplecabbage <gi...@git.apache.org> on 2016/07/20 07:33:53 UTC
[GitHub] cordova-lib pull request #465: CB-11605 Non-destructive platform update
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-lib/pull/465
CB-11605 Non-destructive platform update
backup platformId@oldVersion before updating
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-lib CB-11605
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/465.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #465
----
commit fdda80fe572e2766d5aeeb674de0c7334553d2cc
Author: Jesse MacFadyen <pu...@gmail.com>
Date: 2016-07-20T07:27:30Z
backup platformId@oldVersion before updating
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #465: CB-11605 Non-destructive platform update
Posted by csantanapr <gi...@git.apache.org>.
Github user csantanapr commented on the issue:
https://github.com/apache/cordova-lib/pull/465
LGTM
Maybe print some message about next steps "you need to manually moved any platform configuration from backup version a.b.c to x.y.z as you see it fit for your project"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #465: CB-11605 Non-destructive platform update
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/465
Let there be tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #465: CB-11605 Non-destructive platform update
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/465
Yeah. I think the test attempts to call platforms/android/cordova/update on the old platform while I am expecting a create call.
Curiously though it passes on Travis for newer node versions, so there may be some npm link differences in our environments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #465: CB-11605 Non-destructive platform update
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the issue:
https://github.com/apache/cordova-lib/pull/465
I ran this PR with node 6.4.0 and got this:
```
Error: ENOENT: no such file or directory, stat '/Users/shazron/Documents/git/apache/cordova-lib/cordova-lib/spec-cordova/temp/testApp/platforms/android'
at Error (native)
at Object.fs.statSync (fs.js:987:18)
at /Users/shazron/Documents/git/apache/cordova-lib/cordova-lib/node_modules/shelljs/src/ls.js:99:68
at Array.forEach (native)
at _ls (/Users/shazron/Documents/git/apache/cordova-lib/cordova-lib/node_modules/shelljs/src/ls.js:65:9)
at /Users/shazron/Documents/git/apache/cordova-lib/cordova-lib/node_modules/shelljs/src/common.js:111:7
at Array.forEach (native)
at Object.expand (/Users/shazron/Documents/git/apache/cordova-lib/cordova-lib/node_modules/shelljs/src/common.js:94:8)
at Object._cp (/Users/shazron/Documents/git/apache/cordova-lib/cordova-lib/node_modules/shelljs/src/cp.js:155:20)
at Object.cp (/Users/shazron/Documents/git/apache/cordova-lib/cordova-lib/node_modules/shelljs/src/common.js:186:23)
```
The folder is definitely not there:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #465: CB-11605 Non-destructive platform update
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/465
## [Current coverage][cc-pull] is **61.73%**
> Merging [#465][cc-pull] into [master][cc-base-branch] will decrease coverage by **18.88%**
```diff
@@ master #465 diff @@
==========================================
Files 68 67 -1
Lines 5394 5405 +11
Methods 855 856 +1
Messages 0 0
Branches 1040 1042 +2
==========================================
- Hits 4349 3337 -1012
- Misses 1045 2068 +1023
Partials 0 0
```
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by [f05874a...82de549][cc-compare]
[cc-base-branch]: https://codecov.io/gh/apache/cordova-lib/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/apache/cordova-lib/compare/f05874a5420ea5fcf5b96290cb1a7fe18fe3e6d6...82de54982af0e087a16da68a813baab01882d57c?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-lib/pull/465?src=pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org