You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/18 08:26:21 UTC
[GitHub] [airflow] dstandish opened a new pull request, #28439: CustomTTYColoredFormatter should inherit TimezoneAware formatter
dstandish opened a new pull request, #28439:
URL: https://github.com/apache/airflow/pull/28439
So that the timestamp format is the same for both.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a diff in pull request #28439: CustomTTYColoredFormatter should inherit TimezoneAware formatter
Posted by GitBox <gi...@apache.org>.
dstandish commented on code in PR #28439:
URL: https://github.com/apache/airflow/pull/28439#discussion_r1058563809
##########
airflow/utils/log/colored_log.py:
##########
@@ -38,7 +40,7 @@
BOLD_OFF = esc("22")
-class CustomTTYColoredFormatter(TTYColoredFormatter):
+class CustomTTYColoredFormatter(TTYColoredFormatter, TimezoneAware):
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #28439: CustomTTYColoredFormatter should inherit TimezoneAware formatter
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #28439:
URL: https://github.com/apache/airflow/pull/28439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on a diff in pull request #28439: CustomTTYColoredFormatter should inherit TimezoneAware formatter
Posted by GitBox <gi...@apache.org>.
dstandish commented on code in PR #28439:
URL: https://github.com/apache/airflow/pull/28439#discussion_r1058564087
##########
airflow/utils/log/colored_log.py:
##########
@@ -38,7 +40,7 @@
BOLD_OFF = esc("22")
-class CustomTTYColoredFormatter(TTYColoredFormatter):
+class CustomTTYColoredFormatter(TTYColoredFormatter, TimezoneAware):
Review Comment:
oh forgot to add... sec
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a diff in pull request #28439: CustomTTYColoredFormatter should inherit TimezoneAware formatter
Posted by GitBox <gi...@apache.org>.
kaxil commented on code in PR #28439:
URL: https://github.com/apache/airflow/pull/28439#discussion_r1058395532
##########
airflow/utils/log/colored_log.py:
##########
@@ -38,7 +40,7 @@
BOLD_OFF = esc("22")
-class CustomTTYColoredFormatter(TTYColoredFormatter):
+class CustomTTYColoredFormatter(TTYColoredFormatter, TimezoneAware):
Review Comment:
Want to add any tests for it :) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org