You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by kh...@apache.org on 2018/02/18 19:11:26 UTC

maven-integration-testing git commit: Fixed IT's related to JDK 9 o Need to separate between JDK..8 and JDK 9 cause the error output looks different for JDK 9.

Repository: maven-integration-testing
Updated Branches:
  refs/heads/MNG-6364 5307189f8 -> 1327a7e16


Fixed IT's related to JDK 9
 o Need to separate between JDK..8 and JDK 9 cause
   the error output looks different for JDK 9.


Project: http://git-wip-us.apache.org/repos/asf/maven-integration-testing/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven-integration-testing/commit/1327a7e1
Tree: http://git-wip-us.apache.org/repos/asf/maven-integration-testing/tree/1327a7e1
Diff: http://git-wip-us.apache.org/repos/asf/maven-integration-testing/diff/1327a7e1

Branch: refs/heads/MNG-6364
Commit: 1327a7e16b3ed14ff9efcd91d4b4765a8ab613af
Parents: 5307189
Author: Karl Heinz Marbaise <kh...@apache.org>
Authored: Sun Feb 18 20:10:46 2018 +0100
Committer: Karl Heinz Marbaise <kh...@apache.org>
Committed: Sun Feb 18 20:10:46 2018 +0100

----------------------------------------------------------------------
 ...avenITmng5958LifecyclePhaseBinaryCompat.java | 28 +++++++++++++++++---
 1 file changed, 24 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/maven-integration-testing/blob/1327a7e1/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5958LifecyclePhaseBinaryCompat.java
----------------------------------------------------------------------
diff --git a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5958LifecyclePhaseBinaryCompat.java b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5958LifecyclePhaseBinaryCompat.java
index 3ee3fe1..4891fe2 100644
--- a/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5958LifecyclePhaseBinaryCompat.java
+++ b/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5958LifecyclePhaseBinaryCompat.java
@@ -17,19 +17,20 @@ public class MavenITmng5958LifecyclePhaseBinaryCompat
         throws Exception
     {
         File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-5958-lifecycle-phases/good" );
-        
+
         Verifier verifier = newVerifier( testDir.getAbsolutePath() );
         verifier.executeGoal( "validate" );
         verifier.verifyErrorFreeLog();
         verifier.verifyTextInLog( "CLASS_NAME=java.lang.String" );
         verifier.resetStreams();
     }
-    
-    public void testBad()
+
+    public void testBadTillJDK8()
         throws Exception
     {
+        requiresJavaVersion( "[,1.8]" );
         File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-5958-lifecycle-phases/bad" );
-        
+
         Verifier verifier = newVerifier( testDir.getAbsolutePath() );
         try
         {
@@ -42,4 +43,23 @@ public class MavenITmng5958LifecyclePhaseBinaryCompat
         }
         verifier.resetStreams();
     }
+
+    public void testBadJDK9()
+        throws Exception
+    {
+        requiresJavaVersion( "[9.0,)" );
+        File testDir = ResourceExtractor.simpleExtractResources( getClass(), "/mng-5958-lifecycle-phases/bad" );
+        
+        Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+        try
+        {
+            verifier.executeGoal( "validate" );
+        }
+        catch ( VerificationException e )
+        {
+            verifier.verifyTextInLog( "[ERROR] Internal error: java.lang.ClassCastException: "
+                + "org.apache.maven.lifecycle.mapping.LifecyclePhase cannot be cast to java.base/java.lang.String -> [Help 1]" );
+        }
+        verifier.resetStreams();
+    }
 }