You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/07/11 03:04:30 UTC

[GitHub] [hbase] infraio commented on a change in pull request #372: HBASE-22673 Avoid to expose protobuf stuff in Hbck interface

infraio commented on a change in pull request #372: HBASE-22673 Avoid to expose protobuf stuff in Hbck interface
URL: https://github.com/apache/hbase/pull/372#discussion_r302347326
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/HBaseHbck.java
 ##########
 @@ -173,6 +174,7 @@ private static String toCommaDelimitedString(List<String> list) {
   }
 
   @Override
+  @Deprecated
   public Map<String, MasterProtos.RegionErrorType>
 
 Review comment:
   My plan is only keep "fixing" method in Hbck interface. And add a chore thread to check wrong stuff in master and show them in master web ui. And now we can use HBCK1 to check these.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services