You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/06/22 16:50:05 UTC
[Impala-ASF-CR] IMPALA-5900: [DOCS] Doc fe service threads startup option
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10795
Change subject: IMPALA-5900: [DOCS] Doc fe_service_threads startup option
......................................................................
IMPALA-5900: [DOCS] Doc fe_service_threads startup option
Change-Id: I7f0a417a4aa07b8082037fc6ff355e62ce1493e5
---
M docs/topics/impala_config_options.xml
1 file changed, 30 insertions(+), 219 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/10795/1
--
To view, visit http://gerrit.cloudera.org:8080/10795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7f0a417a4aa07b8082037fc6ff355e62ce1493e5
Gerrit-Change-Number: 10795
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-5900: [DOCS] Doc fe service threads startup option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10795 )
Change subject: IMPALA-5900: [DOCS] Doc fe_service_threads startup option
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-docs-submit/329/
--
To view, visit http://gerrit.cloudera.org:8080/10795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0a417a4aa07b8082037fc6ff355e62ce1493e5
Gerrit-Change-Number: 10795
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jun 2018 18:21:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5900: [DOCS] Doc fe service threads startup option
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10795 )
Change subject: IMPALA-5900: [DOCS] Doc fe_service_threads startup option
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/10795/1/docs/topics/impala_config_options.xml
File docs/topics/impala_config_options.xml:
http://gerrit.cloudera.org:8080/#/c/10795/1/docs/topics/impala_config_options.xml@a305
PS1, Line 305:
> What's the plan for this? Why remove all of it?
This is duplicated above - around L#132
http://gerrit.cloudera.org:8080/#/c/10795/1/docs/topics/impala_config_options.xml@320
PS1, Line 320: reads and writes
> "reads from and writes to"?
Done
http://gerrit.cloudera.org:8080/#/c/10795/1/docs/topics/impala_config_options.xml@330
PS1, Line 330: clients
: has
> subject-verb disagreement
Done
http://gerrit.cloudera.org:8080/#/c/10795/1/docs/topics/impala_config_options.xml@332
PS1, Line 332: connection
> connections
Done
http://gerrit.cloudera.org:8080/#/c/10795/1/docs/topics/impala_config_options.xml@333
PS1, Line 333: most of connections
> either "most of the" or "most", not "most of?
Done
--
To view, visit http://gerrit.cloudera.org:8080/10795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0a417a4aa07b8082037fc6ff355e62ce1493e5
Gerrit-Change-Number: 10795
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jun 2018 17:39:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5900: [DOCS] Doc fe service threads startup option
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10795 )
Change subject: IMPALA-5900: [DOCS] Doc fe_service_threads startup option
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/10795/1/docs/topics/impala_config_options.xml
File docs/topics/impala_config_options.xml:
http://gerrit.cloudera.org:8080/#/c/10795/1/docs/topics/impala_config_options.xml@a305
PS1, Line 305:
What's the plan for this? Why remove all of it?
http://gerrit.cloudera.org:8080/#/c/10795/1/docs/topics/impala_config_options.xml@320
PS1, Line 320: reads and writes
"reads from and writes to"?
http://gerrit.cloudera.org:8080/#/c/10795/1/docs/topics/impala_config_options.xml@330
PS1, Line 330: clients
: has
subject-verb disagreement
http://gerrit.cloudera.org:8080/#/c/10795/1/docs/topics/impala_config_options.xml@332
PS1, Line 332: connection
connections
http://gerrit.cloudera.org:8080/#/c/10795/1/docs/topics/impala_config_options.xml@333
PS1, Line 333: most of connections
either "most of the" or "most", not "most of?
--
To view, visit http://gerrit.cloudera.org:8080/10795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0a417a4aa07b8082037fc6ff355e62ce1493e5
Gerrit-Change-Number: 10795
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jun 2018 17:25:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-5900: [DOCS] Doc fe service threads startup option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10795 )
Change subject: IMPALA-5900: [DOCS] Doc fe_service_threads startup option
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/330/
--
To view, visit http://gerrit.cloudera.org:8080/10795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0a417a4aa07b8082037fc6ff355e62ce1493e5
Gerrit-Change-Number: 10795
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jun 2018 20:09:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5900: [DOCS] Doc fe service threads startup option
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Juan Yu, Michael Brown, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10795
to look at the new patch set (#2).
Change subject: IMPALA-5900: [DOCS] Doc fe_service_threads startup option
......................................................................
IMPALA-5900: [DOCS] Doc fe_service_threads startup option
Change-Id: I7f0a417a4aa07b8082037fc6ff355e62ce1493e5
---
M docs/topics/impala_config_options.xml
1 file changed, 30 insertions(+), 219 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/10795/2
--
To view, visit http://gerrit.cloudera.org:8080/10795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7f0a417a4aa07b8082037fc6ff355e62ce1493e5
Gerrit-Change-Number: 10795
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5900: [DOCS] Doc fe service threads startup option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10795 )
Change subject: IMPALA-5900: [DOCS] Doc fe_service_threads startup option
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0a417a4aa07b8082037fc6ff355e62ce1493e5
Gerrit-Change-Number: 10795
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jun 2018 20:19:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5900: [DOCS] Doc fe service threads startup option
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/10795 )
Change subject: IMPALA-5900: [DOCS] Doc fe_service_threads startup option
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0a417a4aa07b8082037fc6ff355e62ce1493e5
Gerrit-Change-Number: 10795
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jun 2018 17:43:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-5900: [DOCS] Doc fe service threads startup option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10795 )
Change subject: IMPALA-5900: [DOCS] Doc fe_service_threads startup option
......................................................................
IMPALA-5900: [DOCS] Doc fe_service_threads startup option
Change-Id: I7f0a417a4aa07b8082037fc6ff355e62ce1493e5
Reviewed-on: http://gerrit.cloudera.org:8080/10795
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_config_options.xml
1 file changed, 30 insertions(+), 219 deletions(-)
Approvals:
Michael Brown: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7f0a417a4aa07b8082037fc6ff355e62ce1493e5
Gerrit-Change-Number: 10795
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-5900: [DOCS] Doc fe service threads startup option
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10795 )
Change subject: IMPALA-5900: [DOCS] Doc fe_service_threads startup option
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/329/
--
To view, visit http://gerrit.cloudera.org:8080/10795
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f0a417a4aa07b8082037fc6ff355e62ce1493e5
Gerrit-Change-Number: 10795
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Juan Yu <jy...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Jun 2018 17:49:08 +0000
Gerrit-HasComments: No