[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2825: Native debugging of GraalVM's native images.

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #2825:
URL: https://github.com/apache/netbeans/pull/2825#discussion_r605144047



##########
File path: java/java.nativeimage.debugger/src/org/netbeans/modules/java/nativeimage/debugger/actions/DebugNativeImageAction.java
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.netbeans.modules.java.nativeimage.debugger.actions;
+
+import org.netbeans.modules.java.nativeimage.debugger.api.NIDebugRunner;
+import java.io.File;
+import java.util.Collections;
+import javax.swing.Action;
+
+import org.netbeans.api.project.Project;
+import org.netbeans.api.project.ProjectUtils;
+import org.netbeans.modules.nativeimage.api.NIUtils;
+import org.netbeans.modules.nativeimage.api.debug.NIDebuggerService;
+import static org.netbeans.spi.project.ActionProvider.COMMAND_DEBUG;
+import org.netbeans.spi.project.ui.support.MainProjectSensitiveActions;
+import org.netbeans.spi.project.ui.support.ProjectActionPerformer;
+import org.openide.filesystems.FileObject;
+import org.openide.filesystems.FileUtil;
+import org.openide.util.NbBundle;
+
+/**
+ *
+ * @author martin
+ */
+public class DebugNativeImageAction {
+
+    @NbBundle.Messages("CTL_DebugNativeImage=Debug Native Image of {0,choice,-1#Main Project|0#Project|1#Project ({1})|1<{0} Projects}")
+    static Action create() {

Review comment:
       I wondered about this:
   
   > We can not debug any ELF file, but file produced by GraalVM EE native image only.
   
   So do we really consider integrating a change into the open code base to support a pay only product? It would IMHO be diffferent, if the feature would be in GraalVM CE, but if Oracle wants to keep this commercial, why do we need to support that?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists