You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by zh...@apache.org on 2025/01/31 14:17:37 UTC
(shardingsphere) branch master updated: Refactor GlobalRuleChangedHandlerTest (#34544)
This is an automated email from the ASF dual-hosted git repository.
zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 2e269b05679 Refactor GlobalRuleChangedHandlerTest (#34544)
2e269b05679 is described below
commit 2e269b05679745884a80ef607abc0d1591f42be4
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Fri Jan 31 22:17:31 2025 +0800
Refactor GlobalRuleChangedHandlerTest (#34544)
---
.../dispatch/handler/global/type/GlobalRuleChangedHandlerTest.java | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/global/type/GlobalRuleChangedHandlerTest.java b/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/global/type/GlobalRuleChangedHandlerTest.java
index f30813456db..7e5d46de78a 100644
--- a/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/global/type/GlobalRuleChangedHandlerTest.java
+++ b/mode/type/cluster/core/src/test/java/org/apache/shardingsphere/mode/manager/cluster/dispatch/handler/global/type/GlobalRuleChangedHandlerTest.java
@@ -32,6 +32,7 @@ import org.mockito.junit.jupiter.MockitoExtension;
import java.util.Optional;
+import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
@@ -54,13 +55,13 @@ class GlobalRuleChangedHandlerTest {
@Test
void assertHandleWithInvalidEventKey() {
handler.handle(contextManager, new DataChangedEvent("/rules/foo_rule/xxx", "rule_value", Type.ADDED));
- verify(contextManager, times(0)).getPersistServiceFacade();
+ verify(contextManager.getPersistServiceFacade().getMetaDataPersistFacade().getGlobalRuleService(), times(0)).load(any());
}
@Test
void assertHandleWithEmptyRuleName() {
handler.handle(contextManager, new DataChangedEvent("/rules/foo_rule/active_version/foo", "rule_value", Type.ADDED));
- verify(contextManager, times(0)).getPersistServiceFacade();
+ verify(contextManager.getPersistServiceFacade().getMetaDataPersistFacade().getGlobalRuleService(), times(0)).load(any());
}
@Test