You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2019/07/02 00:06:32 UTC
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13776
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
---
M docs/shared/impala_common.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_tables.xml
3 files changed, 41 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/13776/1
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Mike Percy, Alexey Serbin, Andrew Wong, Grant Henke, Hao Hao, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13776
to look at the new patch set (#9).
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
---
M docs/shared/impala_common.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_tables.xml
3 files changed, 85 insertions(+), 64 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/13776/9
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 9
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2115
PS4, Line 2115: Kudu service is integrated with the Hive Metastore, the above
: operations are not supported.</p>
:
> If there's a test for it, then I'm probably just doing something wrong. I'l
Alright, figured it out - Impala's test infra disables validation in the Kudu HMS plugin by default: https://github.com/apache/impala/blob/master/testdata/bin/run-hive-server.sh#L108
I verified that if I turn on validation I get an error as expected
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 9
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jul 2019 00:28:33 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 3:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/366/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jul 2019 01:18:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 10: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/391/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 10
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jul 2019 02:41:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 4:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2116
PS4, Line 2116: in Kudu that is integrated with Hive
: Metastore.
nit: maybe rephrase, "...if the Kudu service is integrated with the Hive Metastore."
Same elsewhere.
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2115
PS4, Line 2115: This
: operation is not supported in Kudu that is integrated with Hive
: Metastore.
> I don't think that this is correct. The design doc says that this applies t
We have been using the term "orphaned table" to refer to a Kudu table that does not have a corresponding HMS entry that points to it. This would open the door for inconsistencies between the HMS and Sentry namespace, illustrated by this example:
Alice has read permission on table default.TableA in the HMS, and an orphaned table in Kudu happens to be named the same. Now Alice has read permission to the Kudu table.
The checking happens on the HMS side, via the Kudu plugin, per this patch:
https://github.com/apache/kudu/commit/3f480941156068342dc2c66e38553712623d959e#diff-2b0d216b09b8edb51b0e735c485400e2
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_kudu.xml
File docs/topics/impala_kudu.xml:
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_kudu.xml@1116
PS4, Line 1116: <note>This section only applies the Kudu services that are not
> This patch mostly just points out things that no longer apply. Is there an
Upstream Kudu has just updated its docs to include both of these:
https://kudu.apache.org/docs/hive_metastore.html
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml
File docs/topics/impala_tables.xml:
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml@289
PS4, Line 289: Some
: information about the table is stored in the metastore database for use
: by Impala. Other table metadata is managed internally by Kudu.
Actually all data that Impala needs is stored in the HMS (including things that Kudu doesn't necessarily know about right now, like stats). Some of that may also be stored in Kudu (schemas, etc.).
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml@293
PS4, Line 293: <p>
: In the Kudu services enabled to use Hive Metastore (HMS), all metadata
: is managed by HMS.
: </p>
This isn't quite right. Mostly it's managed by Kudu. Some Impala-specific things are managed by Impala still (stats, for example).
We may want to consider leaving this sentence off.
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml@336
PS4, Line 336: In the Kudu integrated with HMS, the <codeph>impala::</codeph> prefix
> Maybe move this up to be directly after the paragraph that talks about '::'
+1
Might consider merging this with that sentence, something like:
"When Kudu is not integrated with the HMS, when you create a Kudu table through Impala, the table is assigned an internal Kudu table name of the form ..."
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 10 Jul 2019 00:51:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Mike Percy, Andrew Wong, Grant Henke, Hao Hao, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13776
to look at the new patch set (#7).
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
---
M docs/shared/impala_common.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_tables.xml
3 files changed, 86 insertions(+), 64 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/13776/7
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2115
PS4, Line 2115: Kudu service is integrated with the Hive Metastore, this operation
: is not supported in Kudu that is integrated with Hive Metastore. </p>
:
> Yes, AFAICT this is right. Thomas, could you elaborate on the experimentati
Am I understanding correctly then that altering a Kudu table between external/internal should never work when HMS integration is enabled?
I can run Kudu locally with HMS integration turned on, create a table, and alter it back and forth without getting any errors.
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 22:59:58 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 1: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/363/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jul 2019 00:31:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 3: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/366/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jul 2019 01:30:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 10: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4577
PS8, Line 4577: <
> Done.
Ah, I should have guessed. Those were nits, so please feel to ignore those in the case you are using some advanced editor.
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 10
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jul 2019 02:35:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 4:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2115
PS4, Line 2115: This
: operation is not supported in Kudu that is integrated with Hive
: Metastore.
I don't think that this is correct. The design doc says that this applies to "orphaned" tables, i.e. Kudu tables that existed in Impala before HMS integration was turned on and haven't been updated with the fix tool.
However, I don't think this is actually being enforced, both from looking at it experimentally and from looking through the code. Could someone from the Kudu team confirm my understanding here?
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_kudu.xml
File docs/topics/impala_kudu.xml:
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_kudu.xml@1116
PS4, Line 1116: <note>This section only applies the Kudu services that are not
This patch mostly just points out things that no longer apply. Is there an intention to add a section about how the new integration works or how to do the upgrade?
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml
File docs/topics/impala_tables.xml:
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml@336
PS4, Line 336: In the Kudu integrated with HMS, the <codeph>impala::</codeph> prefix
Maybe move this up to be directly after the paragraph that talks about '::' above
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 09 Jul 2019 19:04:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 6:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/386/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 22:03:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 5:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/384/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jul 2019 02:16:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 6: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/386/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 22:30:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13776/5/docs/topics/impala_kudu.xml
File docs/topics/impala_kudu.xml:
http://gerrit.cloudera.org:8080/#/c/13776/5/docs/topics/impala_kudu.xml@1157
PS5, Line 1157: <li> Since there may be no one-to-one mapping between Kudu tables and
: external tables, only internal tables are automatically
: synchronized. </li>
> What does this mean? How does Kudu enforce the presence of an internal tabl
When you create a table in Kudu when the HMS integration is turned on, Kudu will create an HMS entry for that table with a MANAGED table type.
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 22:20:01 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Mike Percy, Andrew Wong, Grant Henke, Hao Hao, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13776
to look at the new patch set (#8).
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
---
M docs/shared/impala_common.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_tables.xml
3 files changed, 86 insertions(+), 64 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/13776/8
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 8
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 5:
@thomas Could you take a look at the new patch I uploaded? Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 20:41:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 5:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2115
PS4, Line 2115: Kudu service is integrated with the Hive Metastore, This operation
: is not supported in Kudu that is integrated with Hive Metastore. </p>
:
> @andrew So this statement is correct, right?
Yes, AFAICT this is right. Thomas, could you elaborate on the experimentation you mentioned?
http://gerrit.cloudera.org:8080/#/c/13776/5/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/13776/5/docs/shared/impala_common.xml@2115
PS5, Line 2115: This op
nit: lowercase
http://gerrit.cloudera.org:8080/#/c/13776/5/docs/topics/impala_kudu.xml
File docs/topics/impala_kudu.xml:
http://gerrit.cloudera.org:8080/#/c/13776/5/docs/topics/impala_kudu.xml@1157
PS5, Line 1157: <li> Since there may be no one-to-one mapping between Kudu tables and
: external tables, only internal tables are automatically
: synchronized. </li>
A more user-facing effect of the HMS integration is that Kudu will enforce the presence of an internal table in the HMS for every Kudu table.
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 21:50:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 10:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/391/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 10
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jul 2019 02:28:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Andrew Wong, Grant Henke, Hao Hao, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13776
to look at the new patch set (#3).
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
---
M docs/shared/impala_common.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_tables.xml
3 files changed, 56 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/13776/3
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/13776/5/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/13776/5/docs/shared/impala_common.xml@2115
PS5, Line 2115: This op
> nit: lowercase
Done
http://gerrit.cloudera.org:8080/#/c/13776/5/docs/topics/impala_kudu.xml
File docs/topics/impala_kudu.xml:
http://gerrit.cloudera.org:8080/#/c/13776/5/docs/topics/impala_kudu.xml@1157
PS5, Line 1157: <li> Since there may be no one-to-one mapping between Kudu tables and
: external tables, only internal tables are automatically
: synchronized. </li>
> A more user-facing effect of the HMS integration is that Kudu will enforce
What does this mean? How does Kudu enforce the presence of an internal table in the HMS?
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jul 2019 22:03:26 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 9: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/390/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 9
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2019 23:08:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 10
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jul 2019 16:46:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 9:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/390/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 9
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2019 22:45:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 8:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@2116
PS8, Line 2116:
> nit: extra space
Done
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@2116
PS8, Line 2116: in Kudu that is integrated with Hive Metastore
> drop
Done
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@2115
PS8, Line 2115: this operation
: is
> these operations
Done
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4540
PS8, Line 4540:
> nit: extra space
Done
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4545
PS8, Line 4545: If the Kudu service is not integrated
: with the Hive Metastore, Kudu stores all its metadata in HMS.
> Ah good catch. This should probably be something like, "If the Kudu service
Done
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4546
PS8, Line 4546:
> nit: an extra space
Done
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4545
PS8, Line 4545: If the Kudu service is not integrated
: with the Hive Metastore, Kudu stores all its metadata in HMS.
> I thought it was vice-versa, no?
Fixed as Andrew recommended.
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4577
PS8, Line 4577:
> nit: an extra space
Done.
Actually, the editor adds spaces like this.
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 8
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2019 22:44:06 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 2: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/364/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jul 2019 00:31:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Reviewed-on: http://gerrit.cloudera.org:8080/13776
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Thomas Tauber-Marshall <tm...@cloudera.com>
---
M docs/shared/impala_common.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_tables.xml
3 files changed, 85 insertions(+), 64 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, but someone else must approve
Impala Public Jenkins: Verified
Andrew Wong: Looks good to me, but someone else must approve
Thomas Tauber-Marshall: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 11
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2115
PS4, Line 2115: Kudu service is integrated with the Hive Metastore, the above
: operations are not supported.</p>
:
> Hrm, that's surprising to me because we have tests that test for this:
If there's a test for it, then I'm probably just doing something wrong. I'll try to figure it out, but of course we don't need to hold this review up for it
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 9
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2019 23:34:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13776
to look at the new patch set (#2).
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
---
M docs/shared/impala_common.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_tables.xml
3 files changed, 48 insertions(+), 28 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/13776/2
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4545
PS8, Line 4545: If the Kudu service is not integrated
: with the Hive Metastore, Kudu stores all its metadata in HMS.
> I thought it was vice-versa, no?
Ah good catch. This should probably be something like, "If the Kudu service is not integrated with the Hive Metastore, Impala will manage Kudu table metadata in the HMS."
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 8
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2019 22:27:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 4:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/367/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jul 2019 01:22:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 10:
Thomas, Could you approve?
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 10
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Sat, 20 Jul 2019 03:20:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 7:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/387/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jul 2019 01:24:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Mike Percy, Andrew Wong, Grant Henke, Hao Hao, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13776
to look at the new patch set (#5).
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
---
M docs/shared/impala_common.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_tables.xml
3 files changed, 84 insertions(+), 64 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/13776/5
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 4: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/367/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jul 2019 01:32:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 7: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/387/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jul 2019 01:44:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13776/9/docs/topics/impala_tables.xml
File docs/topics/impala_tables.xml:
http://gerrit.cloudera.org:8080/#/c/13776/9/docs/topics/impala_tables.xml@289
PS9, Line 289: data
> It'd be slightly more correct to say "metadata" here
Done
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 9
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jul 2019 02:27:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Mike Percy, Alexey Serbin, Andrew Wong, Grant Henke, Hao Hao, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13776
to look at the new patch set (#10).
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
---
M docs/shared/impala_common.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_tables.xml
3 files changed, 85 insertions(+), 64 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/13776/10
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 10
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Mike Percy, Andrew Wong, Grant Henke, Hao Hao, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13776
to look at the new patch set (#6).
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
---
M docs/shared/impala_common.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_tables.xml
3 files changed, 86 insertions(+), 64 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/13776/6
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 8:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/388/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 8
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2019 00:46:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 10: Code-Review+1
Content LGTM too
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 10
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jul 2019 23:17:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 5: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/384/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jul 2019 02:40:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 2:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/364/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jul 2019 00:12:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 7:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@2116
PS8, Line 2116: in Kudu that is integrated with Hive Metastore
drop
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@2115
PS8, Line 2115: this operation
: is
these operations
As I remember, both 'managed/internal --> external' and 'external --> managed/internal' are prohibited. As I read it the added note in PS8 revision, it's not quite clear whether it's about both SQL statements above or just the latter.
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@2116
PS8, Line 2116:
nit: extra space
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4540
PS8, Line 4540:
nit: extra space
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4545
PS8, Line 4545: If the Kudu service is not integrated
: with the Hive Metastore, Kudu stores all its metadata in HMS.
I thought it was vice-versa, no?
Also, it sounds like all Kudu's metadata on tables is stored in HMS, but that's not correct. IIUC, as of now Kudu stores in HMS the metadata to make its tables discoverable via the HMS catalog and accessible by HMS-compatible SQL engines like Impala. Not sure whether that's the best wording, though.
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4546
PS8, Line 4546:
nit: an extra space
http://gerrit.cloudera.org:8080/#/c/13776/8/docs/shared/impala_common.xml@4577
PS8, Line 4577:
nit: an extra space
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2019 18:13:56 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 8: Verified+1
Build Successful
https://jenkins.impala.io/job/gerrit-docs-auto-test/388/ : Doc tests passed.
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 8
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2019 01:09:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13776/5/docs/topics/impala_kudu.xml
File docs/topics/impala_kudu.xml:
http://gerrit.cloudera.org:8080/#/c/13776/5/docs/topics/impala_kudu.xml@1157
PS5, Line 1157: <li> Since there may be no one-to-one mapping between Kudu tables and
: external tables, only internal tables are automatically
: synchronized. </li>
> When you create a table in Kudu when the HMS integration is turned on, Kudu
Done
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jul 2019 01:24:45 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 1:
Build Started https://jenkins.impala.io/job/gerrit-docs-auto-test/363/
Testing docs change - this change appears to modify docs/ and no code. This is experimental - please report any issues to tarmstrong@cloudera.com or on this JIRA: IMPALA-7317
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jul 2019 00:06:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 4:
(9 comments)
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2116
PS4, Line 2116: in Kudu that is integrated with Hive
: Metastore.
> nit: maybe rephrase, "...if the Kudu service is integrated with the Hive Me
Done
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2115
PS4, Line 2115: This
: operation is not supported in Kudu that is integrated with Hive
: Metastore.
> We have been using the term "orphaned table" to refer to a Kudu table that
@andrew So this statement is correct, right?
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2115
PS4, Line 2115: This
: operation is not supported in Kudu that is integrated with Hive
: Metastore.
> I don't think that this is correct. The design doc says that this applies t
According to Andrew's comment, this is correct, no?
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_kudu.xml
File docs/topics/impala_kudu.xml:
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_kudu.xml@1116
PS4, Line 1116: <note>This section only applies the Kudu services that are not
> This patch mostly just points out things that no longer apply. Is there an
Added a section and a link to kudu doc.
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_kudu.xml@1116
PS4, Line 1116: <note>This section only applies the Kudu services that are not
> Upstream Kudu has just updated its docs to include both of these:
Done
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml
File docs/topics/impala_tables.xml:
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml@289
PS4, Line 289: Some
: information about the table is stored in the metastore database for use
: by Impala. Other table metadata is managed internally by Kudu.
> Actually all data that Impala needs is stored in the HMS (including things
Changed to: All data that Impala needs is stored in the HMS.
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml@293
PS4, Line 293: <p>
: In the Kudu services enabled to use Hive Metastore (HMS), all metadata
: is managed by HMS.
: </p>
> This isn't quite right. Mostly it's managed by Kudu. Some Impala-specific t
Done
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml@336
PS4, Line 336: In the Kudu integrated with HMS, the <codeph>impala::</codeph> prefix
> Maybe move this up to be directly after the paragraph that talks about '::'
Done
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/topics/impala_tables.xml@336
PS4, Line 336: In the Kudu integrated with HMS, the <codeph>impala::</codeph> prefix
> +1
Done
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 12 Jul 2019 02:15:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 9: Code-Review+1
(2 comments)
One minor point, otherwise LGTM!
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2115
PS4, Line 2115: Kudu service is integrated with the Hive Metastore, the above
: operations are not supported.</p>
:
> Alright, figured it out - Impala's test infra disables validation in the Ku
Ah, nice find!
http://gerrit.cloudera.org:8080/#/c/13776/9/docs/topics/impala_tables.xml
File docs/topics/impala_tables.xml:
http://gerrit.cloudera.org:8080/#/c/13776/9/docs/topics/impala_tables.xml@289
PS9, Line 289: data
It'd be slightly more correct to say "metadata" here
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 9
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jul 2019 01:17:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Thomas Tauber-Marshall, Andrew Wong, Grant Henke, Hao Hao, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13776
to look at the new patch set (#4).
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
---
M docs/shared/impala_common.xml
M docs/topics/impala_kudu.xml
M docs/topics/impala_tables.xml
3 files changed, 60 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/13776/4
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13776 )
Change subject: IMPALA-8727: [DOCS] Impala-side changes for Kudu HMS integration
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml
File docs/shared/impala_common.xml:
http://gerrit.cloudera.org:8080/#/c/13776/4/docs/shared/impala_common.xml@2115
PS4, Line 2115: Kudu service is integrated with the Hive Metastore, this operation
: is not supported in Kudu that is integrated with Hive Metastore. </p>
:
> Am I understanding correctly then that altering a Kudu table between extern
Hrm, that's surprising to me because we have tests that test for this:
https://github.infra.cloudera.com/QE/cmf/blob/68bc1e95444cdb54c76690df6c0be2bc21e60ed7/systest/test_kudu_hms_enabled_l1.py#L519
running the query:
https://github.infra.cloudera.com/QE/cmf/blob/b4944a49437706eebe443ed0b2fc48b65058e898/systest/kudu/kudu_hms_integration_test_base.py#L20
What version of the Kudu HMS plugin are you using locally? Has it been rebuilt since June (when Hao's plugin patch went in)?
--
To view, visit http://gerrit.cloudera.org:8080/13776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieec79ac0bbb860c6394a3bf0617b285a7d23ca9e
Gerrit-Change-Number: 13776
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jul 2019 00:10:24 +0000
Gerrit-HasComments: Yes