You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@onami.apache.org by ma...@apache.org on 2013/01/20 15:28:25 UTC
svn commit: r1435848 - in
/incubator/onami/trunk/test/src/main/java/org/apache/onami/test:
OnamiRunner.java handler/GuiceModuleHandler.java
Author: marcosperanza
Date: Sun Jan 20 14:28:25 2013
New Revision: 1435848
URL: http://svn.apache.org/viewvc?rev=1435848&view=rev
Log:
[ONAMI-58] Collections initialized with dimension 1
Modified:
incubator/onami/trunk/test/src/main/java/org/apache/onami/test/OnamiRunner.java
incubator/onami/trunk/test/src/main/java/org/apache/onami/test/handler/GuiceModuleHandler.java
Modified: incubator/onami/trunk/test/src/main/java/org/apache/onami/test/OnamiRunner.java
URL: http://svn.apache.org/viewvc/incubator/onami/trunk/test/src/main/java/org/apache/onami/test/OnamiRunner.java?rev=1435848&r1=1435847&r2=1435848&view=diff
==============================================================================
--- incubator/onami/trunk/test/src/main/java/org/apache/onami/test/OnamiRunner.java (original)
+++ incubator/onami/trunk/test/src/main/java/org/apache/onami/test/OnamiRunner.java Sun Jan 20 14:28:25 2013
@@ -23,6 +23,7 @@ import java.lang.reflect.Field;
import java.lang.reflect.Modifier;
import java.util.ArrayList;
import java.util.HashMap;
+import java.util.LinkedList;
import java.util.List;
import java.util.Map;
import java.util.Map.Entry;
@@ -162,7 +163,7 @@ public class OnamiRunner
}
catch ( Exception e )
{
- final List<Throwable> throwables = new ArrayList<Throwable>( 1 );
+ final List<Throwable> throwables = new LinkedList<Throwable>();
throwables.add( e );
throw new InitializationError( throwables );
}
@@ -289,7 +290,7 @@ public class OnamiRunner
{
LOGGER.finer( " Start introspecting class: " + clazz.getName() );
}
- final List<Module> allModules = new ArrayList<Module>( 1 );
+ final List<Module> allModules = new ArrayList<Module>();
// Setup the handlers
final GuiceProvidedModuleHandler guiceProvidedModuleHandler = new GuiceProvidedModuleHandler();
Modified: incubator/onami/trunk/test/src/main/java/org/apache/onami/test/handler/GuiceModuleHandler.java
URL: http://svn.apache.org/viewvc/incubator/onami/trunk/test/src/main/java/org/apache/onami/test/handler/GuiceModuleHandler.java?rev=1435848&r1=1435847&r2=1435848&view=diff
==============================================================================
--- incubator/onami/trunk/test/src/main/java/org/apache/onami/test/handler/GuiceModuleHandler.java (original)
+++ incubator/onami/trunk/test/src/main/java/org/apache/onami/test/handler/GuiceModuleHandler.java Sun Jan 20 14:28:25 2013
@@ -41,7 +41,7 @@ public final class GuiceModuleHandler
private static final Logger LOGGER = Logger.getLogger( GuiceModuleHandler.class.getName() );
- private final List<Module> modules = new ArrayList<Module>( 1 );
+ private final List<Module> modules = new ArrayList<Module>();
/**
* @return the modules
Re: svn commit: r1435848 - in /incubator/onami/trunk/test/src/main/java/org/apache/onami/test:
OnamiRunner.java handler/GuiceModuleHandler.java
Posted by Simone Tripodi <si...@apache.org>.
Good!!
> @@ -289,7 +290,7 @@ public class OnamiRunner
> {
> LOGGER.finer( " Start introspecting class: " + clazz.getName() );
> }
> - final List<Module> allModules = new ArrayList<Module>( 1 );
> + final List<Module> allModules = new ArrayList<Module>();
>
> // Setup the handlers
> final GuiceProvidedModuleHandler guiceProvidedModuleHandler = new GuiceProvidedModuleHandler();
>
> Modified: incubator/onami/trunk/test/src/main/java/org/apache/onami/test/handler/GuiceModuleHandler.java
> URL: http://svn.apache.org/viewvc/incubator/onami/trunk/test/src/main/java/org/apache/onami/test/handler/GuiceModuleHandler.java?rev=1435848&r1=1435847&r2=1435848&view=diff
> ==============================================================================
> --- incubator/onami/trunk/test/src/main/java/org/apache/onami/test/handler/GuiceModuleHandler.java (original)
> +++ incubator/onami/trunk/test/src/main/java/org/apache/onami/test/handler/GuiceModuleHandler.java Sun Jan 20 14:28:25 2013
> @@ -41,7 +41,7 @@ public final class GuiceModuleHandler
>
> private static final Logger LOGGER = Logger.getLogger( GuiceModuleHandler.class.getName() );
>
> - private final List<Module> modules = new ArrayList<Module>( 1 );
> + private final List<Module> modules = new ArrayList<Module>();
I think you can use LinkedList here as well - WDYT?
TIA!
-Simo
http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/