You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Vincent Siveton (JIRA)" <ji...@codehaus.org> on 2008/03/03 12:34:29 UTC
[jira] Created: (MSHADE-20) Take care of Manifest attributes
defined in maven-jar-plugin
Take care of Manifest attributes defined in maven-jar-plugin
------------------------------------------------------------
Key: MSHADE-20
URL: http://jira.codehaus.org/browse/MSHADE-20
Project: Maven 2.x Shade Plugin
Issue Type: Bug
Affects Versions: 1.1
Reporter: Vincent Siveton
Using the following in the POM
{code:xml}
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<configuration>
<archive>
<manifest>
<mainClass>MyMainClass</mainClass>
...
</manifest>
</archive>
</configuration>
</plugin>
{code}
The manifest in the generated artifact has a Main-Class attribute but it is not present in the *uber.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (MSHADE-20) Take care of Manifest attributes defined
in maven-jar-plugin
Posted by "Benjamin Bentmann (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHADE-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Bentmann closed MSHADE-20.
-----------------------------------
Resolution: Cannot Reproduce
Assignee: Benjamin Bentmann
Even version 1.1 seems to retain to main artifact's manifest entries. As of MSHADE-39, the manifest entries can also be configured in the Shade Plugin directly.
> Take care of Manifest attributes defined in maven-jar-plugin
> ------------------------------------------------------------
>
> Key: MSHADE-20
> URL: http://jira.codehaus.org/browse/MSHADE-20
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Vincent Siveton
> Assignee: Benjamin Bentmann
> Attachments: MSHADE-20-reworked.diff, MSHADE-20.diff
>
>
> Using the following in the POM
> {code:xml}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <configuration>
> <archive>
> <manifest>
> <mainClass>MyMainClass</mainClass>
> ...
> </manifest>
> </archive>
> </configuration>
> </plugin>
> {code}
> The manifest in the generated artifact has a Main-Class attribute but it is not present in the *uber.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHADE-20) Take care of Manifest attributes
defined in maven-jar-plugin
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHADE-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_125971 ]
Brett Porter commented on MSHADE-20:
------------------------------------
what version were you using? It would be best checked against a release instead of trunk
I just tried this on maven-core using the 1.0 release and it worked as expected.
> Take care of Manifest attributes defined in maven-jar-plugin
> ------------------------------------------------------------
>
> Key: MSHADE-20
> URL: http://jira.codehaus.org/browse/MSHADE-20
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Vincent Siveton
>
> Using the following in the POM
> {code:xml}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <configuration>
> <archive>
> <manifest>
> <mainClass>MyMainClass</mainClass>
> ...
> </manifest>
> </archive>
> </configuration>
> </plugin>
> {code}
> The manifest in the generated artifact has a Main-Class attribute but it is not present in the *uber.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSHADE-20) Take care of Manifest attributes
defined in maven-jar-plugin
Posted by "Herve Boutemy (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHADE-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Herve Boutemy updated MSHADE-20:
--------------------------------
Attachment: MSHADE-20-reworked.diff
I tested your patch on doxia-converter
AFAIK, the problem is that the manifest entry is not in the original jar file: the Main-Class entry is added in the assembly
here is a modified patch to add the entry in the original jar, and then everything is ok either with shade plugin 1.0 or 1.1-SNAPSHOT
can you confirm?
> Take care of Manifest attributes defined in maven-jar-plugin
> ------------------------------------------------------------
>
> Key: MSHADE-20
> URL: http://jira.codehaus.org/browse/MSHADE-20
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Vincent Siveton
> Attachments: MSHADE-20-reworked.diff, MSHADE-20.diff
>
>
> Using the following in the POM
> {code:xml}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <configuration>
> <archive>
> <manifest>
> <mainClass>MyMainClass</mainClass>
> ...
> </manifest>
> </archive>
> </configuration>
> </plugin>
> {code}
> The manifest in the generated artifact has a Main-Class attribute but it is not present in the *uber.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MSHADE-20) Take care of Manifest attributes
defined in maven-jar-plugin
Posted by "Vincent Siveton (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHADE-20?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_125987 ]
Vincent Siveton commented on MSHADE-20:
---------------------------------------
As I said, it affects 1.1 so the trunk :) i.e r633337
> Take care of Manifest attributes defined in maven-jar-plugin
> ------------------------------------------------------------
>
> Key: MSHADE-20
> URL: http://jira.codehaus.org/browse/MSHADE-20
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Vincent Siveton
>
> Using the following in the POM
> {code:xml}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <configuration>
> <archive>
> <manifest>
> <mainClass>MyMainClass</mainClass>
> ...
> </manifest>
> </archive>
> </configuration>
> </plugin>
> {code}
> The manifest in the generated artifact has a Main-Class attribute but it is not present in the *uber.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MSHADE-20) Take care of Manifest attributes
defined in maven-jar-plugin
Posted by "Vincent Siveton (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MSHADE-20?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vincent Siveton updated MSHADE-20:
----------------------------------
Attachment: MSHADE-20.diff
Here is a test case under doxia-converter [1]
[1] https://svn.apache.org/repos/asf/maven/doxia/doxia-tools/trunk/doxia-converter
> Take care of Manifest attributes defined in maven-jar-plugin
> ------------------------------------------------------------
>
> Key: MSHADE-20
> URL: http://jira.codehaus.org/browse/MSHADE-20
> Project: Maven 2.x Shade Plugin
> Issue Type: Bug
> Affects Versions: 1.1
> Reporter: Vincent Siveton
> Attachments: MSHADE-20.diff
>
>
> Using the following in the POM
> {code:xml}
> <plugin>
> <groupId>org.apache.maven.plugins</groupId>
> <artifactId>maven-jar-plugin</artifactId>
> <configuration>
> <archive>
> <manifest>
> <mainClass>MyMainClass</mainClass>
> ...
> </manifest>
> </archive>
> </configuration>
> </plugin>
> {code}
> The manifest in the generated artifact has a Main-Class attribute but it is not present in the *uber.jar.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira