You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2017/05/15 09:16:36 UTC
[GitHub] flink pull request #3899: [FLINK-6557] Fix RocksDBKeyedStateBackend on Windo...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/3899
[FLINK-6557] Fix RocksDBKeyedStateBackend on Windows
This PR fixes the `RocksDBKeyedStateBackend` on Windows. The backend was passing file paths generated from a Flink `Path` directly to RocksDB, and by extension to the native file system.
Besides the actual problem being caused this was questionable anyway since the starting point for all this is actually a `File` (`stateBackend.instanceBasePath`). It is first converted to a String, then to a Path, then to a String again before passing it to RocksDB. We were just roller coasting through the abstraction layers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 6557_rocks_test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3899.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3899
----
commit 29ae9f80e4a1bdf2bc19cc98b2dd2479f75f6626
Author: zentol <ch...@apache.org>
Date: 2017-05-15T09:02:13Z
[FLINK-6557] Fix RocksDBKeyedStateBackend on Windows
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3899: [FLINK-6557] Fix RocksDBKeyedStateBackend on Windo...
Posted by zentol <gi...@git.apache.org>.
Github user zentol closed the pull request at:
https://github.com/apache/flink/pull/3899
---
[GitHub] flink issue #3899: [FLINK-6557] Fix RocksDBKeyedStateBackend on Windows
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3899
I think this LGTM. I also prefer this fix over #4269.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---