You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2017/05/25 16:21:53 UTC

[kudu-CR] Allow external miniclusters to use data dirs

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/6845

to look at the new patch set (#8).

Change subject: Allow external miniclusters to use data dirs
......................................................................

Allow external miniclusters to use data dirs

In order to test different disk configurations, it is becoming
increasingly important to have end-to-end testing with nodes backed
by multiple directories. Currently external miniclusters use a single
directory for each daemon's data (i.e. wals, data dirs, logs).

This patch adds this functionality to the ExternalMiniCluster class,
which now supports a new optional ExternalDaemonPathSpec struct.
Since miniclusters generate directories under a single data root,
specifying full path names isn't feasible at runtime. The
ExternalDaemonPathSpec specifies directories as a list of numeric
post-fixes to add to the original path.

E.g. mini clusters that would have used the path /mini/cluster/data
can now specify multiple directories /mini/cluster/data-1,
/mini/cluster/data-2, /mini/cluster/data-3, etc.

Change-Id: Id2f5def6980ad394c8558ad97ba830f1b0257332
---
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/external_mini_cluster.h
M src/kudu/integration-tests/ts_itest-base.h
M src/kudu/util/path_util.cc
M src/kudu/util/path_util.h
5 files changed, 108 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/45/6845/8
-- 
To view, visit http://gerrit.cloudera.org:8080/6845
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id2f5def6980ad394c8558ad97ba830f1b0257332
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot