[GitHub] [incubator-devlake] klesh commented on a diff in pull request #4674: feat: enhance timeFilter/diffSync support for jenkins and github plugin

["klesh (via GitHub)" <gi...@apache.org>]

klesh commented on code in PR #4674:
URL: https://github.com/apache/incubator-devlake/pull/4674#discussion_r1138175980


##########
backend/plugins/jenkins/tasks/build_collector.go:
##########
@@ -33,7 +34,7 @@ var CollectApiBuildsMeta = plugin.SubTaskMeta{
 	Name:             "collectApiBuilds",
 	EntryPoint:       CollectApiBuilds,
 	EnabledByDefault: true,
-	Description:      "Collect builds data from jenkins api",
+	Description:      "Collect builds data from jenkins api, does not support either timeFilter or diffSync.",

Review Comment:
   Why not? `builds` are short-lived and finalizable, aren't they? 



##########
backend/plugins/github/tasks/event_collector.go:
##########
@@ -36,7 +36,7 @@ var CollectApiEventsMeta = plugin.SubTaskMeta{
 	Name:             "collectApiEvents",
 	EntryPoint:       CollectApiEvents,
 	EnabledByDefault: true,
-	Description:      "Collect Events data from Github api",
+	Description:      "Collect Events data from Github api, does not support either timeFilter or diffSync.",

Review Comment:
   I think event collector can support timeFilter and diffSync since it can NOT be updated, just like changelog, can it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org