You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2026/02/24 13:15:10 UTC
[PR] [WIP][SPARK-55657][BUILD] Bump Hadoop 3.5.0 RC0 [spark]
pan3793 opened a new pull request, #54448:
URL: https://github.com/apache/spark/pull/54448
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Hadoop 3.5.0 RC0
https://lists.apache.org/thread/qdopfc0brcjnjz4g0sgb8jhr00xv3ott
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Release notes
https://dist.apache.org/repos/dist/dev/hadoop/hadoop-3.5.0-RC0/RELEASENOTES.md
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SPARK-55657][BUILD] Bump Hadoop 3.5.0 RC0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #54448:
URL: https://github.com/apache/spark/pull/54448#discussion_r2854341723
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -240,6 +246,8 @@ objenesis/3.5//objenesis-3.5.jar
okhttp/3.12.12//okhttp-3.12.12.jar
okio/1.17.6//okio-1.17.6.jar
opencsv/2.3//opencsv-2.3.jar
+opentelemetry-api/1.49.0//opentelemetry-api-1.49.0.jar
+opentelemetry-context/1.49.0//opentelemetry-context-1.49.0.jar
Review Comment:
Are these new dependency?
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -258,6 +266,7 @@ parquet-hadoop/1.17.0//parquet-hadoop-1.17.0.jar
parquet-jackson/1.17.0//parquet-jackson-1.17.0.jar
pickle/1.5//pickle-1.5.jar
py4j/0.10.9.9//py4j-0.10.9.9.jar
+reactive-streams/1.0.3//reactive-streams-1.0.3.jar
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55657][BUILD] Bump Hadoop 3.5.0 [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #54448:
URL: https://github.com/apache/spark/pull/54448#issuecomment-4174165266
@dongjoon-hyun Hadoop 3.5.0 RC2 passes vote, and the jars have been available in Maven Central. this PR is ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SPARK-55657][BUILD] Bump Hadoop 3.5.0 RC0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #54448:
URL: https://github.com/apache/spark/pull/54448#discussion_r2867259684
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -68,16 +71,18 @@ gcs-connector/hadoop3-2.2.31/shaded/gcs-connector-hadoop3-2.2.31-shaded.jar
gmetric4j/1.0.10//gmetric4j-1.0.10.jar
gson/2.13.2//gson-2.13.2.jar
guava/33.4.8-jre//guava-33.4.8-jre.jar
-hadoop-aliyun/3.4.3//hadoop-aliyun-3.4.3.jar
-hadoop-annotations/3.4.3//hadoop-annotations-3.4.3.jar
-hadoop-aws/3.4.3//hadoop-aws-3.4.3.jar
-hadoop-azure-datalake/3.4.3//hadoop-azure-datalake-3.4.3.jar
-hadoop-azure/3.4.3//hadoop-azure-3.4.3.jar
-hadoop-client-api/3.4.3//hadoop-client-api-3.4.3.jar
-hadoop-client-runtime/3.4.3//hadoop-client-runtime-3.4.3.jar
-hadoop-cloud-storage/3.4.3//hadoop-cloud-storage-3.4.3.jar
-hadoop-huaweicloud/3.4.3//hadoop-huaweicloud-3.4.3.jar
+hadoop-aliyun/3.5.0//hadoop-aliyun-3.5.0.jar
+hadoop-annotations/3.5.0//hadoop-annotations-3.5.0.jar
+hadoop-aws/3.5.0//hadoop-aws-3.5.0.jar
+hadoop-azure-datalake/3.5.0//hadoop-azure-datalake-3.5.0.jar
+hadoop-azure/3.5.0//hadoop-azure-3.5.0.jar
+hadoop-client-api/3.5.0//hadoop-client-api-3.5.0.jar
+hadoop-client-runtime/3.5.0//hadoop-client-runtime-3.5.0.jar
+hadoop-cloud-storage/3.5.0//hadoop-cloud-storage-3.5.0.jar
+hadoop-gcp/3.5.0//hadoop-gcp-3.5.0.jar
Review Comment:
Unfortunately, I'm also not aware of how to test v3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SPARK-55657][BUILD] Bump Hadoop 3.5.0 RC0 [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #54448:
URL: https://github.com/apache/spark/pull/54448#discussion_r2870211200
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -68,16 +71,18 @@ gcs-connector/hadoop3-2.2.31/shaded/gcs-connector-hadoop3-2.2.31-shaded.jar
gmetric4j/1.0.10//gmetric4j-1.0.10.jar
gson/2.13.2//gson-2.13.2.jar
guava/33.4.8-jre//guava-33.4.8-jre.jar
-hadoop-aliyun/3.4.3//hadoop-aliyun-3.4.3.jar
-hadoop-annotations/3.4.3//hadoop-annotations-3.4.3.jar
-hadoop-aws/3.4.3//hadoop-aws-3.4.3.jar
-hadoop-azure-datalake/3.4.3//hadoop-azure-datalake-3.4.3.jar
-hadoop-azure/3.4.3//hadoop-azure-3.4.3.jar
-hadoop-client-api/3.4.3//hadoop-client-api-3.4.3.jar
-hadoop-client-runtime/3.4.3//hadoop-client-runtime-3.4.3.jar
-hadoop-cloud-storage/3.4.3//hadoop-cloud-storage-3.4.3.jar
-hadoop-huaweicloud/3.4.3//hadoop-huaweicloud-3.4.3.jar
+hadoop-aliyun/3.5.0//hadoop-aliyun-3.5.0.jar
+hadoop-annotations/3.5.0//hadoop-annotations-3.5.0.jar
+hadoop-aws/3.5.0//hadoop-aws-3.5.0.jar
+hadoop-azure-datalake/3.5.0//hadoop-azure-datalake-3.5.0.jar
+hadoop-azure/3.5.0//hadoop-azure-3.5.0.jar
+hadoop-client-api/3.5.0//hadoop-client-api-3.5.0.jar
+hadoop-client-runtime/3.5.0//hadoop-client-runtime-3.5.0.jar
+hadoop-cloud-storage/3.5.0//hadoop-cloud-storage-3.5.0.jar
+hadoop-gcp/3.5.0//hadoop-gcp-3.5.0.jar
Review Comment:
cc @cnauroth, am I doing right here? https://github.com/apache/spark/pull/54448/changes/55907cc488109d4a0420b5b6584f43e192113e51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SPARK-55657][BUILD] Bump Hadoop 3.5.0 RC0 [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #54448:
URL: https://github.com/apache/spark/pull/54448#issuecomment-3960793210
the new deps are likely transitive deps of hadoop-gcp and hadoop-tos, will investigate tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55657][BUILD] Bump Hadoop 3.5.0 [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #54448:
URL: https://github.com/apache/spark/pull/54448#discussion_r3038637529
##########
hadoop-cloud/pom.xml:
##########
@@ -197,30 +185,20 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-cos</artifactId>
</exclusion>
+ <!--
+ SPARK-55657: `hadoop-tos`is not a dependency of `hadoop-cloud-storage` 3.4.3,
Review Comment:
thanks, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55657][BUILD] Bump Hadoop 3.5.0 [spark]
Posted by "cnauroth (via GitHub)" <gi...@apache.org>.
cnauroth commented on code in PR #54448:
URL: https://github.com/apache/spark/pull/54448#discussion_r3029414315
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -68,16 +71,18 @@ gcs-connector/hadoop3-2.2.31/shaded/gcs-connector-hadoop3-2.2.31-shaded.jar
gmetric4j/1.0.10//gmetric4j-1.0.10.jar
gson/2.13.2//gson-2.13.2.jar
guava/33.4.8-jre//guava-33.4.8-jre.jar
-hadoop-aliyun/3.4.3//hadoop-aliyun-3.4.3.jar
-hadoop-annotations/3.4.3//hadoop-annotations-3.4.3.jar
-hadoop-aws/3.4.3//hadoop-aws-3.4.3.jar
-hadoop-azure-datalake/3.4.3//hadoop-azure-datalake-3.4.3.jar
-hadoop-azure/3.4.3//hadoop-azure-3.4.3.jar
-hadoop-client-api/3.4.3//hadoop-client-api-3.4.3.jar
-hadoop-client-runtime/3.4.3//hadoop-client-runtime-3.4.3.jar
-hadoop-cloud-storage/3.4.3//hadoop-cloud-storage-3.4.3.jar
-hadoop-huaweicloud/3.4.3//hadoop-huaweicloud-3.4.3.jar
+hadoop-aliyun/3.5.0//hadoop-aliyun-3.5.0.jar
+hadoop-annotations/3.5.0//hadoop-annotations-3.5.0.jar
+hadoop-aws/3.5.0//hadoop-aws-3.5.0.jar
+hadoop-azure-datalake/3.5.0//hadoop-azure-datalake-3.5.0.jar
+hadoop-azure/3.5.0//hadoop-azure-3.5.0.jar
+hadoop-client-api/3.5.0//hadoop-client-api-3.5.0.jar
+hadoop-client-runtime/3.5.0//hadoop-client-runtime-3.5.0.jar
+hadoop-cloud-storage/3.5.0//hadoop-cloud-storage-3.5.0.jar
+hadoop-gcp/3.5.0//hadoop-gcp-3.5.0.jar
Review Comment:
LGTM. Integration tests for hadoop-gcp (in Hadoop itself, not Spark) are discussed here:
https://github.com/apache/hadoop/blob/trunk/hadoop-cloud-storage-project/hadoop-gcp/src/site/markdown/tools/hadoop-gcp/testing.md
This will be visible on hadoop.apache.org once I complete the post-release site updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SPARK-55657][BUILD] Bump Hadoop 3.5.0 RC0 [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #54448:
URL: https://github.com/apache/spark/pull/54448#discussion_r2847124440
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -68,16 +71,18 @@ gcs-connector/hadoop3-2.2.31/shaded/gcs-connector-hadoop3-2.2.31-shaded.jar
gmetric4j/1.0.10//gmetric4j-1.0.10.jar
gson/2.13.2//gson-2.13.2.jar
guava/33.4.8-jre//guava-33.4.8-jre.jar
-hadoop-aliyun/3.4.2//hadoop-aliyun-3.4.2.jar
-hadoop-annotations/3.4.2//hadoop-annotations-3.4.2.jar
-hadoop-aws/3.4.2//hadoop-aws-3.4.2.jar
-hadoop-azure-datalake/3.4.2//hadoop-azure-datalake-3.4.2.jar
-hadoop-azure/3.4.2//hadoop-azure-3.4.2.jar
-hadoop-client-api/3.4.2//hadoop-client-api-3.4.2.jar
-hadoop-client-runtime/3.4.2//hadoop-client-runtime-3.4.2.jar
-hadoop-cloud-storage/3.4.2//hadoop-cloud-storage-3.4.2.jar
-hadoop-huaweicloud/3.4.2//hadoop-huaweicloud-3.4.2.jar
-hadoop-shaded-guava/1.4.0//hadoop-shaded-guava-1.4.0.jar
+hadoop-aliyun/3.5.0//hadoop-aliyun-3.5.0.jar
+hadoop-annotations/3.5.0//hadoop-annotations-3.5.0.jar
+hadoop-aws/3.5.0//hadoop-aws-3.5.0.jar
+hadoop-azure-datalake/3.5.0//hadoop-azure-datalake-3.5.0.jar
+hadoop-azure/3.5.0//hadoop-azure-3.5.0.jar
+hadoop-client-api/3.5.0//hadoop-client-api-3.5.0.jar
+hadoop-client-runtime/3.5.0//hadoop-client-runtime-3.5.0.jar
+hadoop-cloud-storage/3.5.0//hadoop-cloud-storage-3.5.0.jar
+hadoop-gcp/3.5.0//hadoop-gcp-3.5.0.jar
+hadoop-huaweicloud/3.5.0//hadoop-huaweicloud-3.5.0.jar
+hadoop-shaded-guava/1.5.0//hadoop-shaded-guava-1.5.0.jar
+hadoop-tos/3.5.0//hadoop-tos-3.5.0.jar
Review Comment:
it's a new cloud vendor connector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SPARK-55657][BUILD] Bump Hadoop 3.5.0 RC0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #54448:
URL: https://github.com/apache/spark/pull/54448#discussion_r2854337702
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -1,14 +1,16 @@
+HdrHistogram/2.1.12//HdrHistogram-2.1.12.jar
Review Comment:
Is this a new dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SPARK-55657][BUILD] Bump Hadoop 3.5.0 RC0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54448:
URL: https://github.com/apache/spark/pull/54448#issuecomment-3952804222
Yay! Hadoop 3.5. Thank you for testing 3.5.0 RC, @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SPARK-55657][BUILD] Bump Hadoop 3.5.0 RC0 [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #54448:
URL: https://github.com/apache/spark/pull/54448#discussion_r2870204530
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -116,6 +121,7 @@ jakarta.ws.rs-api/3.1.0//jakarta.ws.rs-api-3.1.0.jar
jakarta.xml.bind-api/4.0.2//jakarta.xml.bind-api-4.0.2.jar
janino/3.1.9//janino-3.1.9.jar
java-diff-utils/4.16//java-diff-utils-4.16.jar
+java-trace-api/0.2.11-beta//java-trace-api-0.2.11-beta.jar
Review Comment:
I raised a conversation in the Hadoop community https://github.com/apache/hadoop/pull/7205#issuecomment-3981600333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55657][BUILD] Bump Hadoop 3.5.0 [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #54448:
URL: https://github.com/apache/spark/pull/54448#issuecomment-4190609322
@cnauroth thank you for the review.
cc @sarutak @LuciferYang could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55657][BUILD] Bump Hadoop 3.5.0 [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on code in PR #54448:
URL: https://github.com/apache/spark/pull/54448#discussion_r3038195459
##########
hadoop-cloud/pom.xml:
##########
@@ -197,30 +185,20 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-cos</artifactId>
</exclusion>
+ <!--
+ SPARK-55657: `hadoop-tos`is not a dependency of `hadoop-cloud-storage` 3.4.3,
Review Comment:
nit: white space before `is`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55657][BUILD] Bump Hadoop 3.5.0 [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #54448:
URL: https://github.com/apache/spark/pull/54448#discussion_r3038635039
##########
hadoop-cloud/pom.xml:
##########
@@ -197,30 +185,20 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-cos</artifactId>
</exclusion>
+ <!--
+ SPARK-55657: `hadoop-tos`is not a dependency of `hadoop-cloud-storage` 3.4.3,
Review Comment:
```suggestion
SPARK-55657: `hadoop-tos` is not a dependency of `hadoop-cloud-storage` 3.4.3,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55657][BUILD] Bump Hadoop 3.5.0 [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #54448:
URL: https://github.com/apache/spark/pull/54448#issuecomment-4191223589
merged to master, thanks all for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55657][BUILD] Bump Hadoop 3.5.0 [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 closed pull request #54448: [SPARK-55657][BUILD] Bump Hadoop 3.5.0
URL: https://github.com/apache/spark/pull/54448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SPARK-55657][BUILD] Bump Hadoop 3.5.0 RC0 [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #54448:
URL: https://github.com/apache/spark/pull/54448#discussion_r2854340543
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -116,6 +121,7 @@ jakarta.ws.rs-api/3.1.0//jakarta.ws.rs-api-3.1.0.jar
jakarta.xml.bind-api/4.0.2//jakarta.xml.bind-api-4.0.2.jar
janino/3.1.9//janino-3.1.9.jar
java-diff-utils/4.16//java-diff-utils-4.16.jar
+java-trace-api/0.2.11-beta//java-trace-api-0.2.11-beta.jar
Review Comment:
This looks like a test dependency, does Apache Spark use this new dependency `java-trace-api:0.2.11-beta`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [WIP][SPARK-55657][BUILD] Bump Hadoop 3.5.0 RC0 [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #54448:
URL: https://github.com/apache/spark/pull/54448#discussion_r2870211200
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -68,16 +71,18 @@ gcs-connector/hadoop3-2.2.31/shaded/gcs-connector-hadoop3-2.2.31-shaded.jar
gmetric4j/1.0.10//gmetric4j-1.0.10.jar
gson/2.13.2//gson-2.13.2.jar
guava/33.4.8-jre//guava-33.4.8-jre.jar
-hadoop-aliyun/3.4.3//hadoop-aliyun-3.4.3.jar
-hadoop-annotations/3.4.3//hadoop-annotations-3.4.3.jar
-hadoop-aws/3.4.3//hadoop-aws-3.4.3.jar
-hadoop-azure-datalake/3.4.3//hadoop-azure-datalake-3.4.3.jar
-hadoop-azure/3.4.3//hadoop-azure-3.4.3.jar
-hadoop-client-api/3.4.3//hadoop-client-api-3.4.3.jar
-hadoop-client-runtime/3.4.3//hadoop-client-runtime-3.4.3.jar
-hadoop-cloud-storage/3.4.3//hadoop-cloud-storage-3.4.3.jar
-hadoop-huaweicloud/3.4.3//hadoop-huaweicloud-3.4.3.jar
+hadoop-aliyun/3.5.0//hadoop-aliyun-3.5.0.jar
+hadoop-annotations/3.5.0//hadoop-annotations-3.5.0.jar
+hadoop-aws/3.5.0//hadoop-aws-3.5.0.jar
+hadoop-azure-datalake/3.5.0//hadoop-azure-datalake-3.5.0.jar
+hadoop-azure/3.5.0//hadoop-azure-3.5.0.jar
+hadoop-client-api/3.5.0//hadoop-client-api-3.5.0.jar
+hadoop-client-runtime/3.5.0//hadoop-client-runtime-3.5.0.jar
+hadoop-cloud-storage/3.5.0//hadoop-cloud-storage-3.5.0.jar
+hadoop-gcp/3.5.0//hadoop-gcp-3.5.0.jar
Review Comment:
cc @cnauroth, am I doing right here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55657][BUILD] Bump Hadoop 3.5.0 [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on code in PR #54448:
URL: https://github.com/apache/spark/pull/54448#discussion_r3025519654
##########
dev/deps/spark-deps-hadoop-3-hive-2.3:
##########
@@ -116,6 +121,7 @@ jakarta.ws.rs-api/3.1.0//jakarta.ws.rs-api-3.1.0.jar
jakarta.xml.bind-api/4.0.2//jakarta.xml.bind-api-4.0.2.jar
janino/3.1.9//janino-3.1.9.jar
java-diff-utils/4.16//java-diff-utils-4.16.jar
+java-trace-api/0.2.11-beta//java-trace-api-0.2.11-beta.jar
Review Comment:
they are new runtime dependencies used by `aliyun-java-sdk` for tracing.
Hadoop 3.5.0 RC2 passes vote, no changes for `hadoop-aliyun`, it still pulls these dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org