[GitHub] rhtyd opened a new pull request #2904: agent: Fixes #2899 on shutdown don't allow server reconnection

[GitBox <gi...@apache.org>]

rhtyd opened a new pull request #2904: agent: Fixes #2899 on shutdown don't allow server reconnection
URL: https://github.com/apache/cloudstack/pull/2904
 
 
   When agent is stopped, don't allow reconnection. Previously this would
   send a shutdown command to the management server which would put the
   host state to Disconnected but then agent's reconnection logic may kick
   in sometimes which would connect the agent to the management server
   but then the agent process would terminate causing the host to be
   put in Alert state (due to ping timeout or it waiting too long).
   
   This fixes the issue by ensuring that when the agent is stopped, it
   does not reconnect to the management server.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
   - [ ] Breaking change (fix or feature that would cause existing functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [x] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ## How Has This Been Tested?
   
   With a KVM env, just stop the kvm agent the host previously was put in Alert state sometimes. Now, it is put in disconnected state.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services