[jira] [Commented] (FELIX-4906) Changes in symlinked bundles not detected with NIO2 WatcherScanner

["Richard Vigniel (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383839#comment-15383839 ] 

Richard Vigniel commented on FELIX-4906:
----------------------------------------

Hi
symlinks do not fully work yet on 3.5.2.

if a new link on a bundle appears, it's ok.

but if the linked file is updated ( config file modified for example ), the change is not detected.

everything was ok without NIO.


in the code, there is some NOFOLLOW_LINKS options that may prevents change detection on symlinked files.
https://svn.apache.org/repos/asf/felix/trunk/fileinstall/src/main/java/org/apache/felix/fileinstall/internal/Watcher.java

{code}
                    if (kind == ENTRY_CREATE) {
                        if (Files.isDirectory(child, NOFOLLOW_LINKS)) {

                            // if directory is created, and watching recursively, then
                            // register it and its sub-directories
                            Files.walkFileTree(child, new FilteringFileVisitor());
                        } else if (Files.isRegularFile(child, NOFOLLOW_LINKS)) {
                            scan(child);
                        }
                    } else if (kind == ENTRY_MODIFY) {
                        if (Files.isRegularFile(child, NOFOLLOW_LINKS)) {
                            scan(child);
                        }
                    } else if (kind == ENTRY_DELETE) {
                        unscan(child);
                    }
  
{code}



> Changes in symlinked bundles not detected with NIO2 WatcherScanner
> ------------------------------------------------------------------
>
>                 Key: FELIX-4906
>                 URL: https://issues.apache.org/jira/browse/FELIX-4906
>             Project: Felix
>          Issue Type: Bug
>          Components: File Install
>    Affects Versions: fileinstall-3.4.0, fileinstall-3.4.2, fileinstall-3.5.0
>            Reporter: Tim Hull
>            Assignee: Guillaume Nodet
>             Fix For: fileinstall-3.5.2
>
>
> Since the new NIO2 WatcherScanner was introduced as part of FileInstall 3.4.0, I've noticed that FileInstall no longer detects changes to files symbolically linked to from the deploy directory. Also, there may be additional issues with network-mounted directories as well. These can be worked around by setting the felix.fileinstall.disableNio2 option to true, though this isn't ideal.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)