You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spark.apache.org by Nicholas Chammas <ni...@gmail.com> on 2014/12/17 03:02:03 UTC
Re: Scala's Jenkins setup looks neat
News flash!
>From the latest version of the GitHub API
<https://developer.github.com/v3/repos/statuses/>:
Note that the repo:status OAuth scope
<https://developer.github.com/v3/oauth/#scopes> grants targeted access to
Statuses *without* also granting access to repository code, while the repo
scope grants permission to code as well as statuses.
As I understand it, ASF Infra has said no in the past to granting access to
statuses because it also granted push access.
If so, this no longer appears to be the case.
1) Did I understand correctly and 2) should I open a new request with ASF
Infra to give us OAuth keys with repo:status access?
Nick
On Sat Sep 06 2014 at 1:29:53 PM Nicholas Chammas <
nicholas.chammas@gmail.com> wrote:
Aww, that's a bummer...
>
>
> On Sat, Sep 6, 2014 at 1:10 PM, Reynold Xin <rx...@databricks.com> wrote:
>
>> that would require github hooks permission and unfortunately asf infra
>> wouldn't allow that.
>>
>> Maybe they will change their mind one day, but so far we asked about this
>> and the answer has been no for security reasons.
>>
>> On Saturday, September 6, 2014, Nicholas Chammas <
>> nicholas.chammas@gmail.com> wrote:
>>
>>> After reading Erik's email, I found this Scala PR
>>> <https://github.com/scala/scala/pull/3963> and immediately noticed a few
>>> cool things:
>>>
>>> - Jenkins is hooked directly into GitHub somehow, so you get the "All
>>> is
>>> well" message in the merge status window, presumably based on the
>>> last test
>>> status
>>> - Jenkins is also tagging the PR based on its test status or need for
>>> review
>>> - Jenkins is also tagging the PR for a specific milestone
>>>
>>> Do any of these things make sense to add to our setup? Or perhaps
>>> something
>>> inspired by these features?
>>>
>>> Nick
>>>
>>
>
Re: Scala's Jenkins setup looks neat
Posted by Nicholas Chammas <ni...@gmail.com>.
Shot down again.
<https://issues.apache.org/jira/browse/INFRA-7367?focusedCommentId=14249382&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14249382>
On Tue Dec 16 2014 at 9:41:39 PM Nicholas Chammas <
nicholas.chammas@gmail.com> wrote:
> I see. That’s a separate discussion about closing PRs vs. just updating
> the CI status on individual commits.
>
> I’ll comment on INFRA-7367
> <https://issues.apache.org/jira/browse/INFRA-7367>.
>
> Nick
>
>
> On Tue Dec 16 2014 at 9:38:04 PM Reynold Xin <rx...@databricks.com> wrote:
>
>> This was the ticket: https://issues.apache.org/jira/browse/INFRA-7918
>>
>> On Tue, Dec 16, 2014 at 6:23 PM, Nicholas Chammas <
>> nicholas.chammas@gmail.com> wrote:
>>>
>>> Actually, reading through the existing issue opened for this
>>> <https://issues.apache.org/jira/browse/INFRA-7367> back in February, I
>>> don’t see any explanation from ASF Infra as to why they won’t grant
>>> permission against the Status API. They just recommended transitioning to
>>> the Apache Jenkins instance.
>>>
>>> Reynold/Patrick, was there any discussion elsewhere about this, or
>>> should I just go ahead and try reopening the issue with the appropriate
>>> explanation?
>>>
>>> Nick
>>>
>>>
>>> On Tue Dec 16 2014 at 9:10:59 PM Patrick Wendell <pw...@gmail.com>
>>> wrote:
>>>
>>>> Yeah you can do it - just make sure they understand it is a new
>>>> feature so we're asking them to revisit it. They looked at it in the
>>>> past and they concluded they couldn't give us access without giving us
>>>> push access.
>>>>
>>>> - Patrick
>>>>
>>>> On Tue, Dec 16, 2014 at 6:06 PM, Reynold Xin <rx...@databricks.com>
>>>> wrote:
>>>> > It's worth trying :)
>>>> >
>>>> >
>>>> > On Tue, Dec 16, 2014 at 6:02 PM, Nicholas Chammas <
>>>> > nicholas.chammas@gmail.com> wrote:
>>>> >>
>>>> >> News flash!
>>>> >>
>>>> >> From the latest version of the GitHub API
>>>> >> <https://developer.github.com/v3/repos/statuses/>:
>>>> >>
>>>> >> Note that the repo:status OAuth scope
>>>> >> <https://developer.github.com/v3/oauth/#scopes> grants targeted
>>>> access to
>>>> >> Statuses *without* also granting access to repository code, while
>>>> the repo
>>>> >> scope grants permission to code as well as statuses.
>>>> >>
>>>> >> As I understand it, ASF Infra has said no in the past to granting
>>>> access
>>>> >> to statuses because it also granted push access.
>>>> >>
>>>> >> If so, this no longer appears to be the case.
>>>> >>
>>>> >> 1) Did I understand correctly and 2) should I open a new request
>>>> with ASF
>>>> >> Infra to give us OAuth keys with repo:status access?
>>>> >>
>>>> >> Nick
>>>> >>
>>>> >> On Sat Sep 06 2014 at 1:29:53 PM Nicholas Chammas <
>>>> >> nicholas.chammas@gmail.com> wrote:
>>>> >>
>>>> >> Aww, that's a bummer...
>>>> >>>
>>>> >>>
>>>> >>> On Sat, Sep 6, 2014 at 1:10 PM, Reynold Xin <rx...@databricks.com>
>>>> wrote:
>>>> >>>
>>>> >>>> that would require github hooks permission and unfortunately asf
>>>> infra
>>>> >>>> wouldn't allow that.
>>>> >>>>
>>>> >>>> Maybe they will change their mind one day, but so far we asked
>>>> about
>>>> >>>> this and the answer has been no for security reasons.
>>>> >>>>
>>>> >>>> On Saturday, September 6, 2014, Nicholas Chammas <
>>>> >>>> nicholas.chammas@gmail.com> wrote:
>>>> >>>>
>>>> >>>>> After reading Erik's email, I found this Scala PR
>>>> >>>>> <https://github.com/scala/scala/pull/3963> and immediately
>>>> noticed a
>>>> >>>>> few
>>>> >>>>> cool things:
>>>> >>>>>
>>>> >>>>> - Jenkins is hooked directly into GitHub somehow, so you get
>>>> the
>>>> >>>>> "All is
>>>> >>>>> well" message in the merge status window, presumably based on
>>>> the
>>>> >>>>> last test
>>>> >>>>> status
>>>> >>>>> - Jenkins is also tagging the PR based on its test status or
>>>> need for
>>>> >>>>> review
>>>> >>>>> - Jenkins is also tagging the PR for a specific milestone
>>>> >>>>>
>>>> >>>>> Do any of these things make sense to add to our setup? Or perhaps
>>>> >>>>> something
>>>> >>>>> inspired by these features?
>>>> >>>>>
>>>> >>>>> Nick
>>>> >>>>>
>>>> >>>>
>>>> >>>
>>>> >>
>>>>
>>>
Re: Scala's Jenkins setup looks neat
Posted by Nicholas Chammas <ni...@gmail.com>.
I see. That’s a separate discussion about closing PRs vs. just updating the
CI status on individual commits.
I’ll comment on INFRA-7367
<https://issues.apache.org/jira/browse/INFRA-7367>.
Nick
On Tue Dec 16 2014 at 9:38:04 PM Reynold Xin <rx...@databricks.com> wrote:
> This was the ticket: https://issues.apache.org/jira/browse/INFRA-7918
>
> On Tue, Dec 16, 2014 at 6:23 PM, Nicholas Chammas <
> nicholas.chammas@gmail.com> wrote:
>>
>> Actually, reading through the existing issue opened for this
>> <https://issues.apache.org/jira/browse/INFRA-7367> back in February, I
>> don’t see any explanation from ASF Infra as to why they won’t grant
>> permission against the Status API. They just recommended transitioning to
>> the Apache Jenkins instance.
>>
>> Reynold/Patrick, was there any discussion elsewhere about this, or should
>> I just go ahead and try reopening the issue with the appropriate
>> explanation?
>>
>> Nick
>>
>>
>> On Tue Dec 16 2014 at 9:10:59 PM Patrick Wendell <pw...@gmail.com>
>> wrote:
>>
>>> Yeah you can do it - just make sure they understand it is a new
>>> feature so we're asking them to revisit it. They looked at it in the
>>> past and they concluded they couldn't give us access without giving us
>>> push access.
>>>
>>> - Patrick
>>>
>>> On Tue, Dec 16, 2014 at 6:06 PM, Reynold Xin <rx...@databricks.com>
>>> wrote:
>>> > It's worth trying :)
>>> >
>>> >
>>> > On Tue, Dec 16, 2014 at 6:02 PM, Nicholas Chammas <
>>> > nicholas.chammas@gmail.com> wrote:
>>> >>
>>> >> News flash!
>>> >>
>>> >> From the latest version of the GitHub API
>>> >> <https://developer.github.com/v3/repos/statuses/>:
>>> >>
>>> >> Note that the repo:status OAuth scope
>>> >> <https://developer.github.com/v3/oauth/#scopes> grants targeted
>>> access to
>>> >> Statuses *without* also granting access to repository code, while the
>>> repo
>>> >> scope grants permission to code as well as statuses.
>>> >>
>>> >> As I understand it, ASF Infra has said no in the past to granting
>>> access
>>> >> to statuses because it also granted push access.
>>> >>
>>> >> If so, this no longer appears to be the case.
>>> >>
>>> >> 1) Did I understand correctly and 2) should I open a new request with
>>> ASF
>>> >> Infra to give us OAuth keys with repo:status access?
>>> >>
>>> >> Nick
>>> >>
>>> >> On Sat Sep 06 2014 at 1:29:53 PM Nicholas Chammas <
>>> >> nicholas.chammas@gmail.com> wrote:
>>> >>
>>> >> Aww, that's a bummer...
>>> >>>
>>> >>>
>>> >>> On Sat, Sep 6, 2014 at 1:10 PM, Reynold Xin <rx...@databricks.com>
>>> wrote:
>>> >>>
>>> >>>> that would require github hooks permission and unfortunately asf
>>> infra
>>> >>>> wouldn't allow that.
>>> >>>>
>>> >>>> Maybe they will change their mind one day, but so far we asked about
>>> >>>> this and the answer has been no for security reasons.
>>> >>>>
>>> >>>> On Saturday, September 6, 2014, Nicholas Chammas <
>>> >>>> nicholas.chammas@gmail.com> wrote:
>>> >>>>
>>> >>>>> After reading Erik's email, I found this Scala PR
>>> >>>>> <https://github.com/scala/scala/pull/3963> and immediately
>>> noticed a
>>> >>>>> few
>>> >>>>> cool things:
>>> >>>>>
>>> >>>>> - Jenkins is hooked directly into GitHub somehow, so you get the
>>> >>>>> "All is
>>> >>>>> well" message in the merge status window, presumably based on
>>> the
>>> >>>>> last test
>>> >>>>> status
>>> >>>>> - Jenkins is also tagging the PR based on its test status or
>>> need for
>>> >>>>> review
>>> >>>>> - Jenkins is also tagging the PR for a specific milestone
>>> >>>>>
>>> >>>>> Do any of these things make sense to add to our setup? Or perhaps
>>> >>>>> something
>>> >>>>> inspired by these features?
>>> >>>>>
>>> >>>>> Nick
>>> >>>>>
>>> >>>>
>>> >>>
>>> >>
>>>
>>
Re: Scala's Jenkins setup looks neat
Posted by Reynold Xin <rx...@databricks.com>.
This was the ticket: https://issues.apache.org/jira/browse/INFRA-7918
On Tue, Dec 16, 2014 at 6:23 PM, Nicholas Chammas <
nicholas.chammas@gmail.com> wrote:
>
> Actually, reading through the existing issue opened for this
> <https://issues.apache.org/jira/browse/INFRA-7367> back in February, I
> don’t see any explanation from ASF Infra as to why they won’t grant
> permission against the Status API. They just recommended transitioning to
> the Apache Jenkins instance.
>
> Reynold/Patrick, was there any discussion elsewhere about this, or should
> I just go ahead and try reopening the issue with the appropriate
> explanation?
>
> Nick
>
>
> On Tue Dec 16 2014 at 9:10:59 PM Patrick Wendell <pw...@gmail.com>
> wrote:
>
>> Yeah you can do it - just make sure they understand it is a new
>> feature so we're asking them to revisit it. They looked at it in the
>> past and they concluded they couldn't give us access without giving us
>> push access.
>>
>> - Patrick
>>
>> On Tue, Dec 16, 2014 at 6:06 PM, Reynold Xin <rx...@databricks.com> wrote:
>> > It's worth trying :)
>> >
>> >
>> > On Tue, Dec 16, 2014 at 6:02 PM, Nicholas Chammas <
>> > nicholas.chammas@gmail.com> wrote:
>> >>
>> >> News flash!
>> >>
>> >> From the latest version of the GitHub API
>> >> <https://developer.github.com/v3/repos/statuses/>:
>> >>
>> >> Note that the repo:status OAuth scope
>> >> <https://developer.github.com/v3/oauth/#scopes> grants targeted
>> access to
>> >> Statuses *without* also granting access to repository code, while the
>> repo
>> >> scope grants permission to code as well as statuses.
>> >>
>> >> As I understand it, ASF Infra has said no in the past to granting
>> access
>> >> to statuses because it also granted push access.
>> >>
>> >> If so, this no longer appears to be the case.
>> >>
>> >> 1) Did I understand correctly and 2) should I open a new request with
>> ASF
>> >> Infra to give us OAuth keys with repo:status access?
>> >>
>> >> Nick
>> >>
>> >> On Sat Sep 06 2014 at 1:29:53 PM Nicholas Chammas <
>> >> nicholas.chammas@gmail.com> wrote:
>> >>
>> >> Aww, that's a bummer...
>> >>>
>> >>>
>> >>> On Sat, Sep 6, 2014 at 1:10 PM, Reynold Xin <rx...@databricks.com>
>> wrote:
>> >>>
>> >>>> that would require github hooks permission and unfortunately asf
>> infra
>> >>>> wouldn't allow that.
>> >>>>
>> >>>> Maybe they will change their mind one day, but so far we asked about
>> >>>> this and the answer has been no for security reasons.
>> >>>>
>> >>>> On Saturday, September 6, 2014, Nicholas Chammas <
>> >>>> nicholas.chammas@gmail.com> wrote:
>> >>>>
>> >>>>> After reading Erik's email, I found this Scala PR
>> >>>>> <https://github.com/scala/scala/pull/3963> and immediately noticed
>> a
>> >>>>> few
>> >>>>> cool things:
>> >>>>>
>> >>>>> - Jenkins is hooked directly into GitHub somehow, so you get the
>> >>>>> "All is
>> >>>>> well" message in the merge status window, presumably based on the
>> >>>>> last test
>> >>>>> status
>> >>>>> - Jenkins is also tagging the PR based on its test status or
>> need for
>> >>>>> review
>> >>>>> - Jenkins is also tagging the PR for a specific milestone
>> >>>>>
>> >>>>> Do any of these things make sense to add to our setup? Or perhaps
>> >>>>> something
>> >>>>> inspired by these features?
>> >>>>>
>> >>>>> Nick
>> >>>>>
>> >>>>
>> >>>
>> >>
>>
>
Re: Scala's Jenkins setup looks neat
Posted by Nicholas Chammas <ni...@gmail.com>.
Actually, reading through the existing issue opened for this
<https://issues.apache.org/jira/browse/INFRA-7367> back in February, I
don’t see any explanation from ASF Infra as to why they won’t grant
permission against the Status API. They just recommended transitioning to
the Apache Jenkins instance.
Reynold/Patrick, was there any discussion elsewhere about this, or should I
just go ahead and try reopening the issue with the appropriate explanation?
Nick
On Tue Dec 16 2014 at 9:10:59 PM Patrick Wendell <pw...@gmail.com> wrote:
> Yeah you can do it - just make sure they understand it is a new
> feature so we're asking them to revisit it. They looked at it in the
> past and they concluded they couldn't give us access without giving us
> push access.
>
> - Patrick
>
> On Tue, Dec 16, 2014 at 6:06 PM, Reynold Xin <rx...@databricks.com> wrote:
> > It's worth trying :)
> >
> >
> > On Tue, Dec 16, 2014 at 6:02 PM, Nicholas Chammas <
> > nicholas.chammas@gmail.com> wrote:
> >>
> >> News flash!
> >>
> >> From the latest version of the GitHub API
> >> <https://developer.github.com/v3/repos/statuses/>:
> >>
> >> Note that the repo:status OAuth scope
> >> <https://developer.github.com/v3/oauth/#scopes> grants targeted access
> to
> >> Statuses *without* also granting access to repository code, while the
> repo
> >> scope grants permission to code as well as statuses.
> >>
> >> As I understand it, ASF Infra has said no in the past to granting access
> >> to statuses because it also granted push access.
> >>
> >> If so, this no longer appears to be the case.
> >>
> >> 1) Did I understand correctly and 2) should I open a new request with
> ASF
> >> Infra to give us OAuth keys with repo:status access?
> >>
> >> Nick
> >>
> >> On Sat Sep 06 2014 at 1:29:53 PM Nicholas Chammas <
> >> nicholas.chammas@gmail.com> wrote:
> >>
> >> Aww, that's a bummer...
> >>>
> >>>
> >>> On Sat, Sep 6, 2014 at 1:10 PM, Reynold Xin <rx...@databricks.com>
> wrote:
> >>>
> >>>> that would require github hooks permission and unfortunately asf infra
> >>>> wouldn't allow that.
> >>>>
> >>>> Maybe they will change their mind one day, but so far we asked about
> >>>> this and the answer has been no for security reasons.
> >>>>
> >>>> On Saturday, September 6, 2014, Nicholas Chammas <
> >>>> nicholas.chammas@gmail.com> wrote:
> >>>>
> >>>>> After reading Erik's email, I found this Scala PR
> >>>>> <https://github.com/scala/scala/pull/3963> and immediately noticed a
> >>>>> few
> >>>>> cool things:
> >>>>>
> >>>>> - Jenkins is hooked directly into GitHub somehow, so you get the
> >>>>> "All is
> >>>>> well" message in the merge status window, presumably based on the
> >>>>> last test
> >>>>> status
> >>>>> - Jenkins is also tagging the PR based on its test status or need
> for
> >>>>> review
> >>>>> - Jenkins is also tagging the PR for a specific milestone
> >>>>>
> >>>>> Do any of these things make sense to add to our setup? Or perhaps
> >>>>> something
> >>>>> inspired by these features?
> >>>>>
> >>>>> Nick
> >>>>>
> >>>>
> >>>
> >>
>
Re: Scala's Jenkins setup looks neat
Posted by Patrick Wendell <pw...@gmail.com>.
Yeah you can do it - just make sure they understand it is a new
feature so we're asking them to revisit it. They looked at it in the
past and they concluded they couldn't give us access without giving us
push access.
- Patrick
On Tue, Dec 16, 2014 at 6:06 PM, Reynold Xin <rx...@databricks.com> wrote:
> It's worth trying :)
>
>
> On Tue, Dec 16, 2014 at 6:02 PM, Nicholas Chammas <
> nicholas.chammas@gmail.com> wrote:
>>
>> News flash!
>>
>> From the latest version of the GitHub API
>> <https://developer.github.com/v3/repos/statuses/>:
>>
>> Note that the repo:status OAuth scope
>> <https://developer.github.com/v3/oauth/#scopes> grants targeted access to
>> Statuses *without* also granting access to repository code, while the repo
>> scope grants permission to code as well as statuses.
>>
>> As I understand it, ASF Infra has said no in the past to granting access
>> to statuses because it also granted push access.
>>
>> If so, this no longer appears to be the case.
>>
>> 1) Did I understand correctly and 2) should I open a new request with ASF
>> Infra to give us OAuth keys with repo:status access?
>>
>> Nick
>>
>> On Sat Sep 06 2014 at 1:29:53 PM Nicholas Chammas <
>> nicholas.chammas@gmail.com> wrote:
>>
>> Aww, that's a bummer...
>>>
>>>
>>> On Sat, Sep 6, 2014 at 1:10 PM, Reynold Xin <rx...@databricks.com> wrote:
>>>
>>>> that would require github hooks permission and unfortunately asf infra
>>>> wouldn't allow that.
>>>>
>>>> Maybe they will change their mind one day, but so far we asked about
>>>> this and the answer has been no for security reasons.
>>>>
>>>> On Saturday, September 6, 2014, Nicholas Chammas <
>>>> nicholas.chammas@gmail.com> wrote:
>>>>
>>>>> After reading Erik's email, I found this Scala PR
>>>>> <https://github.com/scala/scala/pull/3963> and immediately noticed a
>>>>> few
>>>>> cool things:
>>>>>
>>>>> - Jenkins is hooked directly into GitHub somehow, so you get the
>>>>> "All is
>>>>> well" message in the merge status window, presumably based on the
>>>>> last test
>>>>> status
>>>>> - Jenkins is also tagging the PR based on its test status or need for
>>>>> review
>>>>> - Jenkins is also tagging the PR for a specific milestone
>>>>>
>>>>> Do any of these things make sense to add to our setup? Or perhaps
>>>>> something
>>>>> inspired by these features?
>>>>>
>>>>> Nick
>>>>>
>>>>
>>>
>>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@spark.apache.org
For additional commands, e-mail: dev-help@spark.apache.org
Re: Scala's Jenkins setup looks neat
Posted by Reynold Xin <rx...@databricks.com>.
It's worth trying :)
On Tue, Dec 16, 2014 at 6:02 PM, Nicholas Chammas <
nicholas.chammas@gmail.com> wrote:
>
> News flash!
>
> From the latest version of the GitHub API
> <https://developer.github.com/v3/repos/statuses/>:
>
> Note that the repo:status OAuth scope
> <https://developer.github.com/v3/oauth/#scopes> grants targeted access to
> Statuses *without* also granting access to repository code, while the repo
> scope grants permission to code as well as statuses.
>
> As I understand it, ASF Infra has said no in the past to granting access
> to statuses because it also granted push access.
>
> If so, this no longer appears to be the case.
>
> 1) Did I understand correctly and 2) should I open a new request with ASF
> Infra to give us OAuth keys with repo:status access?
>
> Nick
>
> On Sat Sep 06 2014 at 1:29:53 PM Nicholas Chammas <
> nicholas.chammas@gmail.com> wrote:
>
> Aww, that's a bummer...
>>
>>
>> On Sat, Sep 6, 2014 at 1:10 PM, Reynold Xin <rx...@databricks.com> wrote:
>>
>>> that would require github hooks permission and unfortunately asf infra
>>> wouldn't allow that.
>>>
>>> Maybe they will change their mind one day, but so far we asked about
>>> this and the answer has been no for security reasons.
>>>
>>> On Saturday, September 6, 2014, Nicholas Chammas <
>>> nicholas.chammas@gmail.com> wrote:
>>>
>>>> After reading Erik's email, I found this Scala PR
>>>> <https://github.com/scala/scala/pull/3963> and immediately noticed a
>>>> few
>>>> cool things:
>>>>
>>>> - Jenkins is hooked directly into GitHub somehow, so you get the
>>>> "All is
>>>> well" message in the merge status window, presumably based on the
>>>> last test
>>>> status
>>>> - Jenkins is also tagging the PR based on its test status or need for
>>>> review
>>>> - Jenkins is also tagging the PR for a specific milestone
>>>>
>>>> Do any of these things make sense to add to our setup? Or perhaps
>>>> something
>>>> inspired by these features?
>>>>
>>>> Nick
>>>>
>>>
>>
>