You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by xiaojian zhou <zh...@gmail.com> on 2015/10/29 19:02:08 UTC
Review Request 39763: need to add expected exception for the
exception test
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39763/
-----------------------------------------------------------
Review request for geode and Dan Smith.
Bugs: GEODE-513
https://issues.apache.org/jira/browse/GEODE-513
Repository: geode
Description
-------
The test is to trigger some exceptions. So for these exception should add expected exception to resolve the suspect strings.
Diffs
-----
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRClientServerRegionFunctionExecutionSingleHopDUnitTest.java c0b0d3c
Diff: https://reviews.apache.org/r/39763/diff/
Testing
-------
the dunit test case
Thanks,
xiaojian zhou
Re: Review Request 39763: need to add expected exception for the
exception test
Posted by xiaojian zhou <zh...@gmail.com>.
> On Oct. 29, 2015, 9:01 p.m., Darrel Schneider wrote:
> > gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRClientServerRegionFunctionExecutionSingleHopDUnitTest.java, line 257
> > <https://reviews.apache.org/r/39763/diff/1/?file=1112263#file1112263line257>
> >
> > Why are these exceptions expected?
> > The only exception I see this test throwing is:
> > throw new FunctionInvocationTargetException(
> > "I have been thrown from TestFunction");
> >
> > So why would we see IOException and SocketException?
The test will throw an FunctionInvocationTargetException() at server, and caused the client thought the endpont is crashed. Here is the error msg:
Redundant subscription endpoint gzhou-t440p.vmware.com:25790 crashed. Scheduling recovery.
So the disconnecting is expected.
- xiaojian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39763/#review104474
-----------------------------------------------------------
On Oct. 29, 2015, 6:02 p.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39763/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2015, 6:02 p.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-513
> https://issues.apache.org/jira/browse/GEODE-513
>
>
> Repository: geode
>
>
> Description
> -------
>
> The test is to trigger some exceptions. So for these exception should add expected exception to resolve the suspect strings.
>
>
> Diffs
> -----
>
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRClientServerRegionFunctionExecutionSingleHopDUnitTest.java c0b0d3c
>
> Diff: https://reviews.apache.org/r/39763/diff/
>
>
> Testing
> -------
>
> the dunit test case
>
>
> Thanks,
>
> xiaojian zhou
>
>
Re: Review Request 39763: need to add expected exception for the
exception test
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39763/#review104474
-----------------------------------------------------------
gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRClientServerRegionFunctionExecutionSingleHopDUnitTest.java (line 257)
<https://reviews.apache.org/r/39763/#comment162729>
Why are these exceptions expected?
The only exception I see this test throwing is:
throw new FunctionInvocationTargetException(
"I have been thrown from TestFunction");
So why would we see IOException and SocketException?
- Darrel Schneider
On Oct. 29, 2015, 11:02 a.m., xiaojian zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39763/
> -----------------------------------------------------------
>
> (Updated Oct. 29, 2015, 11:02 a.m.)
>
>
> Review request for geode and Dan Smith.
>
>
> Bugs: GEODE-513
> https://issues.apache.org/jira/browse/GEODE-513
>
>
> Repository: geode
>
>
> Description
> -------
>
> The test is to trigger some exceptions. So for these exception should add expected exception to resolve the suspect strings.
>
>
> Diffs
> -----
>
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/execute/PRClientServerRegionFunctionExecutionSingleHopDUnitTest.java c0b0d3c
>
> Diff: https://reviews.apache.org/r/39763/diff/
>
>
> Testing
> -------
>
> the dunit test case
>
>
> Thanks,
>
> xiaojian zhou
>
>