[GitHub] [pinot] saurabhd336 commented on a diff in pull request #8663: Realtime table consumption resume API

[GitBox <gi...@apache.org>]

saurabhd336 commented on code in PR #8663:
URL: https://github.com/apache/pinot/pull/8663#discussion_r870107540


##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -701,7 +702,7 @@ private void createNewSegmentZKMetadata(TableConfig tableConfig, PartitionLevelS
   }
 
   @Nullable
-  private SegmentPartitionMetadata getPartitionMetadataFromTableConfig(TableConfig tableConfig, int partitionId) {
+  public static SegmentPartitionMetadata getPartitionMetadataFromTableConfig(TableConfig tableConfig, int partitionId) {

Review Comment:
   Ack



##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -1266,7 +1267,7 @@ long getCurrentTimeMs() {
     return System.currentTimeMillis();
   }
 
-  private int getNumReplicas(TableConfig tableConfig, InstancePartitions instancePartitions) {
+  public static int getNumReplicas(TableConfig tableConfig, InstancePartitions instancePartitions) {

Review Comment:
   Ack



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org