You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2023/03/03 11:53:00 UTC
[jira] [Work logged] (WW-5290) Refactor ConfigurationManager
[ https://issues.apache.org/jira/browse/WW-5290?focusedWorklogId=848915&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-848915 ]
ASF GitHub Bot logged work on WW-5290:
--------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/23 11:52
Start Date: 03/Mar/23 11:52
Worklog Time Spent: 10m
Work Description: kusalk opened a new pull request, #666:
URL: https://github.com/apache/struts/pull/666
WW-5290
--
Apart from improving the readability and maintainability of this class, this refactor fixes some logic issues and prevents improper use. It enforces thread safety and also improves performance, specifically on initialisation. We no longer do 2 reloads unnecessarily in certain scenarios.
I've additionally ran these changes through the Confluence DC test suite and everything is passing. :)
Issue Time Tracking
-------------------
Worklog Id: (was: 848915)
Remaining Estimate: 0h
Time Spent: 10m
> Refactor ConfigurationManager
> -----------------------------
>
> Key: WW-5290
> URL: https://issues.apache.org/jira/browse/WW-5290
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Affects Versions: 6.1.1
> Reporter: Kusal Kithul-Godage
> Priority: Minor
> Fix For: 6.2.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This class needs an overhaul:
> * Readability
> * Performance
> * Thread safety
--
This message was sent by Atlassian Jira
(v8.20.10#820010)