[GitHub] [incubator-doris] acelyc111 commented on a change in pull request #4423: [Api][Config] Increase the config verification function in config update api.

[GitBox <gi...@apache.org>]

acelyc111 commented on a change in pull request #4423:
URL: https://github.com/apache/incubator-doris/pull/4423#discussion_r477430227



##########
File path: be/src/common/configbase.cpp
##########
@@ -237,6 +239,23 @@ bool update(const std::string& value, T& retval) {
     return strtox(valstr, retval);
 }
 
+// check the value before real update operation
+template <typename T>
+Status update_check(const std::string& value, std::function<Status(void*)>& check_func, T &retval) {
+
+    std::string valstr(value);
+    trim(valstr);
+    if (!replaceenv(valstr)) {
+        Status::InvalidArgument(strings::Substitute("convert '$0' failed", value));

Review comment:
       ```suggestion
           return Status::InvalidArgument(strings::Substitute("convert '$0' failed", value));
   ```

##########
File path: be/src/common/configbase.cpp
##########
@@ -295,6 +314,14 @@ bool init(const char* filename, bool fillconfmap) {
 
 #define UPDATE_FIELD(FIELD, VALUE, TYPE)                                             \
     if (strcmp((FIELD).type, #TYPE) == 0) {                                          \
+        auto func_it = RegisterCheckFunction::_s_field_check_func->find(FIELD.name);              \

Review comment:
       `\` need alignment 

##########
File path: be/src/common/configbase.cpp
##########
@@ -237,6 +239,23 @@ bool update(const std::string& value, T& retval) {
     return strtox(valstr, retval);
 }
 
+// check the value before real update operation
+template <typename T>
+Status update_check(const std::string& value, std::function<Status(void*)>& check_func, T &retval) {
+
+    std::string valstr(value);
+    trim(valstr);
+    if (!replaceenv(valstr)) {
+        Status::InvalidArgument(strings::Substitute("convert '$0' failed", value));
+    }
+    // covert value from string to T
+    if(!strtox(valstr, retval)){
+        Status::InvalidArgument(strings::Substitute("convert '$0' failed", value));

Review comment:
       ```suggestion
           return Status::InvalidArgument(strings::Substitute("convert '$0' failed", value));
   ```

##########
File path: be/src/common/config_update_func.h
##########
@@ -0,0 +1,89 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+#ifndef DORIS_BE_SRC_COMMON_CONFIG_UPDATE_FUNC_H
+#define DORIS_BE_SRC_COMMON_CONFIG_UPDATE_FUNC_H
+
+#include "common/status.h"
+#include "configbase.h"
+#include "common/config.h"
+#include "gutil/strings/substitute.h"
+
+namespace doris {
+class Status;
+
+namespace config {
+
+/// regist update check function of config `cumulative_size_based_promotion_size_mbytes`
+/// first, check `cumulative_size_based_promotion_size_mbytes` is greater than or equals 
+/// `cumulative_size_based_promotion_min_size_mbytes`
+/// second, check `cumulative_size_based_promotion_size_mbytes` is greater than or equals 
+/// 2 * `cumulative_size_based_compaction_lower_size_mbytes`
+CONF_Update_Check(cumulative_size_based_promotion_size_mbytes, [](void* config) {

Review comment:
       Have these configs been checked when read from be.conf?
   How about register these check functions when defined them in config.h? It will be closer to the place where we defined them, and avoid using a mistake config name, for example `cumulative_size_based_promotion_size_mbyte `.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org